From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Simplify has_sagv Date: Mon, 22 Oct 2018 17:06:11 -0700 Message-ID: <20181023000611.GF5342@intel.com> References: <874ldeh4vi.fsf@intel.com> <20181022165744.11788-1-rodrigo.vivi@intel.com> <1540252130.2734.44.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03DD96E015 for ; Tue, 23 Oct 2018 00:06:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1540252130.2734.44.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMjIsIDIwMTggYXQgMDQ6NDg6NTBQTSAtMDcwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IEVtIFNlZywgMjAxOC0xMC0yMiDDoHMgMDk6NTcgLTA3MDAsIFJvZHJpZ28gVml2aSBl c2NyZXZldToKPiA+IExldCdzIGFkZCBhIHBsYXRmb3JtIGhhc19zYWd2IGluc3RlYWQgb2YgaGF2 aW5nIGEgZnVsbAo+ID4gZnVuY3Rpb24gdGhhdCBoYW5kbGUgcGxhdGZvcm0gYnkgcGxhdGZvcm0u Cj4gPiAKPiA+IFRoZSBzcGVjaWFsbHkgY2FzZSBmb3IgU0tMIGZvciBub3QgY29udHJvbGxlZCBz YWd2Cj4gPiBpcyBhbHJlYWR5IHRha2VuIGNhcmUgaW5zaWRlIGludGVsX2VuYWJsZV9zYWd2LCBz byB0aGVyZSdzCj4gPiBubyBuZWVkIHRvIGR1cGxpY2F0ZSB0aGUgY2hlY2sgaGVyZS4KPiA+IAo+ ID4gdjI6IEdvIG9uZSBzdGVwIGZ1cnRoZXIgYW5kIHJlbW92ZSBza2wgc3BlY2lhbCBjYXNlLiAo SmFuaSkKPiA+IAo+ID4gdjM6IFNlcGFyYXRlIHJ1bnRpbWUgc3RhdHVzIGhhbmRsZSBmcm9tIGhh c19zYWd2IGZsYWcuIChKYW5pKQo+IAo+IEkga25vdyB0aGlzIGhhcyBwcm9iYWJseSBiZWVuIGRp c2N1c3NlZCBpbiB0aGUgcGFzdCBhbmQgSSBtaXNzZWQgaXQKPiAoc2luY2UgSSBrbm93IHRoaXMg d2FzIGRvbmUgYSBmZXcgdGltZXMgZm9yIG90aGVyIHRoaW5ncyksIGJ1dCBob3cvd2h5Cj4gaXMg dGhpcyBhcHByb2FjaCBiZXR0ZXIgdGhhbiB0aGUgY3VycmVudCBvbmU/IENhbiB5b3UgcGxlYXNl IHdyaXRlIGl0Cj4gaW4gdGhlIGNvbW1pdCBtZXNzYWdlPwoKbXkgYmFkLi4uIGFmdGVyIHN0cmlw cGluZyB0aGlzIG91dCBvZiBteSBSRkMgc2VyaWVzIHRoaXMgZ290CmluZGVlZCBvdXQgb2YgY29u dGV4dC4KCkknbSB0cnlpbmcgdG8gZ2V0IHJpZCBvZiBtYW55IHBsYXRmb3JtIGNvZGVuYW1lIGNo ZWNrcyBzcHJlYWQKYXJvdW5kIHRoZSBjb2RlLgoKSSBiZWxpZXZlIHdlIHNob3VsZCBkbyBtb3N0 IG9mIHRoZSBkZWNpc2lvbnMgYmFzZWQgb24gZGlzcGxheV9nZW4Kb3IgaGFzX2ZlYXR1cmUuIEFu ZCB1c2UgdGhlIHBsYXRmb3JtIGNvZGVuYW1lIGFzIHRoZSBsYXN0IHJlc291cmNlCm9ubHkgd2hl biBnZW4gb3IgZmVhdHVyZSBjYW5ub3QgZGVzY3JpYmUgdGhpbmdzIGJldHRlci4KCj4gUXVpY2ts eSBjaGVja2luZyB0aGUgaW1wbGVtZW50YXRpb24gb2YgaW50ZWxfaGFzX3NhZ3YoKSBzZWVtcyBt dWNoCj4gZWFzaWVyIHRoYW4gc3dpbW1pbmcgdGhyb3VnaCB0aGUgbmVzdGVkIG1hY3JvcyBvZiBp OTE1X3BjaS5jLiBBbmQgdGhlIAo+IHNwZWNpYWwtY2FzZW5lc3Mgb2YgdGhlIE5PVF9DT05UUk9M TEVEIGNhc2UgYmVpbmcgcmVzdHJpY3RlZCB0byBnZW45IGluCj4gdGhlIGN1cnJlbnQgKG5vbi1w YXRjaGVkKSBjb2RlIGFsc28gYXQgZmlyc3QgYXBwZWFycyB0byBiZSBiZXR0ZXIgdGhhbgo+IHRo aXMgcHJvcG9zYWwuIEJ1dCBJJ20gdG90YWxseSB3aWxsaW5nIHRvIHJlYWQgeW91ciBhcmd1bWVu dHMgYW5kCj4gcmVldmFsdWF0ZSBteSBkZWNpc2lvbnMgYmFzZWQgb24gdGhlbSwgc28gcGxlYXNl IHByZXNlbnQgdGhlbS4KCldoZW4geW91IGFyZSBsb29raW5nIG9ubHkgdG8gYSBzaW5nbGUgZmVh dHVyZSB0aGlzIG1pZ2h0IGJlIHRydWUuCldoZW4geW91IGFyZSBsb29raW5nIHRvIHRoZSBwbGF0 Zm9ybSBpdHNlbGYgY29uc29saWRhdGluZyB0aGUgZmVhdHVyZXMKZGVmaW5pdGlvbnMgaW4gYSBz aW5nbGUgcGxhY2UgaXMgZWFzaWVyIHRvIGNoZWNrIGxlZ2FjeSBmZWF0dXJlcyBhbmQKYWRkIG5l dyBwbGF0Zm9ybXMuCgpTcGVjaWFsbHkgSSdkIGxpa2UgdG8gYWRkIGEgbmV3IHBsYXRmb3JtIGdl biBsaW5lIGdlbisrIHdpdGhvdXQKbmVlZCB0byB1c2UgYW55IGNvZGVuYW1lLiBPciB3aXRob3V0 IG1peGluZyB0aGluZ3MgdXAuCklOVEVMX0dFTiA+PSAxMSB8fCBJU19DQU5OT05MQUtFIDovCgpT byBhZGRpbmcgZ2VuX24rMSBzaG91bGQgYmUgYXMgdHJpdmlhbAphcyBnZW5fbiArIDEgbGVnYWN5 Li4uCgo+IAo+ID4gCj4gPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4K PiA+IENjOiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiA+IFNp Z25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAgfCAgMSArCj4g PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYyAgICAgICAgICB8ICAxICsKPiA+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5mby5oIHwgIDEgKwo+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgICAgICAgICAgfCAyOSArKysrKysrKy0tLS0tLS0t LS0tLQo+ID4gLS0tLQo+ID4gIDQgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMTkg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+IGluZGV4 IDMwMTdlZjAzN2ZlZC4uOWI5OGNlYjJkMDI5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+ID4gQEAgLTI2NTAsNiArMjY1MCw3IEBAIGludGVsX2luZm8oY29uc3Qgc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUKPiA+ICpkZXZfcHJpdikKPiA+ICAjZGVmaW5lIEhBU19EREkoZGV2X3By aXYpCQkgKChkZXZfcHJpdiktPmluZm8uaGFzX2RkaSkKPiA+ICAjZGVmaW5lIEhBU19GUEdBX0RC R19VTkNMQUlNRUQoZGV2X3ByaXYpICgoZGV2X3ByaXYpLQo+ID4gPmluZm8uaGFzX2ZwZ2FfZGJn KQo+ID4gICNkZWZpbmUgSEFTX1BTUihkZXZfcHJpdikJCSAoKGRldl9wcml2KS0+aW5mby5oYXNf cHNyKQo+ID4gKyNkZWZpbmUgSEFTX1NBR1YoZGV2X3ByaXYpCQkgKChkZXZfcHJpdiktCj4gPiA+ aW5mby5oYXNfc2FndikKPiA+ICAKPiA+ICAjZGVmaW5lIEhBU19SQzYoZGV2X3ByaXYpCQkgKChk ZXZfcHJpdiktPmluZm8uaGFzX3JjNikKPiA+ICAjZGVmaW5lIEhBU19SQzZwKGRldl9wcml2KQkJ ICgoZGV2X3ByaXYpLQo+ID4gPmluZm8uaGFzX3JjNnApCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3BjaS5jCj4gPiBpbmRleCA0NGU3NDU5MjFhYzEuLjBiMDkxNTVlYWI2MiAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfcGNpLmMKPiA+IEBAIC00NjUsNiArNDY1LDcgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBpbnRlbF9kZXZpY2VfaW5mbwo+ID4gaW50ZWxfY2hlcnJ5dmlld19pbmZvID0gewo+ ID4gIAkuaGFzX2NzciA9IDEsIFwKPiA+ICAJLmhhc19ndWMgPSAxLCBcCj4gPiAgCS5oYXNfaXBj ID0gMSwgXAo+ID4gKwkuaGFzX3NhZ3YgPSAxLCBcCj4gPiAgCS5kZGJfc2l6ZSA9IDg5Ngo+ID4g IAo+ID4gICNkZWZpbmUgU0tMX1BMQVRGT1JNIFwKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5mby5oCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RldmljZV9pbmZvLmgKPiA+IGluZGV4IGFmNzAwMjY0MGNkZi4uZTc3YzhiNjI3ODNm IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8u aAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uaAo+ID4g QEAgLTExNyw2ICsxMTcsNyBAQCBlbnVtIGludGVsX3BwZ3R0IHsKPiA+ICAJZnVuYyhod3NfbmVl ZHNfcGh5c2ljYWwpOyBcCj4gPiAgCWZ1bmMob3ZlcmxheV9uZWVkc19waHlzaWNhbCk7IFwKPiA+ ICAJZnVuYyhzdXBwb3J0c190dik7IFwKPiA+ICsJZnVuYyhoYXNfc2Fndik7IFwKPiA+ICAJZnVu YyhoYXNfaXBjKTsKPiA+ICAKPiA+ICAjZGVmaW5lIEdFTl9NQVhfU0xJQ0VTCQkoNikgLyogQ05M IHVwcGVyIGJvdW5kICovCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcG0uYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiBpbmRleCA2 N2E0ZDA3MzUyOTEuLjdlMzhlZDg0MjFjNyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3BtLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmMKPiA+IEBAIC0zNjA5LDIwICszNjA5LDYgQEAgc3RhdGljIGJvb2wgc2tsX25lZWRzX21lbW9y eV9id193YShzdHJ1Y3QKPiA+IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgCXJldHVy biBmYWxzZTsKPiA+ICB9Cj4gPiAgCj4gPiAtc3RhdGljIGJvb2wKPiA+IC1pbnRlbF9oYXNfc2Fn dihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAtewo+ID4gLQlpZiAoSVNf S0FCWUxBS0UoZGV2X3ByaXYpIHx8IElTX0NPRkZFRUxBS0UoZGV2X3ByaXYpIHx8Cj4gPiAtCSAg ICBJU19DQU5OT05MQUtFKGRldl9wcml2KSB8fCBJU19JQ0VMQUtFKGRldl9wcml2KSkKPiA+IC0J CXJldHVybiB0cnVlOwo+ID4gLQo+ID4gLQlpZiAoSVNfU0tZTEFLRShkZXZfcHJpdikgJiYKPiA+ IC0JICAgIGRldl9wcml2LT5zYWd2X3N0YXR1cyAhPSBJOTE1X1NBR1ZfTk9UX0NPTlRST0xMRUQp Cj4gPiAtCQlyZXR1cm4gdHJ1ZTsKPiA+IC0KPiA+IC0JcmV0dXJuIGZhbHNlOwo+ID4gLX0KPiA+ IC0KPiA+ICAvKgo+ID4gICAqIFNBR1YgZHluYW1pY2FsbHkgYWRqdXN0cyB0aGUgc3lzdGVtIGFn ZW50IHZvbHRhZ2UgYW5kIGNsb2NrCj4gPiBmcmVxdWVuY2llcwo+ID4gICAqIGRlcGVuZGluZyBv biBwb3dlciBhbmQgcGVyZm9ybWFuY2UgcmVxdWlyZW1lbnRzLiBUaGUgZGlzcGxheQo+ID4gZW5n aW5lIGFjY2Vzcwo+ID4gQEAgLTM2MzksMTAgKzM2MjUsMTEgQEAgaW50ZWxfZW5hYmxlX3NhZ3Yo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ICpkZXZfcHJpdikKPiA+ICB7Cj4gPiAgCWludCBy ZXQ7Cj4gPiAgCj4gPiAtCWlmICghaW50ZWxfaGFzX3NhZ3YoZGV2X3ByaXYpKQo+ID4gKwlpZiAo IUhBU19TQUdWKGRldl9wcml2KSkKPiA+ICAJCXJldHVybiAwOwo+ID4gIAo+ID4gLQlpZiAoZGV2 X3ByaXYtPnNhZ3Zfc3RhdHVzID09IEk5MTVfU0FHVl9FTkFCTEVEKQo+ID4gKwlpZiAoZGV2X3By aXYtPnNhZ3Zfc3RhdHVzID09IEk5MTVfU0FHVl9FTkFCTEVEIHx8Cj4gPiArCSAgICBkZXZfcHJp di0+c2Fndl9zdGF0dXMgPT0gSTkxNV9TQUdWX05PVF9DT05UUk9MTEVEKQo+ID4gIAkJcmV0dXJu IDA7Cj4gPiAgCj4gPiAgCURSTV9ERUJVR19LTVMoIkVuYWJsaW5nIHRoZSBTQUdWXG4iKTsKPiA+ IEBAIC0zNjc2LDEwICszNjYzLDExIEBAIGludGVsX2Rpc2FibGVfc2FndihzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZQo+ID4gKmRldl9wcml2KQo+ID4gIHsKPiA+ICAJaW50IHJldDsKPiA+ICAKPiA+ IC0JaWYgKCFpbnRlbF9oYXNfc2FndihkZXZfcHJpdikpCj4gPiArCWlmICghSEFTX1NBR1YoZGV2 X3ByaXYpKQo+ID4gIAkJcmV0dXJuIDA7Cj4gPiAgCj4gPiAtCWlmIChkZXZfcHJpdi0+c2Fndl9z dGF0dXMgPT0gSTkxNV9TQUdWX0RJU0FCTEVEKQo+ID4gKwlpZiAoZGV2X3ByaXYtPnNhZ3Zfc3Rh dHVzID09IEk5MTVfU0FHVl9ESVNBQkxFRCB8fAo+ID4gKwkgICAgZGV2X3ByaXYtPnNhZ3Zfc3Rh dHVzID09IEk5MTVfU0FHVl9OT1RfQ09OVFJPTExFRCkKPiA+ICAJCXJldHVybiAwOwo+ID4gIAo+ ID4gIAlEUk1fREVCVUdfS01TKCJEaXNhYmxpbmcgdGhlIFNBR1ZcbiIpOwo+ID4gQEAgLTM3MjEs NyArMzcwOSwxMCBAQCBib29sIGludGVsX2Nhbl9lbmFibGVfc2FndihzdHJ1Y3QKPiA+IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gIAlpbnQgbGV2ZWwsIGxhdGVuY3k7Cj4gPiAgCWludCBz YWd2X2Jsb2NrX3RpbWVfdXM7Cj4gPiAgCj4gPiAtCWlmICghaW50ZWxfaGFzX3NhZ3YoZGV2X3By aXYpKQo+ID4gKwlpZiAoIUhBU19TQUdWKGRldl9wcml2KSkKPiA+ICsJCXJldHVybiBmYWxzZTsK PiA+ICsKPiA+ICsJaWYgKGRldl9wcml2LT5zYWd2X3N0YXR1cyA9PSBJOTE1X1NBR1ZfTk9UX0NP TlRST0xMRUQpCj4gPiAgCQlyZXR1cm4gZmFsc2U7Cj4gPiAgCj4gPiAgCWlmIChJU19HRU45KGRl dl9wcml2KSkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==