Re: [Outreachy kernel] [PATCH 3/3] staging:rtl8192u: Fix misspellings in comments - Style

[Kimberly Brown <kimbrownkd@gmail.com>]

On Mon, Oct 22, 2018 at 06:53:04PM +0100, Julia Lawall wrote:
> In the subject line, normally the words at the beginning are separated by
> spaces.  Do git log --oneline on the affected file and follow what seems
> most popular.

Thanks for the quick reply, Julia! I did check the git log for this
driver, and the format that I used seemed to be the most popular. Over
the last 4 months, one author has submitted dozens of patches for this
driver with this format, so I matched it.

If you think the normal subject line format with spaces is preferable,
please let me know, and I'll change it.

Kimberly

> 
> julia
> 
> On Mon, 22 Oct 2018, Kimberly Brown wrote:
> 
> > Fix two spelling mistakes in comments. 'informations' should be
> > 'information', and 'imblance' should be 'imbalance'. Issues found by
> > checkpatch.
> >
> > This is a coding style change which should have no impact on runtime
> > code execution.
> >
> > Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
> > ---
> >  drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 +-
> >  drivers/staging/rtl8192u/r819xU_phyreg.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> > index 900f7866d381..e064f43fd8b6 100644
> > --- a/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> > +++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.c
> > @@ -243,7 +243,7 @@ static void cmpk_handle_interrupt_status(struct net_device *dev, u8 *pmsg)
> >  			cmdpkt_beacontimerinterrupt_819xusb(dev);
> >  	}
> >
> > -	/* Other informations in interrupt status we need? */
> > +	/* Other information in interrupt status we need? */
> >
> >  	DMESG("<---- cmpk_handle_interrupt_status()\n");
> >  }
> > diff --git a/drivers/staging/rtl8192u/r819xU_phyreg.h b/drivers/staging/rtl8192u/r819xU_phyreg.h
> > index 65ee6088324c..dc9ddf100eab 100644
> > --- a/drivers/staging/rtl8192u/r819xU_phyreg.h
> > +++ b/drivers/staging/rtl8192u/r819xU_phyreg.h
> > @@ -53,7 +53,7 @@
> >  /* page c */
> >  #define rOFDM0_TRxPathEnable		0xc04
> >  #define rOFDM0_XARxAFE				0xc10  /* RxIQ DC offset, Rx digital filter, DC notch filter */
> > -#define rOFDM0_XARxIQImbalance		0xc14  /* RxIQ imblance matrix */
> > +#define rOFDM0_XARxIQImbalance		0xc14  /* RxIQ imbalance matrix */
> >  #define rOFDM0_XBRxAFE				0xc18
> >  #define rOFDM0_XBRxIQImbalance		0xc1c
> >  #define rOFDM0_XCRxAFE				0xc20
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/552e36244c1487a002b7f130d8b5ee07cb8afff7.1540229302.git.kimbrownkd%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1810221852140.2333%40hadrien.
> For more options, visit https://groups.google.com/d/optout.