From: Willy Tarreau <w@1wt.eu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Git pull ack emails..
Date: Tue, 23 Oct 2018 11:02:45 +0200 [thread overview]
Message-ID: <20181023090245.GC23341@1wt.eu> (raw)
In-Reply-To: <CAHk-=wjS6cjjP+fkZWzzrdZ_fZ1F=PrAGcBc57vKCpNyoD73Vw@mail.gmail.com>
On Tue, Oct 23, 2018 at 09:41:32AM +0100, Linus Torvalds wrote:
> Because yes, the second option likely works fine in most cases, but my
> pull might not actually be final *if* something goes bad (where bad
> might be just "oops, my tests showed a semantic conflict, I'll need to
> fix up my merge" to "I'm going to have to look more closely at that
> warning" to "uhhuh, I'm going to just undo the pull entirely because
> it ended up being broken").
Is that a big problem ? I mean probably those who need an ACK just want
to be sure their PR was not lost between them and you. It's not a guarantee
that the code will be kept till the release anyway, and I tend to think
that changing your mind after attempting a build is not different than
changing your mind 3 days later. So when this happens, you're possibly
expected to simply notify the author later saying "sorry, I changed my
mind and finally I dropped your code for this or that reason". That
should be enough to cover the vast majority of use cases, no ?
Just my two cents,
Willy
next prev parent reply other threads:[~2018-10-23 9:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 8:41 Git pull ack emails Linus Torvalds
2018-10-23 8:53 ` Linus Walleij
2018-10-23 9:10 ` Linus Torvalds
2018-10-23 9:35 ` Kirill A. Shutemov
2018-10-23 9:45 ` Mark Brown
2018-10-23 9:46 ` Linus Torvalds
2018-10-23 20:04 ` Konstantin Ryabitsev
2018-10-25 14:13 ` Linus Torvalds
2018-10-26 17:36 ` Rob Herring
2018-10-26 21:15 ` Mark Brown
2018-11-01 10:18 ` Michael Ellerman
2018-11-07 10:41 ` Boris Brezillon
2018-11-07 23:56 ` Michael Ellerman
2018-10-31 14:27 ` Konstantin Ryabitsev
2018-10-31 18:34 ` Linus Torvalds
2018-10-23 9:02 ` Willy Tarreau [this message]
2018-10-23 9:15 ` Linus Torvalds
2018-10-23 9:23 ` Takashi Iwai
2018-10-23 9:15 ` Ingo Molnar
2018-10-23 9:17 ` Boris Brezillon
2018-10-23 9:47 ` Mark Brown
2018-10-23 9:19 ` Mark Brown
2018-10-23 9:25 ` Greg KH
2018-10-23 9:51 ` James Morris
2018-10-23 9:56 ` Jens Axboe
2018-10-23 12:13 ` Ulf Hansson
2018-10-23 20:41 ` Jacek Anaszewski
2018-10-23 20:01 ` Olof Johansson
2018-10-24 22:21 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023090245.GC23341@1wt.eu \
--to=w@1wt.eu \
--cc=axboe@kernel.dk \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=torvalds@linux-foundation.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.