From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table errors
Date: Tue, 23 Oct 2018 09:44:20 +0000 [thread overview]
Message-ID: <20181023094407.GB26188@jerin> (raw)
In-Reply-To: <20181017100954.18284-3-shreyansh.jain@nxp.com>
-----Original Message-----
> Date: Wed, 17 Oct 2018 10:10:36 +0000
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
> To: "thomas@monjalon.net" <thomas@monjalon.net>
> CC: "dev@dpdk.org" <dev@dpdk.org>, Shreyansh Jain <shreyansh.jain@nxp.com>
> Subject: [dpdk-dev] [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table
> errors
> x-mailer: git-send-email 2.17.1
>
>
> Presence of PA-VA Table is transparent to the drivers. Ignoring the
> return values from table update call.
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/bus/fslmc/fslmc_bus.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
> index 5ba5ce96b..db3026f4e 100644
> --- a/drivers/bus/fslmc/fslmc_bus.c
> +++ b/drivers/bus/fslmc/fslmc_bus.c
> @@ -386,11 +386,11 @@ rte_fslmc_probe(void)
> * This has to be done before probe as some device initialization
> * (during) probe allocate memory (dpaa2_sec) which needs to be pinned
> * to this table.
> + *
> + * Error is ignored as relevant logs are handled within dpaax and
> + * handling for unavailable dpaax table too is transparent to caller.
> */
> - ret = dpaax_iova_table_populate();
> - if (ret) {
> - DPAA2_BUS_WARN("PA->VA Translation table not available;");
> - }
> + dpaax_iova_table_populate();
>
> TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
> TAILQ_FOREACH(drv, &rte_fslmc_bus.driver_list, next) {
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-10-23 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:12 [PATCH 0/3] Reduce logging level for dpaax and fslmc Shreyansh Jain
2018-10-17 9:12 ` [PATCH 1/3] common/dpaax: reduce logging level Shreyansh Jain
2018-10-17 9:16 ` Thomas Monjalon
2018-10-17 9:12 ` [PATCH 2/3] bus/fslmc: ignore dpaax pa-va table errors Shreyansh Jain
2018-10-17 9:12 ` [PATCH 3/3] net/dpaa2: convert logs from errors to debug Shreyansh Jain
2018-10-17 10:10 ` [PATCH v2 0/3] Reduce logging level for dpaax and fslmc Shreyansh Jain
2018-10-17 10:10 ` [PATCH v2 1/3] common/dpaax: reduce logging level Shreyansh Jain
2018-10-23 9:43 ` Jerin Jacob
2018-10-17 10:10 ` [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table errors Shreyansh Jain
2018-10-23 9:44 ` Jerin Jacob [this message]
2018-10-17 10:10 ` [PATCH v2 3/3] net/dpaa2: convert logs from errors to debug Shreyansh Jain
2018-10-24 22:18 ` [PATCH v2 0/3] Reduce logging level for dpaax and fslmc Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023094407.GB26188@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.