All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Lewis Donzis <lew@perftech.com>
Cc: dev@dpdk.org
Subject: Re: Change ether_addr to avoid conflict
Date: Wed, 24 Oct 2018 09:11:38 -0700	[thread overview]
Message-ID: <20181024091138.132d78c5@xeon-e3> (raw)
In-Reply-To: <905F0B17-2987-4847-A054-C94501ACBC2D@perftech.com>

On Wed, 24 Oct 2018 07:35:28 -0500
Lewis Donzis <lew@perftech.com> wrote:

> Please consider changing "struct ether_addr" in rte_ether.h to "struct rte_ether_addr", in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.
> 
> Sometimes, there is need to include /usr/include/net/ethernet.h, but it conflicts with the same structure name in rte_ether.h.  Was there a reason this structure wasn't given the standard rte_ prefix?
> 
> Thanks,
> lew

Only history, remember EAL was first running on bare metal.

Changing to 'struct rte_ether_addr' breaks source of lots of applications.

  reply	other threads:[~2018-10-24 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 12:35 Change ether_addr to avoid conflict Lewis Donzis
2018-10-24 16:11 ` Stephen Hemminger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-21 15:39 Lewis Donzis
2018-10-22 15:06 ` Wiles, Keith
2018-10-23  8:37   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181024091138.132d78c5@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=lew@perftech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.