Re: [Outreachy kernel] [PATCH] staging: gasket: interrupt: use sizeof(*p) for memory allocation

[Sasha Levin <sashal@kernel.org>]

On Wed, Oct 24, 2018 at 12:16:02AM -0400, Kimberly Brown wrote:
>Use sizeof(*p) instead of sizeof(struct P) for memory allocation. This
>change complies with the Linux kernel coding style. It improves
>readability and decreases the opportunity for bugs if the pointer
>variable type is changed. Issue found by checkpatch.
>
>Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
>---
> drivers/staging/gasket/gasket_interrupt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
>index 49d47afad64f..8353ab50b3ec 100644
>--- a/drivers/staging/gasket/gasket_interrupt.c
>+++ b/drivers/staging/gasket/gasket_interrupt.c
>@@ -322,8 +322,7 @@ int gasket_interrupt_init(struct gasket_dev *gasket_dev)
> 	const struct gasket_driver_desc *driver_desc =
> 		gasket_get_driver_desc(gasket_dev);
>
>-	interrupt_data = kzalloc(sizeof(struct gasket_interrupt_data),
>-				 GFP_KERNEL);
>+	interrupt_data = kzalloc(sizeof(*interrupt_data), GFP_KERNEL);
> 	if (!interrupt_data)
> 		return -ENOMEM;
> 	gasket_dev->interrupt_data = interrupt_data;

This looks great. Maybe you'd like to do the same for the rest of the
function as well?

--
Thanks,
Sasha