From: Christoph Hellwig <hch@lst.de>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: axboe@kernel.dk, martin.petersen@oracle.com,
tom.leiming@gmail.com, hch@lst.de, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] block: fix the DISCARD request merge
Date: Wed, 24 Oct 2018 13:22:53 +0200 [thread overview]
Message-ID: <20181024112253.GA18207@lst.de> (raw)
In-Reply-To: <1540350450-15208-1-git-send-email-jianchao.w.wang@oracle.com>
> - /*
> - * not contiguous
> - */
> - if (blk_rq_pos(req) + blk_rq_sectors(req) != blk_rq_pos(next))
> - return NULL;
> -
As suggested previously I think we want something like blk_try_merge
and its return values here. Maybe a blk_try_req_merge that takes
requests instead of bios.
next prev parent reply other threads:[~2018-10-24 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 3:07 [PATCH V3] block: fix the DISCARD request merge Jianchao Wang
2018-10-24 11:22 ` Christoph Hellwig [this message]
2018-10-26 8:05 ` jianchao.wang
2018-10-26 8:07 ` Christoph Hellwig
2018-10-26 8:22 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024112253.GA18207@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.