From: Daniel Vetter <daniel@ffwll.ch>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: igt-dev@lists.freedesktop.org,
Petri Latvala <petri.latvala@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [PATCH i-g-t 2/4] gitlab-ci: Compile using autotools
Date: Wed, 24 Oct 2018 15:07:20 +0200 [thread overview]
Message-ID: <20181024130720.GQ324@phenom.ffwll.local> (raw)
In-Reply-To: <20181024130004.12770-2-arkadiusz.hiler@intel.com>
On Wed, Oct 24, 2018 at 04:00:02PM +0300, Arkadiusz Hiler wrote:
> Let's make sure that IGT compiles with autotools.
>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Should we also test autotools tests, and distcheck? That stuff tends to
break, until someone needs to cut a release again :-)
Similar I guess for meson.
Just an aside, patch itself looks fine.
-Daniel
> ---
> .gitlab-ci.yml | 7 +++++++
> Dockerfile.debian | 8 ++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 030b3405..394cd86d 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -33,6 +33,13 @@ build:tests-debian:
> - meson $MESON_OPTIONS build
> - ninja -C build
>
> +build:tests-debian-autotools:
> + image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
> + stage: build
> + script:
> + - ./autogen.sh --enable-{chamelium,audio,intel,amdgpu,nouveau,tests,runner}
> + - make -j
> +
> ninja:test:
> stage: test
> script:
> diff --git a/Dockerfile.debian b/Dockerfile.debian
> index 1c70f015..104906c1 100644
> --- a/Dockerfile.debian
> +++ b/Dockerfile.debian
> @@ -33,3 +33,11 @@ RUN apt-get install -t stretch-backports -y \
> meson \
> libdrm-dev \
> libdrm-intel1
> +
> +# autotools build deps
> +RUN apt-get install -y \
> + autoconf \
> + automake \
> + xutils-dev \
> + libtool \
> + make
> --
> 2.17.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-10-24 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 13:00 [igt-dev] [PATCH i-g-t 1/4] gitlab-ci: Parametrize images used with CI_ variables Arkadiusz Hiler
2018-10-24 13:00 ` [igt-dev] [PATCH i-g-t 2/4] gitlab-ci: Compile using autotools Arkadiusz Hiler
2018-10-24 13:07 ` Daniel Vetter [this message]
2018-10-24 16:15 ` Arkadiusz Hiler
2018-10-24 13:00 ` [igt-dev] [PATCH i-g-t 3/4] gitlab-ci: Compare test-list.txt(s) generated by meson and autotools Arkadiusz Hiler
2018-10-24 13:00 ` [igt-dev] [PATCH i-g-t 4/4] gitlab-ci: Do meson build with oldest supported meson Arkadiusz Hiler
2018-10-24 13:07 ` Daniel Vetter
2018-10-24 17:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] gitlab-ci: Parametrize images used with CI_ variables Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181024130720.GQ324@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.