From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: [PATCH 3/3] usb: renesas_usbhs: Remove dummy runtime PM callbacks Date: Wed, 24 Oct 2018 16:51:34 +0300 Message-ID: <20181024135134.28456-4-jarkko.nikula@linux.intel.com> References: <20181024135134.28456-1-jarkko.nikula@linux.intel.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20181024135134.28456-1-jarkko.nikula@linux.intel.com> Sender: netdev-owner@vger.kernel.org To: linux-pm@vger.kernel.org Cc: linux-i2c@vger.kernel.org, Wolfram Sang , netdev@vger.kernel.org, "David S . Miller" , Sergei Shtylyov , linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, Yoshihiro Shimoda , Jarkko Nikula List-Id: linux-i2c@vger.kernel.org Platform drivers don't need dummy runtime PM callbacks that just return success in order to have runtime PM happening. This has changed since following commits: 05aa55dddb9e ("PM / Runtime: Lenient generic runtime pm callbacks") 543f2503a956 ("PM / platform_bus: Allow runtime PM by default") 8b313a38ecff ("PM / Platform: Use generic runtime PM callbacks directly") Signed-off-by: Jarkko Nikula --- Only build tested. --- drivers/usb/renesas_usbhs/common.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index a3e1290d682d..0e760f228dd8 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -874,23 +874,9 @@ static int usbhsc_resume(struct device *dev) return 0; } -static int usbhsc_runtime_nop(struct device *dev) -{ - /* Runtime PM callback shared between ->runtime_suspend() - * and ->runtime_resume(). Simply returns success. - * - * This driver re-initializes all registers after - * pm_runtime_get_sync() anyway so there is no need - * to save and restore registers here. - */ - return 0; -} - static const struct dev_pm_ops usbhsc_pm_ops = { .suspend = usbhsc_suspend, .resume = usbhsc_resume, - .runtime_suspend = usbhsc_runtime_nop, - .runtime_resume = usbhsc_runtime_nop, }; static struct platform_driver renesas_usbhs_driver = { -- 2.19.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [3/3] usb: renesas_usbhs: Remove dummy runtime PM callbacks From: Jarkko Nikula Message-Id: <20181024135134.28456-4-jarkko.nikula@linux.intel.com> Date: Wed, 24 Oct 2018 16:51:34 +0300 To: linux-pm@vger.kernel.org Cc: linux-i2c@vger.kernel.org, Wolfram Sang , netdev@vger.kernel.org, "David S . Miller" , Sergei Shtylyov , linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, Yoshihiro Shimoda , Jarkko Nikula List-ID: UGxhdGZvcm0gZHJpdmVycyBkb24ndCBuZWVkIGR1bW15IHJ1bnRpbWUgUE0gY2FsbGJhY2tzIHRo YXQganVzdCByZXR1cm4Kc3VjY2VzcyBpbiBvcmRlciB0byBoYXZlIHJ1bnRpbWUgUE0gaGFwcGVu aW5nLiBUaGlzIGhhcyBjaGFuZ2VkIHNpbmNlCmZvbGxvd2luZyBjb21taXRzOgoKMDVhYTU1ZGRk YjllICgiUE0gLyBSdW50aW1lOiBMZW5pZW50IGdlbmVyaWMgcnVudGltZSBwbSBjYWxsYmFja3Mi KQo1NDNmMjUwM2E5NTYgKCJQTSAvIHBsYXRmb3JtX2J1czogQWxsb3cgcnVudGltZSBQTSBieSBk ZWZhdWx0IikKOGIzMTNhMzhlY2ZmICgiUE0gLyBQbGF0Zm9ybTogVXNlIGdlbmVyaWMgcnVudGlt ZSBQTSBjYWxsYmFja3MgZGlyZWN0bHkiKQoKU2lnbmVkLW9mZi1ieTogSmFya2tvIE5pa3VsYSA8 amFya2tvLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Ci0tLQpPbmx5IGJ1aWxkIHRlc3RlZC4KLS0t CiBkcml2ZXJzL3VzYi9yZW5lc2FzX3VzYmhzL2NvbW1vbi5jIHwgMTQgLS0tLS0tLS0tLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCAxNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3Vz Yi9yZW5lc2FzX3VzYmhzL2NvbW1vbi5jIGIvZHJpdmVycy91c2IvcmVuZXNhc191c2Jocy9jb21t b24uYwppbmRleCBhM2UxMjkwZDY4MmQuLjBlNzYwZjIyOGRkOCAxMDA2NDQKLS0tIGEvZHJpdmVy cy91c2IvcmVuZXNhc191c2Jocy9jb21tb24uYworKysgYi9kcml2ZXJzL3VzYi9yZW5lc2FzX3Vz YmhzL2NvbW1vbi5jCkBAIC04NzQsMjMgKzg3NCw5IEBAIHN0YXRpYyBpbnQgdXNiaHNjX3Jlc3Vt ZShzdHJ1Y3QgZGV2aWNlICpkZXYpCiAJcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgdXNiaHNj X3J1bnRpbWVfbm9wKHN0cnVjdCBkZXZpY2UgKmRldikKLXsKLQkvKiBSdW50aW1lIFBNIGNhbGxi YWNrIHNoYXJlZCBiZXR3ZWVuIC0+cnVudGltZV9zdXNwZW5kKCkKLQkgKiBhbmQgLT5ydW50aW1l X3Jlc3VtZSgpLiBTaW1wbHkgcmV0dXJucyBzdWNjZXNzLgotCSAqCi0JICogVGhpcyBkcml2ZXIg cmUtaW5pdGlhbGl6ZXMgYWxsIHJlZ2lzdGVycyBhZnRlcgotCSAqIHBtX3J1bnRpbWVfZ2V0X3N5 bmMoKSBhbnl3YXkgc28gdGhlcmUgaXMgbm8gbmVlZAotCSAqIHRvIHNhdmUgYW5kIHJlc3RvcmUg cmVnaXN0ZXJzIGhlcmUuCi0JICovCi0JcmV0dXJuIDA7Ci19Ci0KIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgZGV2X3BtX29wcyB1c2Joc2NfcG1fb3BzID0gewogCS5zdXNwZW5kCQk9IHVzYmhzY19zdXNw ZW5kLAogCS5yZXN1bWUJCQk9IHVzYmhzY19yZXN1bWUsCi0JLnJ1bnRpbWVfc3VzcGVuZAk9IHVz YmhzY19ydW50aW1lX25vcCwKLQkucnVudGltZV9yZXN1bWUJCT0gdXNiaHNjX3J1bnRpbWVfbm9w LAogfTsKIAogc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgcmVuZXNhc191c2Joc19kcml2 ZXIgPSB7Cg==