From mboxrd@z Thu Jan  1 00:00:00 1970
From: keith.busch@intel.com (Keith Busch)
Date: Wed, 24 Oct 2018 10:22:10 -0600
Subject: [PATCH 1/2] nvme-cli wdc plugin: Add get pfail dump command.
In-Reply-To: <CAPrnrPAhfJmp48zNDgM3JYP2g0BbgAGDgdkB1OCotXHb_00FcQ@mail.gmail.com>
References: <1539921985-17139-1-git-send-email-dong.ho@wdc.com>
 <20181019171713.GA25247@localhost.localdomain>
 <CAPrnrPAhfJmp48zNDgM3JYP2g0BbgAGDgdkB1OCotXHb_00FcQ@mail.gmail.com>
Message-ID: <20181024162209.GA4461@localhost.localdomain>

On Wed, Oct 24, 2018@07:10:10PM +0300, Eyal BenDavid wrote:
> The patched version fails to build on Fedora 28 (gcc 8.1.1) due to a warning.
> 
> Here is the message:
> 
> cc -D_GNU_SOURCE -D__CHECK_ENDIAN__ -O2 -g -Wall -Werror -std=gnu99
> -DLIBUUID -DNVME_VERSION='"1.6.96.g352d"' -c wdc-nvme.c
> wdc-nvme.c: In function ?wdc_crash_dump?:
> wdc-nvme.c:1151:3: error: ?strncpy? output truncated before
> terminating nul copying 11 bytes from a string of the same length
> [-Werror=stringop-truncation]
>    strncpy(dump_type, "_pfail_dump", 11);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> wdc-nvme.c:1153:3: error: ?strncpy? output truncated before
> terminating nul copying 11 bytes from a string of the same length
> [-Werror=stringop-truncation]
>    strncpy(dump_type, "_crash_dump", 11);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make: *** [Makefile:46: wdc-nvme.o] Error 1
> On Fri, Oct 19, 2018@8:21 PM Keith Busch <keith.busch@linux.intel.com> wrote:

Thanks for the notice. The pattern used in that patch is a bit odd as
you'd normally supply the size of the destination to strncpy rather than
the source. I'll fix that up.