Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_properties: Add functional test for "max bpc" property

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Oct 12, 2018 at 12:18:46AM -0700, Radhakrishna Sripada wrote:
> Test the values in the range advertised by the "max bpc" property.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
>  tests/kms_properties.c | 32 +++++++++++++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index f5a86236f5c8..503a5c251e10 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -82,7 +82,37 @@ static bool ignore_property(uint32_t obj_type, uint32_t prop_flags,
>  	return false;
>  }
>  
> -static const struct additional_test property_functional_test[] = {};
> +static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropertyPtr prop,
> +			      uint32_t prop_id, uint64_t prop_value, bool atomic)
> +{
> +	drmModeAtomicReqPtr req = NULL;
> +	int i, ret;
> +
> +	if (atomic)
> +		req = drmModeAtomicAlloc();
> +
> +	for ( i = prop->values[0]; i < prop->values[1] ; i++) {
> +		if (!atomic) {
> +			ret = drmModeObjectSetProperty(fd, id, type, prop_id, i);
> +
> +			igt_assert_eq(ret, 0);
> +		} else {
> +			ret = drmModeAtomicAddProperty(req, id, prop_id, i);
> +			igt_assert(ret >= 0);
> +
> +			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> +			igt_assert_eq(ret, 0);

Should we read it back to see if it sticks?

or should we be checking with some debugfs to see all
conditions and to see if the max is getting really respected?

( really questions not a request ;) )

> +		}
> +	}
> +
> +	if (atomic)
> +		drmModeAtomicFree(req);
> +}
> +
> +static const struct additional_test property_functional_test[] = {
> +									{"max bpc", DRM_MODE_OBJECT_CONNECTOR,
> +									 max_bpc_prop_test},
> +								 };
>  
>  static bool has_additional_test_lookup(uint32_t obj_type, const char *name,
>  				bool atomic, int *index)
> -- 
> 2.9.3
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev