From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: qi.z.zhang@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] net/i40e: update Tx offload mask
Date: Thu, 25 Oct 2018 13:35:46 +0800 [thread overview]
Message-ID: <20181025053546.GA55104@intel.com> (raw)
In-Reply-To: <1540275271-71330-1-git-send-email-beilei.xing@intel.com>
On 10/23, Beilei Xing wrote:
>Tx offload mask is updated in following commit:
>commit 1037ed842c37 ("mbuf: fix Tx offload mask").
>Currently, the new added offload flags will be
>not supported in PMD and application will fail
Shouldn't it be "the new added offlaod flags are not supported in PMD and xxxx"?
Thanks,
Xiaolong
>to call PMD transmit prepare function.
>This patch updates PMD Tx offload mask.
>
>Cc: stable@dpdk.org
>
>Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>---
> drivers/net/i40e/i40e_rxtx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
>index b2819f7..a827456 100644
>--- a/drivers/net/i40e/i40e_rxtx.c
>+++ b/drivers/net/i40e/i40e_rxtx.c
>@@ -55,6 +55,10 @@
> PKT_TX_OUTER_IP_CKSUM)
>
> #define I40E_TX_OFFLOAD_MASK ( \
>+ PKT_TX_OUTER_IPV4 | \
>+ PKT_TX_OUTER_IPV6 | \
>+ PKT_TX_IPV4 | \
>+ PKT_TX_IPV6 | \
> PKT_TX_IP_CKSUM | \
> PKT_TX_L4_MASK | \
> PKT_TX_OUTER_IP_CKSUM | \
>--
>2.5.5
>
prev parent reply other threads:[~2018-10-25 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 6:14 [PATCH] net/i40e: update Tx offload mask Beilei Xing
2018-10-24 20:40 ` Zhang, Qi Z
2018-10-25 5:35 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025053546.GA55104@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.