All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Jan Kara <jack@suse.cz>
Cc: viro@zeniv.linux.org.uk, amir73il@gmail.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH v3 01/10] fs: common implementation of file type
Date: Thu, 25 Oct 2018 15:24:29 +0100	[thread overview]
Message-ID: <20181025142429.GA11865@pathfinder> (raw)
In-Reply-To: <20181025134259.GH3626@quack2.suse.cz>

On Thu, Oct 25, 2018 at 03:42:59PM +0200, Jan Kara wrote:
> On Thu 25-10-18 13:56:23, Phillip Potter wrote:
> > Thanks for your comments/feedback, really appreciate it. All good points
> > and I will make sure I act on it all before republishing the series. I'd
> > be interested to know your thoughts on Ted T'so's suggestion about moving
> > the new header to the uapi area - yes or no in your opinion? Happy with
> > either, but looking for the widest possible acceptance. Thanks.
> 
> I don't think moving this to uapi headers makes sense. As Amir wrote, all
> necessary definitions for userspace already come from glibc headers.
> 
> 								Honza
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR

Thanks, I will leave it in include/linux for now then and separate out the
relevant parts to a separate C file as you suggested.

Regards,
Phil

  reply	other threads:[~2018-10-25 22:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 20:19 [RFC][PATCH v3 01/10] fs: common implementation of file type Phillip Potter
2018-10-24  6:16 ` Amir Goldstein
2018-10-24  8:21   ` Phillip Potter
2018-10-24  9:20     ` Amir Goldstein
2018-10-24  9:31       ` Phillip Potter
2018-10-24  9:44         ` Amir Goldstein
2018-10-24  9:56           ` Phillip Potter
2018-10-24 10:06             ` Amir Goldstein
2018-10-26 14:45   ` Phillip Potter
2018-10-24 12:37 ` Al Viro
2018-10-24 13:33   ` Phillip Potter
2018-10-24 13:02 ` Theodore Y. Ts'o
2018-10-24 13:39   ` Phillip Potter
2018-10-24 14:41   ` Amir Goldstein
2018-10-24 19:51     ` Phillip Potter
2018-10-25 11:20 ` Jan Kara
2018-10-25 12:56   ` Phillip Potter
2018-10-25 13:42     ` Jan Kara
2018-10-25 14:24       ` Phillip Potter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-27  0:53 Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025142429.GA11865@pathfinder \
    --to=phil@philpotter.co.uk \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.