All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Fields <bfields@fieldses.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Amir Goldstein <amir73il@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	syzbot+376cea2b0ef340db3dd4@syzkaller.appspotmail.com,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Petr Mladek <pmladek@suse.com>,
	"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	syzkaller-bugs@googlegroups.com, Jan Harkes <jaharkes@cs.cmu.edu>,
	Mark Fasheh <mark@fasheh.com>
Subject: Re: KASAN: slab-out-of-bounds Read in string (2)
Date: Thu, 25 Oct 2018 11:02:19 -0400	[thread overview]
Message-ID: <20181025150219.GA5539@fieldses.org> (raw)
In-Reply-To: <09f6038b7642f425eba162ea2239552e12da2045.camel@kernel.org>

On Wed, Oct 24, 2018 at 06:40:35AM -0400, Jeff Layton wrote:
> On Wed, 2018-10-24 at 12:35 +0300, Amir Goldstein wrote:
> > > > diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> > > > index d35cd6be0675..93fb7cf0b92b 100644
> > > > --- a/fs/lockd/host.c
> > > > +++ b/fs/lockd/host.c
> > > > @@ -341,7 +341,7 @@ struct nlm_host *nlmsvc_lookup_host(const struct
> > > > svc_rqst *rqstp,
> > > >         };
> > > >         struct lockd_net *ln = net_generic(net, lockd_net_id);
> > > > 
> > > > -       dprintk("lockd: %s(host='%*s', vers=%u, proto=%s)\n", __func__,
> > > > +       dprintk("lockd: %s(host='%.*s', vers=%u, proto=%s)\n", __func__,
> > > >                         (int)hostname_len, hostname, rqstp->rq_vers,
> > > >                         (rqstp->rq_prot == IPPROTO_UDP ? "udp" : "tcp"));
> > > > 
> > > 
> > > Why wasn't this one applied?  It looks correct to me.  The rest seem to
> > > have been fixed already.
> > > 
> > 
> > I did not send this patch to Jeff.
> > Jeff was CC'ed on the patch I sent to Miklos
> > and Miklos decided to only take the overlayfs bits:
> > https://marc.info/?l=linux-unionfs&m=153847248625015&w=2
> > 
> > So I guess it has fallen between the cracks.
> > Feel free to send a patch to Jeff.
> > 
> > Thanks,
> > Amir.
> 
> Actually, this should probably go to Bruce, as he mostly takes care of
> lockd. Patch looks correct though.

Yes, if you could resend I'd be happy to handle it.--b.

  reply	other threads:[~2018-10-25 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 14:45 KASAN: slab-out-of-bounds Read in string (2) syzbot
2018-09-28 14:55 ` Dmitry Vyukov
2018-09-28 17:39   ` Amir Goldstein
2018-10-24  9:09     ` Dan Carpenter
2018-10-24  9:35       ` Amir Goldstein
2018-10-24 10:40         ` Jeff Layton
2018-10-25 15:02           ` Bruce Fields [this message]
2018-10-25 15:17             ` Amir Goldstein
2018-10-25 16:19               ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025150219.GA5539@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=amir73il@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dvyukov@google.com \
    --cc=jaharkes@cs.cmu.edu \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=miklos@szeredi.hu \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=syzbot+376cea2b0ef340db3dd4@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.