All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] imx: mkimage: avoid stop CI when required files not exists
Date: Thu, 25 Oct 2018 16:28:17 +0200	[thread overview]
Message-ID: <20181025162817.4f194643@crub> (raw)
In-Reply-To: <20181025083829.22460-1-peng.fan@nxp.com>

On Thu, 25 Oct 2018 08:32:40 +0000
Peng Fan peng.fan at nxp.com wrote:
...
> diff --git a/tools/imx_cntr_image.sh b/tools/imx_cntr_image.sh
> new file mode 100755
> index 0000000000..4c629e8694
> --- /dev/null
> +++ b/tools/imx_cntr_image.sh
> @@ -0,0 +1,29 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +# script to check whether the file exists in imximage.cfg for i.MX8
> +#
> +# usage: $0 <imximage.cfg>
> +
> +file=$1
> +
> +blobs=`awk '/^APPEND/ {print $2} /^IMAGE/ || /^DATA/ {print $3}' $file`

If we want to skip checking for u-boot-dtb.bin, then better drop
DATA pattern matching. This should be okay since we have only one
DATA field and it is for u-boot-dtb.bin.

Please use blobs=`awk '/^APPEND/ {print $2} /^IMAGE/ {print $3}'`

> +for f in $blobs; do
> +	tmp=$srctree/$f
> +	if [ $f == "u-boot-dtb.bin" ]; then
> +		continue
> +	fi

and drop the above string check.

> +
> +	if [ -f $f ]; then
> +		continue
> +	fi
> +
> +	if [ ! -f $tmp ]; then
> +		echo "WARNING '$tmp' not found, resulting binary is not-functional" >&2
> +		exit 1
> +	fi
> +
> +	sed -in "s;$f;$tmp;" $file
> +done
> +
> +exit 0


--
Anatolij

      reply	other threads:[~2018-10-25 14:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  8:32 [U-Boot] [PATCH V2] imx: mkimage: avoid stop CI when required files not exists Peng Fan
2018-10-25 14:28 ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025162817.4f194643@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.