From: Jiri Pirko <jiri@resnulli.us>
To: Chas Williams <3chas3@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports
Date: Thu, 25 Oct 2018 23:10:09 +0200 [thread overview]
Message-ID: <20181025211008.GA2229@nanopsycho.orion> (raw)
In-Reply-To: <20181025210227.25544-1-3chas3@gmail.com>
Thu, Oct 25, 2018 at 11:02:27PM CEST, 3chas3@gmail.com wrote:
>netif_is_lag_port should be used to identify link aggregation ports.
>For this to work, we need to reorganize the bonding and team drivers
>so that the necessary flags are set before dev_open is called.
>
>commit 31e77c93e432 ("sched/fair: Update blocked load when newly idle")
>made this decision originally based on the IFF_SLAVE flag which isn't
>used by the team driver. Note, we do need to retain the IFF_SLAVE
>check for the eql driver.
>
>Signed-off-by: Chas Williams <3chas3@gmail.com>
>---
> drivers/net/bonding/bond_main.c | 4 ++--
> drivers/net/team/team.c | 7 +++++--
> net/ipv6/addrconf.c | 2 +-
Subject talks about "team" yet you modify bond and team. Confusing..
next prev parent reply other threads:[~2018-10-26 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 21:02 [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports Chas Williams
2018-10-25 21:10 ` Jiri Pirko [this message]
2018-10-25 22:08 ` Chas Williams
2018-10-25 21:59 ` Jay Vosburgh
2018-10-25 22:12 ` Chas Williams
2018-10-25 22:40 ` Jay Vosburgh
2018-10-26 6:01 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025211008.GA2229@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=3chas3@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.