From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Rui Salvaterra <rsalvaterra@gmail.com>,
Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>,
Xiao Ni <xni@redhat.com>,
Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Subject: Re: [PATCH 2/3] block: cleanup __blkdev_issue_discard()
Date: Fri, 26 Oct 2018 09:45:15 +0200 [thread overview]
Message-ID: <20181026074515.GB4660@lst.de> (raw)
In-Reply-To: <20181026062435.21398-3-ming.lei@redhat.com>
On Fri, Oct 26, 2018 at 02:24:34PM +0800, Ming Lei wrote:
> Cleanup __blkdev_issue_discard().
It would help to explain what you clean up..
> + unsigned int req_sects = min(nr_sects, (UINT_MAX >> 9) & ~bs_mask);
This creates an overly long line.
next prev parent reply other threads:[~2018-10-26 7:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 6:24 [PATCH 0/3] block: make sure discard/writesame bio is aligned with logical block size Ming Lei
2018-10-26 6:24 ` [PATCH 1/3] block: make sure discard " Ming Lei
2018-10-26 7:44 ` Christoph Hellwig
2018-10-28 0:51 ` Ming Lei
2018-10-28 15:49 ` Christoph Hellwig
2018-10-29 2:42 ` Ming Lei
2018-10-26 6:24 ` [PATCH 2/3] block: cleanup __blkdev_issue_discard() Ming Lei
2018-10-26 7:45 ` Christoph Hellwig [this message]
2018-10-26 6:24 ` [PATCH 3/3] block: make sure writesame bio is aligned with logical block size Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026074515.GB4660@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mariusz.dabrowski@intel.com \
--cc=ming.lei@redhat.com \
--cc=rsalvaterra@gmail.com \
--cc=snitzer@redhat.com \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.