From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Reuse plane format modifier
 checks to verify addfb() arguments
Date: Fri, 26 Oct 2018 17:45:57 +0300
Message-ID: <20181026144557.GU9144@intel.com>
References: <20181026013256.30808-1-dhinakaran.pandiyan@intel.com>
 <20181026013256.30808-2-dhinakaran.pandiyan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C46926E4B3
 for <intel-gfx@lists.freedesktop.org>; Fri, 26 Oct 2018 14:46:00 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181026013256.30808-2-dhinakaran.pandiyan@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBPY3QgMjUsIDIwMTggYXQgMDY6MzI6NTZQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k
aXlhbiB3cm90ZToKPiBDdXJyZW50bHkgdGhlcmUgaXMgc29tZSBkdXBsaWNhdGlvbiBvZiBwaXhl
bCBmb3JtYXQgYW5kIG1vZGlmaWVyCj4gdmFsaWRhdGlvbiBjb2RlIGJldHdlZW4gdGhlIGZiIGNy
ZWF0aW9uIGFuZCBwbGFuZSBjaGVjayBwYXRocy4gV2UgY2FuCj4gdW5pZnkgdGhlbSBieSBjaGVj
a2luZyBpZiBhbnkgcGxhbmUgc3VwcG9ydHMgYSBwaXhlbCBmb3JtYXQgYW5kIG1vZGlmaWVyCj4g
Y29tYmluYXRpb24gZHVyaW5nIGZyYW1lYnVmZmVyIGNyZWF0aW9uLgo+IAo+IFN1Z2dlc3RlZC1i
eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzog
VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQt
b2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNv
bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTE2ICsr
KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxOSBp
bnNlcnRpb25zKCspLCA5NyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGlzcGxheS5jCj4gaW5kZXggZmUwNDVhYmI2NDcyLi4xYjVkOTM2YTkzZDAgMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTE0MzYyLDYgKzE0MzYyLDE5IEBAIHUz
MiBpbnRlbF9mYl9waXRjaF9saW1pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs
Cj4gIAkJCQkgRFJNX01PREVfUk9UQVRFXzApOwo+ICB9Cj4gIAo+ICtzdGF0aWMgYm9vbCBhbnlf
cGxhbmVfc3VwcG9ydHNfZm9ybWF0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK
PiArCQkJCQkgICAgIHVpbnQ2NF90IGZiX21vZGlmaWVyLAo+ICsJCQkJCSAgICAgdWludDMyX3Qg
cGl4ZWxfZm9ybWF0KQoKImZvcm1hdCBmaXJzdCwgbW9kaWZpZXIgc2Vjb25kIiBpcyB0aGUgdHlw
aWNhbCBjb3ZlbnRpb24uCgpCdXQgSSB0aGluayB3ZSBjb3VsZCBzdHVmZiB0aGlzIGVudGlyZSB0
aGluZyBpbnRvIHRoZSBjb3JlLCBpbiBjYXNlCnNvbWVvbmUgZWxzZSB3YW50cyB0byByZXVzZSBp
dC4gSSB0aGluayBJIGV2ZW4gcG9zdGVkIHRoZSBwYXRjaGVzCnRoYXQgZG8gaXQgbGlrZSB0aGF0
LgpBaCB5ZXM6IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9zZXJpZXMvMzk3MDAv
Cgo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPiArCj4gKwlkcm1fZm9yX2VhY2hf
cGxhbmUocGxhbmUsICZkZXZfcHJpdi0+ZHJtKQo+ICsJCWlmICghZHJtX3BsYW5lX2NoZWNrX3Bp
eGVsX2Zvcm1hdChwbGFuZSwgcGl4ZWxfZm9ybWF0LAo+ICsJCQkJCQkgIGZiX21vZGlmaWVyKSkK
PiArCQkJcmV0dXJuIHRydWU7Cj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gIHN0YXRpYyBp
bnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVs
X2ZiLAo+ICAJCQkJICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAJCQkJICBz
dHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9kZV9jbWQpCj4gQEAgLTE0Mzk5LDQwICsxNDQxMiwx
MiBAQCBzdGF0aWMgaW50IGludGVsX2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1l
YnVmZmVyICppbnRlbF9mYiwKPiAgCQl9Cj4gIAl9Cj4gIAo+IC0JLyogUGFzc2VkIGluIG1vZGlm
aWVyIHNhbml0eSBjaGVja2luZy4gKi8KPiAtCXN3aXRjaCAobW9kZV9jbWQtPm1vZGlmaWVyWzBd
KSB7Cj4gLQljYXNlIEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUzoKPiAtCWNhc2UgSTkxNV9G
T1JNQVRfTU9EX1lmX1RJTEVEX0NDUzoKPiAtCQlzd2l0Y2ggKG1vZGVfY21kLT5waXhlbF9mb3Jt
YXQpIHsKPiAtCQljYXNlIERSTV9GT1JNQVRfWEJHUjg4ODg6Cj4gLQkJY2FzZSBEUk1fRk9STUFU
X0FCR1I4ODg4Ogo+IC0JCWNhc2UgRFJNX0ZPUk1BVF9YUkdCODg4ODoKPiAtCQljYXNlIERSTV9G
T1JNQVRfQVJHQjg4ODg6Cj4gLQkJCWJyZWFrOwo+IC0JCWRlZmF1bHQ6Cj4gLQkJCURSTV9ERUJV
R19LTVMoIlJDIHN1cHBvcnRlZCBvbmx5IHdpdGggUkdCODg4OCBmb3JtYXRzXG4iKTsKPiAtCQkJ
Z290byBlcnI7Cj4gLQkJfQo+IC0JCS8qIGZhbGwgdGhyb3VnaCAqLwo+IC0JY2FzZSBJOTE1X0ZP
Uk1BVF9NT0RfWWZfVElMRUQ6Cj4gLQkJaWYgKG1vZGVfY21kLT5waXhlbF9mb3JtYXQgPT0gRFJN
X0ZPUk1BVF9DOCkgewo+IC0JCQlEUk1fREVCVUdfS01TKCJJbmRleGVkIGZvcm1hdCBkb2VzIG5v
dCBzdXBwb3J0IFlmIHRpbGluZ1xuIik7Cj4gLQkJCWdvdG8gZXJyOwo+IC0JCX0KPiAtCQkvKiBm
YWxsIHRocm91Z2ggKi8KPiAtCWNhc2UgSTkxNV9GT1JNQVRfTU9EX1lfVElMRUQ6Cj4gLQkJaWYg
KElOVEVMX0dFTihkZXZfcHJpdikgPCA5KSB7Cj4gLQkJCURSTV9ERUJVR19LTVMoIlVuc3VwcG9y
dGVkIHRpbGluZyAweCVsbHghXG4iLAo+IC0JCQkJICAgICAgbW9kZV9jbWQtPm1vZGlmaWVyWzBd
KTsKPiAtCQkJZ290byBlcnI7Cj4gLQkJfQo+IC0JCWJyZWFrOwo+IC0JY2FzZSBEUk1fRk9STUFU
X01PRF9MSU5FQVI6Cj4gLQljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+IC0JCWJyZWFr
Owo+IC0JZGVmYXVsdDoKPiAtCQlEUk1fREVCVUdfS01TKCJVbnN1cHBvcnRlZCBmYiBtb2RpZmll
ciAweCVsbHghXG4iLAo+IC0JCQkgICAgICBtb2RlX2NtZC0+bW9kaWZpZXJbMF0pOwo+ICsJaWYg
KCFhbnlfcGxhbmVfc3VwcG9ydHNfZm9ybWF0KGRldl9wcml2LCBtb2RlX2NtZC0+bW9kaWZpZXJb
MF0sCj4gKwkJCQkgICAgICAgbW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCkpIHsKPiArCQlEUk1fREVC
VUdfS01TKCJVbnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQgJXMgb3IgbW9kaWZpZXIgMHglbGx4XG4i
LAo+ICsJCQkgICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0
LAo+ICsJCQkJCQkgICAmZm9ybWF0X25hbWUpLAo+ICsJCQkgICAgICAgbW9kZV9jbWQtPm1vZGlm
aWVyWzBdKTsKPiAgCQlnb3RvIGVycjsKPiAgCX0KPiAgCj4gQEAgLTE0NDY2LDY5ICsxNDQ1MSw2
IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QgaW50ZWxfZnJhbWVi
dWZmZXIgKmludGVsX2ZiLAo+ICAJCWdvdG8gZXJyOwo+ICAJfQo+ICAKPiAtCS8qIFJlamVjdCBm
b3JtYXRzIG5vdCBzdXBwb3J0ZWQgYnkgYW55IHBsYW5lIGVhcmx5LiAqLwo+IC0Jc3dpdGNoICht
b2RlX2NtZC0+cGl4ZWxfZm9ybWF0KSB7Cj4gLQljYXNlIERSTV9GT1JNQVRfQzg6Cj4gLQljYXNl
IERSTV9GT1JNQVRfUkdCNTY1Ogo+IC0JY2FzZSBEUk1fRk9STUFUX1hSR0I4ODg4Ogo+IC0JY2Fz
ZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+IC0JCWJyZWFrOwo+IC0JY2FzZSBEUk1fRk9STUFUX1hS
R0IxNTU1Ogo+IC0JCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID4gMykgewo+IC0JCQlEUk1fREVC
VUdfS01TKCJ1bnN1cHBvcnRlZCBwaXhlbCBmb3JtYXQ6ICVzXG4iLAo+IC0JCQkJICAgICAgZHJt
X2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpKTsK
PiAtCQkJZ290byBlcnI7Cj4gLQkJfQo+IC0JCWJyZWFrOwo+IC0JY2FzZSBEUk1fRk9STUFUX0FC
R1I4ODg4Ogo+IC0JCWlmICghSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgJiYgIUlTX0NIRVJSWVZJ
RVcoZGV2X3ByaXYpICYmCj4gLQkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPCA5KSB7Cj4gLQkJ
CURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNcbiIsCj4gLQkJCQkg
ICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9mb3JtYXQsICZmb3JtYXRf
bmFtZSkpOwo+IC0JCQlnb3RvIGVycjsKPiAtCQl9Cj4gLQkJYnJlYWs7Cj4gLQljYXNlIERSTV9G
T1JNQVRfWEJHUjg4ODg6Cj4gLQljYXNlIERSTV9GT1JNQVRfWFJHQjIxMDEwMTA6Cj4gLQljYXNl
IERSTV9GT1JNQVRfWEJHUjIxMDEwMTA6Cj4gLQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA0
KSB7Cj4gLQkJCURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdDogJXNcbiIs
Cj4gLQkJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhlbF9mb3JtYXQs
ICZmb3JtYXRfbmFtZSkpOwo+IC0JCQlnb3RvIGVycjsKPiAtCQl9Cj4gLQkJYnJlYWs7Cj4gLQlj
YXNlIERSTV9GT1JNQVRfQUJHUjIxMDEwMTA6Cj4gLQkJaWYgKCFJU19WQUxMRVlWSUVXKGRldl9w
cml2KSAmJiAhSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPiAtCQkJRFJNX0RFQlVHX0tNUygi
dW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0OiAlc1xuIiwKPiAtCQkJCSAgICAgIGRybV9nZXRfZm9y
bWF0X25hbWUobW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7Cj4gLQkJCWdv
dG8gZXJyOwo+IC0JCX0KPiAtCQlicmVhazsKPiAtCWNhc2UgRFJNX0ZPUk1BVF9ZVVlWOgo+IC0J
Y2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gLQljYXNlIERSTV9GT1JNQVRfWVZZVToKPiAtCWNhc2Ug
RFJNX0ZPUk1BVF9WWVVZOgo+IC0JCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgNSAmJiAhSVNf
RzRYKGRldl9wcml2KSkgewo+IC0JCQlEUk1fREVCVUdfS01TKCJ1bnN1cHBvcnRlZCBwaXhlbCBm
b3JtYXQ6ICVzXG4iLAo+IC0JCQkJICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShtb2RlX2NtZC0+
cGl4ZWxfZm9ybWF0LCAmZm9ybWF0X25hbWUpKTsKPiAtCQkJZ290byBlcnI7Cj4gLQkJfQo+IC0J
CWJyZWFrOwo+IC0JY2FzZSBEUk1fRk9STUFUX05WMTI6Cj4gLQkJaWYgKElOVEVMX0dFTihkZXZf
cHJpdikgPCA5IHx8IElTX1NLWUxBS0UoZGV2X3ByaXYpIHx8Cj4gLQkJICAgIElTX0JST1hUT04o
ZGV2X3ByaXYpKSB7Cj4gLQkJCURSTV9ERUJVR19LTVMoInVuc3VwcG9ydGVkIHBpeGVsIGZvcm1h
dDogJXNcbiIsCj4gLQkJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKG1vZGVfY21kLT5waXhl
bF9mb3JtYXQsCj4gLQkJCQkJCQkgICZmb3JtYXRfbmFtZSkpOwo+IC0JCQlnb3RvIGVycjsKPiAt
CQl9Cj4gLQkJYnJlYWs7Cj4gLQlkZWZhdWx0Ogo+IC0JCURSTV9ERUJVR19LTVMoInVuc3VwcG9y
dGVkIHBpeGVsIGZvcm1hdDogJXNcbiIsCj4gLQkJCSAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUo
bW9kZV9jbWQtPnBpeGVsX2Zvcm1hdCwgJmZvcm1hdF9uYW1lKSk7Cj4gLQkJZ290byBlcnI7Cj4g
LQl9Cj4gLQo+ICAJLyogRklYTUUgbmVlZCB0byBhZGp1c3QgTElOT0ZGL1RJTEVPRkYgYWNjb3Jk
aW5nbHkuICovCj4gIAlpZiAobW9kZV9jbWQtPm9mZnNldHNbMF0gIT0gMCkKPiAgCQlnb3RvIGVy
cjsKPiAtLSAKPiAyLjE0LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz
dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0
b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==