From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 1/3] drm/atomic: Add a generic infrastructure to track underrun errors Date: Fri, 26 Oct 2018 16:13:48 +0200 Message-ID: <20181026161348.5754f37c@bbrezillon> References: <20181025124546.22145-1-boris.brezillon@bootlin.com> <20181025124546.22145-2-boris.brezillon@bootlin.com> <20181026103337.GJ21967@phenom.ffwll.local> <20181026143656.43fec345@bbrezillon> <20181026133615.GN21967@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B7526E48A for ; Fri, 26 Oct 2018 14:13:49 +0000 (UTC) In-Reply-To: <20181026133615.GN21967@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyNiBPY3QgMjAxOCAxNTozNjoxNSArMDIwMApEYW5pZWwgVmV0dGVyIDxkYW5pZWxA ZmZ3bGwuY2g+IHdyb3RlOgoKPiBPbiBGcmksIE9jdCAyNiwgMjAxOCBhdCAwMjozNjo1NlBNICsw MjAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gPiBIaSBEYW5pZWwsCj4gPiAKPiA+IE9uIEZy aSwgMjYgT2N0IDIwMTggMTI6MzM6MzcgKzAyMDAKPiA+IERhbmllbCBWZXR0ZXIgPGRhbmllbEBm ZndsbC5jaD4gd3JvdGU6Cj4gPiAgIAo+ID4gPiBPbiBUaHUsIE9jdCAyNSwgMjAxOCBhdCAwMjo0 NTo0NFBNICswMjAwLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6ICAKPiA+ID4gPiBEaXNwbGF5IGNv bnRyb2xsZXJzIHVzdWFsbHkgcHJvdmlkZSBhIGxvdCBmZWF0dXJlcyBsaWtlIG92ZXJsYXkgcGxh bmVzLAo+ID4gPiA+IGhhcmR3YXJlIHNjYWxlcnMsIGhhcmR3YXJlIHJvdGF0aW9ucywgLi4uCj4g PiA+ID4gTW9zdCBvZiB0aGUgdGltZSB0aG9zZSBmZWF0dXJlcyB3b3JrIGp1c3QgZmluZSB3aGVu IGVuYWJsZWQKPiA+ID4gPiBpbmRlcGVuZGVudGx5LCBidXQgYWN0aXZhdGluZyBhbGwgb2YgdGhl bSBhdCB0aGUgc2FtZSB0aW1lIHRlbmQgdG8KPiA+ID4gPiBzaG93IG90aGVyIGxpbWl0YXRpb25z IGxpa2UgdGhlIGxpbWl0ZWQgbWVtb3J5IGJ1cyBvciBzY2FsZXIKPiA+ID4gPiBiYW5kd2lkdGgu Cj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBzb3J0IG9mIGJhbmR3aWR0aCBlc3RpbWF0aW9uIGlzIGhh cmQgdG8gZ2V0IHJpZ2h0LCBhbmQgd2UKPiA+ID4gPiBzb21ldGltZXMgZmFpbCB0byBwcmVkaWN0 IHRoYXQgYSBzcGVjaWZpYyB3b3JrbG9hZCB3aWxsIG5vdCBwYXNzLAo+ID4gPiA+IHdoaWNoIHdp bGwgbW9zdCBsaWtlbHkgcmVzdWx0IGluIHVuZGVycnVuIGVycm9ycyBzb21ld2hlcmUgaW4gdGhl Cj4gPiA+ID4gZGlzcGxheSBwaXBlbGluZSAobW9zdCBvZiB0aGUgdGltZSBhdCB0aGUgQ1JUQyBs ZXZlbCkuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBwYXRoIGFpbXMgYXQgbWFraW5nIHVuZGVycnVu IGVycm9yIHRyYWNraW5nIGdlbmVyaWMgYW5kIGV4cG9zaW5nCj4gPiA+ID4gdW5kZXJydW4gZXJy b3JzIHRvIHVzZXJzcGFjZSB0aHJvdWdoIGEgZGVidWdmcyBmaWxlLgo+ID4gPiA+IAo+ID4gPiA+ IFRoaXMgd2F5LCBDSSB0b29scyBsaWtlIElHVCwgY2FuIHRyeSB0byBlbmFibGUgYSBidW5jaCBv ZiBmZWF0dXJlcyBhbmQKPiA+ID4gPiBpZiBzdWNoIHVuZGVycnVuIGVycm9ycyBhcmUgcmVwb3J0 ZWQgYWZ0ZXIgdGhlIHNldHRpbmdzIGhhdmUgYmVlbgo+ID4gPiA+IGFjY2VwdGVkIGFuZCBhcHBs aWVkIGJ5IHRoZSBLTVMgaW5mcmFzdHJ1Y3R1cmUuIFdoZW4gdGhhdCBoYXBwZW5zIGl0Cj4gPiA+ ID4gbWVhbnMgdGhlIGxvYWQgdHJhY2tpbmcgYWxnb3JpdGhtIG5lZWRzIHNvbWUgdHdlYWtpbmcv Zml4aW5nLgo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJyZXppbGxvbiA8 Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+IENoYW5nZXMg aW4gdjI6Cj4gPiA+ID4gLSBOZXcgcGF0Y2ggICAgCj4gPiA+IAo+ID4gPiBIbSwgbm90IHdoYXQg SSB0aG91Z2h0IG9mZi4gVGhpcyBpcyBkZWZpbml0ZWx5IG5vdCBnb2luZyB0byBiZSByZXVzYWJs ZQo+ID4gPiBmb3IgaTkxNSwgdGhlIG9ubHkgb3RoZXIgZHJpdmVyIHdpdGggdW5kZXJydW4gcmVw b3J0aW5nLCBzaW5jZSB3ZSBoYXZlCj4gPiA+IHRvbnMgb2YgdW5kZXJydW4gc291cmNlcyAobm90 IGp1c3Qgb25lKS4gQW5kIHdlIG5lZWQgdG8gbWFzay91bm1hc2sgdGhlbQo+ID4gPiBpbmRpdmlk dWFsbHkuICAKPiA+IAo+ID4gSSBhZ3JlZSBpdCdzIG5vdCBwZXJmZWN0LCBidXQgSSBkaWQgaXQg dGhpcyB3YXkgc28gdGhhdCBob3BlZnVsbHkgd2UnbGwKPiA+IGJlIGFibGUgdG8gdXNlIGRybV9h dG9taWNfaGVscGVyX2NvbW1pdF90YWlsKCkgYXQgc29tZSBwb2ludCBpbnN0ZWFkIG9mCj4gPiBo YXZpbmcgb3VyIG93biBpbXBsZW1lbnRhdGlvbi4gIAo+IAo+IEkgZXhwZWN0IGV2ZXJ5IG5vbi10 cml2aWFsIGRyaXZlciB0byBuZWVkIHRvIG92ZXJ3cml0ZSBjb21taXRfdGFpbC4gVGhhdCdzCj4g dGhlIGVudGlyZSBwb2ludCBmb3IgaGF2aW5nIGNyZWF0ZWQgaXQuIEV4Y2VwdGlvbnMgYXJlIGp1 c3QgdGhlIHZlcnksIHZlcnkKPiBzaW1wbGUgb25lcyB3aXRob3V0IGFueXRoaW5nIGZhbmN5LgoK QWdhaW4sIGp1c3QgbXkgb3BpbmlvbiwgYnV0IGRvaW5nIHRoYXQgbWVhbnMgc29tZSBkcml2ZXJz IGFyZSBsZWZ0CmJlaGluZCB3aGVuIG5ldyBzdHVmZiBhcmUgYWRkZWQgdG8gdGhlIGdlbmVyaWMg aGVscGVycywgYW5kIHNvbWV0aW1lcwp0aG9zZSBuZXcgZmVhdHVyZXMgbWlnaHQgYmUgb2YgaW50 ZXJlc3QgdG8gdGhlIGRyaXZlcnMgdGhhdCBhcmUgbm90CmRpcmVjdGx5IHVzaW5nIHRob3NlIGdl bmVyaWMgaGVscGVycywgZXhjZXB0IHRoZXkgdXN1YWxseSBkb24ndCBldmVuCmtub3cgYWJvdXQg aXQgdW50aWwgb25lIGNvbWVzIGF0IGxvb2tpbmcgYXQgdGhlIGdlbmVyaWMgaGVscGVyIGFnYWlu CmFuZCBub3RpY2UgdGhlIGFkZGl0aW9ucy4KTWF5YmUgSSdtIG5vdCBmb2xsb3dpbmcgdGhlIGRy aS1kZXZlbCBNTCBjbG9zZSBlbm91Z2gsIGFuZCBJJ20gcHJvYmFibHkKdGhlIG9uZSB0byBibGFt ZSBoZXJlLCBidXQgSSBzZWUgYSByZWFsIGJlbmVmaXQgaW4gaGF2aW5nIHRoZSBtYXhpbXVtCm51 bWJlciBvZiBkcml2ZXJzIHVzaW5nIHRoZSBnZW5lcmljIGhlbHBlcnMuIFRvIGJlIGhvbmVzdCwg d2l0aCBhIGZldwptb2RpZmljYXRpb25zLCBJIHRoaW5rIHRoZSBWQzQgZHJpdmVyIGNvdWxkIGVu dGlyZWx5IHJlbHkgb24gdGhvc2UKZ2VuZXJpYyBoZWxwZXJzLgoKPiAKPiA+IElmIHRoZXJlJ3Mg YSB3YXkgdG8gYWRkIHByZS9wb3N0X2NvbW1pdCgpIGhvb2tzIChtYXliZSB0aGV5IGFscmVhZHkK PiA+IGV4aXN0PykgYXQgdmFyaW91cyBsZXZlbHMgb2YgdGhlIGRpc3BsYXkgcGlwZWxpbmUgdGhh dCBnZXQgY2FsbGVkIGV2ZW4KPiA+IHdoZW4gdGhlIGFzc29jaWF0ZWQgc3RhdGUgaGFzICpub3Qq IGNoYW5nZWQsIHRoZW4gSSBtaWdodCBiZSBhYmxlIHRvCj4gPiBwbGFjZSBteSBtYXNrL3VubWFz ay9jbGVhciBvcGVyYXRpb25zIHRoZXJlLiBJIHJlYWxseSBuZWVkIHRoYXQgdG8KPiA+IHByb3Bl cmx5IHVubWFzayB0aGUgdW5kZXJydW4gaW50ZXJydXB0LCBvdGhlcndpc2UgdW5kZXJydW5zIG1p Z2h0IG5vdCBiZQo+ID4gZGV0ZWN0ZWQgYWZ0ZXIgdGhlIGZpcnN0IG1vZGVzZXQgaWYgbm90aGlu ZyBjaGFuZ2VkIGluIHN1Yi1wYXJ0cyBvZiB0aGUKPiA+IHBpcGVsaW5lLiAgCj4gCj4gSnVzdCBv dmVyd3JpdGUgY29tbWl0X3RhaWwuIFRoYXQncyB3aHkgaXQgZXhpc3RzLgoKQW5kIHRoYXQncyB3 aGF0IHdlIGRvIGFscmVhZHksIGJ1dCBJIHdhcyBob3BpbmcgdGhhdCBzb21lZGF5IHdlIHdvdWxk CmJlIGFibGUgdG8gc3dpdGNoIHRvIHRoZSBnZW5lcmljIGhlbHBlci4uLgoKPiAKPiA+ID4gSXQn cyBhbHNvIG1pZGxheWVyIG1pc3Rha2UsIHNpbmNlIHlvdSdyZSBzdHVmZiB5b3VyIGNhbGxiYWNr cyBpbnRvIHRoZQo+ID4gPiBkcm1fbW9kZV9jb25maWdfZnVuY3MgY29yZSBzdHJ1Y3R1cmUgKHdo aWNoIHNob3VsZCBvbmx5IGJlIHVzZWQgZm9yIHVhcGkKPiA+ID4gaW50ZXJmYWNlcywgbm90IGhl bHBlciBzdHVmZikuICAKPiA+IAo+ID4gT2theS4KPiA+ICAgCj4gPiA+IAo+ID4gPiBXaGF0IEkg aGFkIGluIG1pbmQgaXMganVzdCBhIHNpbXBsZSBmdW5jdGlvbiB3aGljaCBzcGV3cyBpbnRvIGRt ZXNnIChzbwo+ID4gPiB0aGF0IGk5MTUgY291bGQgdXNlIGl0KSBhbmQgaW5jcmVtZW50cyB0aGUg dW5kZXJydW4gY291bnRlciBpbiBkZWJ1Z2ZzLgo+ID4gPiBFdmVyeXRoaW5nIGVsc2UgbmVlZHMg dG8gYmUgaGFuZGxlZCBpbiBkcml2ZXJzIEkgdGhpbmsuIEUuZy4KPiA+ID4gCj4gPiA+IGRybV9t b2RlX2NvbmZpZ19yZXBvcnRfdW5kZXJydW4oc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ID4g CQkJCWNvbnN0IGNoYXIgKnNvdXJjZSk7Cj4gPiA+IAo+ID4gPiBhbmQgdGhlbiByb2xsaW5nIGl0 IG91dCBmb3IgaTkxNSB0b28gKG90aGVyd2lzZSB0aGVyZSdzIHJlYWxseSBubyBwb2ludCBpbgo+ ID4gPiB0aGUgY29tbW9uIGluZnJhc3RydWN0dXJlKS4gIAo+ID4gCj4gPiBNb2RpZnlpbmcgdGhl IGk5MTUgZHJpdmVyIHdhcyBhIGJpdCBwcmVtYXR1cmUgc2luY2UgSSBkaWRuJ3QgaGF2ZSB5b3Vy Cj4gPiBmZWVkYmFjayBvbiB0aGUgZ2VuZXJhbCBhcHByb2FjaC4gQW5kIGdpdmVuIHlvdXIgcmV2 aWV3LCBJJ20gZ2xhZCBJCj4gPiBkaWRuJ3Qgc3RhcnQgdGhpcyBjb252ZXJzaW9uIDotUC4KPiA+ IAo+ID4gQW55d2F5LCBJIHdhcyBub3QgY29udmluY2VkIGhhdmluZyBhIGdlbmVyaWMgaW5mcmFz dHJ1Y3R1cmUgdG8gcmVwb3J0Cj4gPiB1bmRlcnJ1biBlcnJvcnMgd2FzIG5lZWRlZCBpbiB0aGUg Zmlyc3QgcGxhY2UuIFRoZSBmYWN0IHRoYXQgdGhlc2UKPiA+IGVycm9ycyBhcmUgdmVyeSBIVy1z cGVjaWZpYywgYW5kIHRoYXQgZGF0YSBhdHRhY2hlZCB0byBzdWNoIGV2ZW50cwo+ID4gbWlnaHQg YmUgdXNlZnVsIHRvIHVuZGVyc3RhbmQgd2hhdCBhY3R1YWxseSBoYXBwZW5lZCBtYWtlcyBtZSB0 aGluayB3ZQo+ID4gZG9uJ3QgcmVhbGx5IG5lZWQgdGhpcyBnZW5lcmljIHVuZGVycnVuIHJlcG9y dGluZyBoZWxwZXIuCj4gPiAKPiA+IEFsc28gbm90ZSB0aGF0IElHVCB0ZXN0cyBhcmUgbGlrZWx5 IHRvIGJlIEhXIHNwZWNpZmljIHRvbywgYmVjYXVzZSB0aGUKPiA+IHdvcmtsb2FkIG5lZWRlZCB0 byB0cmlnZ2VyIHVuZGVycnVuIGVycm9ycyBpcyBsaWtlbHkgdG8gZGVwZW5kIG9uIHRoZQo+ID4g cGxhdGZvcm0geW91J3JlIHJ1bm5pbmcgb24uIEFuZCBpZiB5b3UgYWxyZWFkeSBoYXZlIHRvIHdy aXRlIHlvdXIgb3duCj4gPiB0ZXN0cywgSSBkb24ndCBzZWUgY2xlYXIgYmVuZWZpdCBpbiBleHBv c2luZyB1bmRlcnJ1biBlcnJvcnMKPiA+IGdlbmVyaWNhbGx5LiAgCj4gCj4gU2VlIG15IG90aGVy IHJlcGx5IGluIHRoZSBlYXJsaWVyIHRocmVhZDogVGhhdCdzIHdoeSB3ZSdyZSBqdXN0IGR1bXBp bmcKPiBlcnJvcnMgaW50byBkbWVzZywgYW5kIGNhdGNoaW5nIGFueSBzdWNoIHRoaW5nIGluIG91 ciBydW5uZXJzLiBXZSBkbyBub3QKPiBoYXZlIGFueSBzcGVjaWZpYyB1bmRlcnJ1biB0ZXN0cywg d2UgdHJlYXQgdGhlIGVudGlyZSBpZ3QgdGVzdCBzdWl0ZSBvZgo+IGttcyB0ZXN0cyBhcyBvdXIg dW5kZXJydW4gdGVzdCBzdWl0ZS4KPiAKPiBFeHRlbmRpbmcgdGhhdCB3aXRoIG1vcmUgbmFzdHkg Y29ybmVyIGNhc2VzIGlzIG9idmlvdXNseSBncmVhdCwgYW5kIHdpbGwKPiBiZW5lZml0IGV2ZXJ5 b25lLiBCdXQgSSBkb24ndCB0aGluayB5b3Ugd2FudCBhbiBpZ3QgdGVzdGNhc2UgdGhhdCBsb29r cwo+IHNwZWNpZmljYWxseSBmb3IgdW5kZXJydW5zLgoKQWN0dWFsbHksIHRoYXQncyBleGFjdGx5 IHdoYXQgSSB3YW50ZWQgdG8gZG86IHVzZSBjb25maWcgdGhhdCB3ZXJlCmtub3duIHRvIGdlbmVy YXRlIHVuZGVycnVuIGVycm9ycyBhbmQgbWFrZSBzdXJlIHRoZXkgZG9uJ3QgYWZ0ZXIgYWRkaW5n CnRoZSBIVlMgbG9hZCB0cmFja2VyLiBUaGF0J3MgYWxzbyBwYXJ0aWN1bGFybHkgdXNlZnVsIHRv IHRyYWNrCnJlZ3Jlc3Npb25zIGluIHRoaXMgcG9ydGlvbiBvZiB0aGUgY29kZS4KCj4gV2UgZG8g dXNlIGNyYyB0byBodW50IGZvciBzcGVjaWZpYyBpc3N1ZXMsIGJ1dAo+IGFnYWluIHRoYXQncyBw b3J0YWJsZSBiZXR3ZWVuIGRyaXZlcnMuCgpXZSBkb24ndCB1c2UgQ1JDIHlldCwgYnV0IHRoZXJl IHdhcyBwbGFucyB0byBhZGQgdGVzdHMgdXNpbmcgd3JpdGViYWNrCnRvIGNvbXBhcmUgdGhlIG91 dHB1dCBpbWFnZSB0byB3aGF0IHdlIGV4cGVjdCwgYW5kIE1heGltZSBhbHNvIHdvcmtlZApvbiB0 ZXN0cyByZWx5aW5nIG9uIHRoZSBDaGFtZWxpdW0gYm9hcmQuCgpTdGlsbCwga25vd2luZyB3aHkg dGhlIGltYWdlIGlzIGluY29ycmVjdCBpcyB1c2VmdWwsIGFuZCBJIGd1ZXNzIHlvdQpjb3VsZCBo YXZlIGEgd3Jvbmcgb3V0cHV0IHRoYXQgaXMgbm90IG5lY2Vzc2FyaWx5IGNhdXNlZCBieSBhbgp1 bmRlcnJ1biBlcnJvci4gU28gSSB0aGluayBoYXZpbmcgdGVzdHMgdGhhdCBleHBsaWNseSBjaGVj ayBmb3IKdW5kZXJydW4gZXJyb3JzIGlzIGEgZ29vZCB0aGluZy4KCj4gCj4gPiBBbnl3YXksIHRo aXMgaXMganVzdCBteSBvcGluaW9uLCBhbmQgaWYgeW91IHRoaW5rIHdlIGFjdHVhbGx5IG5lZWQg dGhlCj4gPiBkcm1fbW9kZV9jb25maWdfcmVwb3J0X3VuZGVycnVuKCkgZnVuY3Rpb24sIEknbGwg aW1wbGVtZW50IGl0LiAgCj4gCj4gSSBkbyB0aGluayBoYXZpbmcgc29tZSBzdGFuZGFyZCBpbiBo b3cgdGhlc2UgZXJyb3JzIGFyZSByZXBvcnRlZCB3b3VsZCBiZQo+IHVzZWZ1bCwgZXZlbiBpZiBp dCdzIGp1c3QgYSBzcGVjaWFsIERSTV9VTkRFUlJVTl9FUlJPUigpIG1hY3JvLgoKSSdsbCBkZWZp bmUgc3VjaCBhIG1hY3JvLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK