From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v3 02/10] drm/i915/psr: Always wait for idle state when disabling PSR Date: Fri, 26 Oct 2018 09:45:17 -0700 Message-ID: <20181026164517.GD2232@intel.com> References: <20181026011737.23684-1-jose.souza@intel.com> <20181026011737.23684-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 378076E4DF for ; Fri, 26 Oct 2018 16:45:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181026011737.23684-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMjUsIDIwMTggYXQgMDY6MTc6MjlQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBJdCBzaG91bGQgYWx3YXlzIHdhaXQgZm9yIGlkbGUgc3RhdGUgd2hl biBkaXNhYmxpbmcgUFNSIGJlY2F1c2UgUFNSCj4gY291bGQgYmUgaW5hY3RpdmUgZHVlIGEgY2Fs bCB0byBpbnRlbF9wc3JfZXhpdCgpIGFuZCB3aGlsZSBQU1IgaXMKPiBzdGlsbCBiZWluZyBkaXNh YmxlZCBhc3luY2hyb25vdXNseSB1c2Vyc3BhY2UgY291bGQgY2hhbmdlIHRoZQo+IG1vZGVzZXQg Y2F1c2luZyBhIGNhbGwgdG8gcHNyX2Rpc2FibGUoKSB0aGF0IHdpbGwgbm90IHdhaXQgZm9yIFBT Ugo+IGlkbGUgYW5kIHRoZW4gUFNSIHdpbGwgYmUgZW5hYmxlZCBhZ2FpbiB3aGlsZSBQU1IgaXMg c3RpbGwgbm90IGlkbGUuCj4gCj4gdjI6IHJlYmFzZWQgb24gdG9wIG9mIHRoZSBwYXRjaCByZXVz aW5nIHBzcl9leGl0KCkKPiAKPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwu Y29tPgo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVs LmNvbT4KPiBSZXZpZXdlZC1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5k aXlhbkBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8 am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Bzci5jIHwgNDEgKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Bzci5jCj4gaW5kZXggZjY5OGIzZjQ1YzZkLi40YzIyNmI3OGMzZmMgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IEBAIC02NjEsOCArNjYxLDEyIEBAIHN0YXRpYyB2b2lk IGludGVsX3Bzcl9leGl0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ ICAJdTMyIHZhbDsKPiAgCj4gLQlpZiAoIWRldl9wcml2LT5wc3IuYWN0aXZlKQo+ICsJaWYgKCFk ZXZfcHJpdi0+cHNyLmFjdGl2ZSkgewo+ICsJCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkp CgpUaGlzIHNob3VsZCBiZSBQU1IyIGNoZWNrIGluc3RlYWQgb2YgcGxhdGZvcm0gbm8/IQoKPiAr CQkJV0FSTl9PTihJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKSAmIEVEUF9QU1IyX0VOQUJMRSk7Cj4g KwkJV0FSTl9PTihJOTE1X1JFQUQoRURQX1BTUl9DVEwpICYgRURQX1BTUl9FTkFCTEUpOwo+ICAJ CXJldHVybjsKPiArCX0KPiAgCj4gIAlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpIHsK PiAgCQl2YWwgPSBJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKTsKPiBAQCAtNjgwLDMyICs2ODQsMjMg QEAgc3RhdGljIHZvaWQKPiAgaW50ZWxfcHNyX2Rpc2FibGVfc291cmNlKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHApCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+ICsJaTkxNV9yZWdfdCBwc3Jfc3RhdHVzOwo+ICsJdTMy IHBzcl9zdGF0dXNfbWFzazsKPiAgCj4gLQlpZiAoZGV2X3ByaXYtPnBzci5hY3RpdmUpIHsKPiAt CQlpOTE1X3JlZ190IHBzcl9zdGF0dXM7Cj4gLQkJdTMyIHBzcl9zdGF0dXNfbWFzazsKPiAtCj4g LQkJaW50ZWxfcHNyX2V4aXQoZGV2X3ByaXYpOwo+ICsJaW50ZWxfcHNyX2V4aXQoZGV2X3ByaXYp Owo+ICAKPiAtCQlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpIHsKPiAtCQkJcHNyX3N0 YXR1cyA9IEVEUF9QU1IyX1NUQVRVUzsKPiAtCQkJcHNyX3N0YXR1c19tYXNrID0gRURQX1BTUjJf U1RBVFVTX1NUQVRFX01BU0s7Cj4gLQkJfSBlbHNlIHsKPiAtCQkJcHNyX3N0YXR1cyA9IEVEUF9Q U1JfU1RBVFVTOwo+IC0JCQlwc3Jfc3RhdHVzX21hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9N QVNLOwo+IC0JCX0KPiAtCj4gLQkJLyogV2FpdCB0aWxsIFBTUiBpcyBpZGxlICovCj4gLQkJaWYg KGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LAo+IC0JCQkJCSAgICBwc3Jfc3RhdHVz LCBwc3Jfc3RhdHVzX21hc2ssIDAsCj4gLQkJCQkJICAgIDIwMDApKQo+IC0JCQlEUk1fRVJST1Io IlRpbWVkIG91dCB3YWl0aW5nIGZvciBQU1IgSWRsZSBTdGF0ZVxuIik7Cj4gKwlpZiAoZGV2X3By aXYtPnBzci5wc3IyX2VuYWJsZWQpIHsKPiArCQlwc3Jfc3RhdHVzID0gRURQX1BTUjJfU1RBVFVT Owo+ICsJCXBzcl9zdGF0dXNfbWFzayA9IEVEUF9QU1IyX1NUQVRVU19TVEFURV9NQVNLOwo+ICAJ fSBlbHNlIHsKPiAtCQlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpCj4gLQkJCVdBUk5f T04oSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCkgJiBFRFBfUFNSMl9FTkFCTEUpOwo+IC0JCWVsc2UK PiAtCQkJV0FSTl9PTihJOTE1X1JFQUQoRURQX1BTUl9DVEwpICYgRURQX1BTUl9FTkFCTEUpOwo+ ICsJCXBzcl9zdGF0dXMgPSBFRFBfUFNSX1NUQVRVUzsKPiArCQlwc3Jfc3RhdHVzX21hc2sgPSBF RFBfUFNSX1NUQVRVU19TVEFURV9NQVNLOwo+ICAJfQo+ICsKPiArCS8qIFdhaXQgdGlsbCBQU1Ig aXMgaWRsZSAqLwo+ICsJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LCBwc3Jf c3RhdHVzLCBwc3Jfc3RhdHVzX21hc2ssIDAsCj4gKwkJCQkgICAgMjAwMCkpCj4gKwkJRFJNX0VS Uk9SKCJUaW1lZCBvdXQgd2FpdGluZyBQU1IgaWRsZSBzdGF0ZVxuIik7Cj4gIH0KPiAgCj4gIHN0 YXRpYyB2b2lkIGludGVsX3Bzcl9kaXNhYmxlX2xvY2tlZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwKQo+IC0tIAo+IDIuMTkuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK