From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC][PATCH] x86: ptrace: Add function argument access API
Date: Sat, 27 Oct 2018 10:58:08 -0400 [thread overview]
Message-ID: <20181027105808.60bfba7d@vmware.local.home> (raw)
In-Reply-To: <CALCETrXn9zKTb9i1LP3qoFcpqZHF34BdkuZ5D3N0uCmRr+VnbA@mail.gmail.com>
On Fri, 12 Oct 2018 11:21:28 -0700
Andy Lutomirski <luto@amacapital.net> wrote:
> On Fri, Oct 12, 2018 at 9:26 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >
> > Anyone have any issues with this patch?
> >
>
> I'm conceptually okay with it. That being said,
> regs_within_kernel_stack(), which you're indirectly using, is
> off-by-a-few. And updating it to use probe_kernel_read() might be
> nice for robustness.
>
A patch to protect regs_within_kernel_stack() with
probe_kernel_read() has already been accepted. Can someone give an
Acked-by on this patch? As it does touch x86.
Thanks!
-- Steve
prev parent reply other threads:[~2018-10-27 14:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 3:00 [RFC][PATCH] x86: ptrace: Add function argument access API Steven Rostedt
2018-10-12 3:01 ` Steven Rostedt
2018-10-12 16:26 ` Steven Rostedt
2018-10-12 18:21 ` Andy Lutomirski
2018-10-12 18:22 ` Steven Rostedt
2018-10-12 19:54 ` Steven Rostedt
2018-10-15 14:56 ` Masami Hiramatsu
2018-10-16 18:59 ` Steven Rostedt
2018-10-18 2:34 ` Steven Rostedt
2018-10-27 14:58 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027105808.60bfba7d@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.