From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com
Subject: Re: [PATCH 4/4] mt76: add support for reporting tx status with skb
Date: Sat, 27 Oct 2018 17:04:01 +0200 [thread overview]
Message-ID: <20181027150400.GA11469@redhat.com> (raw)
In-Reply-To: <20181025165541.84815-4-nbd@nbd.name>
On Thu, Oct 25, 2018 at 06:55:41PM +0200, Felix Fietkau wrote:
> + struct mt76_tx_cb *cb = mt76_tx_skb_cb(skb);
> + u8 done = MT_TX_CB_DMA_DONE | MT_TX_CB_TXS_DONE;
can be "const u8 done = ..."
> +mt76_tx_status_skb_add(struct mt76_dev *dev, struct mt76_wcid *wcid,
> + struct sk_buff *skb)
> +{
> + struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
> + struct mt76_tx_cb *cb = mt76_tx_skb_cb(skb);
> + int pid;
> +
> + if (!wcid || !wcid->sta)
> + return 0;
Due to !wcid->sta check I can not associate with AP on MT7610U,
because we use pid = 0 for assoc frames which are marked
IEEE80211_TX_CTL_REQ_TX_STATUS .
After removing it and leave just !wcid check, things work ok.
Thanks
Stanislaw
next prev parent reply other threads:[~2018-10-27 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 16:55 [PATCH 1/4] mt76: clean up more unused EXPORT_SYMBOLs Felix Fietkau
2018-10-25 16:55 ` [PATCH 2/4] mt76: mt76x02: skip station tx status for non-sta wcid entries Felix Fietkau
2018-10-25 16:55 ` [PATCH 3/4] mt76: mt76x02: only override control->sta on sw-encrypted tx Felix Fietkau
2018-10-25 16:55 ` [PATCH 4/4] mt76: add support for reporting tx status with skb Felix Fietkau
2018-10-27 15:04 ` Stanislaw Gruszka [this message]
2018-10-27 15:22 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027150400.GA11469@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.