From: Segher Boessenkool <segher@kernel.crashing.org>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v3 1/3] or1k: libgcc: initial support for openrisc
Date: Sat, 27 Oct 2018 18:25:04 -0500 [thread overview]
Message-ID: <20181027232503.GG5766@gate.crashing.org> (raw)
In-Reply-To: <20181027043702.18414-2-shorne@gmail.com>
Hi!
On Sat, Oct 27, 2018 at 01:37:00PM +0900, Stafford Horne wrote:
> + /* Given R = X * Y ... */
> +1: l.sfeq r4, r0 /* while (y != 0) */
> + l.bf 2f
> + l.andi r5, r4, 1 /* if (y & 1) ... */
Do the extra leading spaces mean something?
> + l.sfeqi r4, 0 /* division by zero; return 0. */
In some places (like here) you ident with 8 spaces instead of a tab.
> +/* For signed division we do:
> + *
> + * -x / y = x / -y = -(x / y)
> + * -x % y = -(x % y)
> + * x % -y = x % b
> + *
> + * which has the property that (x/y)*y + (x%y) = x.
> + */
You mean "y" instead of "b" I think.
Segher
next prev parent reply other threads:[~2018-10-27 23:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 4:36 [OpenRISC] [PATCH v3 0/3] OpenRISC port Stafford Horne
2018-10-27 4:37 ` [OpenRISC] [PATCH v3 1/3] or1k: libgcc: initial support for openrisc Stafford Horne
2018-10-27 23:25 ` Segher Boessenkool [this message]
2018-10-28 0:37 ` Stafford Horne
2018-10-28 1:25 ` Richard Henderson
2018-10-29 13:44 ` Stafford Horne
2018-10-27 4:37 ` [OpenRISC] [PATCH v3 2/3] or1k: testsuite: " Stafford Horne
2018-10-28 1:27 ` Richard Henderson
2018-10-27 4:37 ` [OpenRISC] [PATCH v3 3/3] or1k: gcc: " Stafford Horne
2018-10-28 1:56 ` Richard Henderson
2018-10-30 12:18 ` Stafford Horne
2018-10-30 15:57 ` Richard Henderson
2018-10-30 22:44 ` Stafford Horne
2018-10-28 2:57 ` Segher Boessenkool
2018-10-28 21:47 ` Stafford Horne
2018-10-28 22:54 ` Segher Boessenkool
2018-10-30 12:49 ` Stafford Horne
2018-10-30 15:49 ` Segher Boessenkool
2018-10-30 22:35 ` Stafford Horne
2018-10-31 14:39 ` Jeff Law
2018-10-28 23:16 ` Richard Henderson
2018-10-29 13:34 ` Stafford Horne
2018-10-29 16:34 ` Segher Boessenkool
2018-10-29 16:42 ` Richard Henderson
2018-10-30 11:26 ` Stafford Horne
2018-10-30 15:41 ` Segher Boessenkool
2018-10-29 14:28 ` Szabolcs Nagy
2018-11-04 9:05 ` Stafford Horne
2018-11-05 11:13 ` Szabolcs Nagy
2018-11-05 15:10 ` Rich Felker
2018-11-05 20:58 ` Stafford Horne
2018-11-05 20:52 ` Stafford Horne
2018-11-05 19:45 ` Richard Henderson
2018-11-05 20:14 ` Christophe Lyon
2018-10-28 1:29 ` [OpenRISC] [PATCH v3 0/3] OpenRISC port Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027232503.GG5766@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.