From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] rcu: doc: update example about stale data
Date: Sun, 28 Oct 2018 10:21:42 -0700 [thread overview]
Message-ID: <20181028172142.GN4170@linux.ibm.com> (raw)
In-Reply-To: <20181028021653.155513-1-joel@joelfernandes.org>
On Sat, Oct 27, 2018 at 07:16:53PM -0700, Joel Fernandes (Google) wrote:
> The RCU example for 'rejecting stale data' on system-call auditting
> stops iterating through the rules if a deleted one is found. It makes
> more sense to continue looking at other rules once a deleted one is
> rejected. Although the original example is fine, this makes it more
> meaningful.
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Does the actual audit code that this was copied from now include the
continue statement? If so, please update the commit log to state that
and then I will take the resulting patch. (This example was inspired
by a long-ago version of the actual audit code.)
Thanx, Paul
> ---
> Documentation/RCU/listRCU.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/RCU/listRCU.txt b/Documentation/RCU/listRCU.txt
> index adb5a3782846..09e9a4fc723e 100644
> --- a/Documentation/RCU/listRCU.txt
> +++ b/Documentation/RCU/listRCU.txt
> @@ -250,8 +250,7 @@ as follows:
> spin_lock(&e->lock);
> if (e->deleted) {
> spin_unlock(&e->lock);
> - rcu_read_unlock();
> - return AUDIT_BUILD_CONTEXT;
> + continue;
> }
> rcu_read_unlock();
> return state;
> --
> 2.19.1.568.g152ad8e336-goog
>
next prev parent reply other threads:[~2018-10-28 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 2:16 [RFC] rcu: doc: update example about stale data Joel Fernandes (Google)
2018-10-28 4:44 ` Joel Fernandes
2018-10-28 17:29 ` Paul E. McKenney
2018-10-28 17:21 ` Paul E. McKenney [this message]
2018-10-29 1:16 ` Joel Fernandes
2018-10-30 23:50 ` Paul E. McKenney
2018-10-31 0:58 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028172142.GN4170@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.