From: Christoph Hellwig <hch@infradead.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
Bart Van Assche <bvanassche@acm.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Ingo Molnar <mingo@redhat.com>, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH RFC] kernel/locking, fs/direct-io: Introduce and use down_write_nolockdep()
Date: Sun, 28 Oct 2018 13:34:47 -0700 [thread overview]
Message-ID: <20181028203447.GA9330@infradead.org> (raw)
In-Reply-To: <20181028175840.GA744@hirez.programming.kicks-ass.net>
On Sun, Oct 28, 2018 at 06:58:40PM +0100, Peter Zijlstra wrote:
> Also, from a quick look, this has been broken for donkeys years,
> right? That comment:
>
> /* will be released by direct_io_worker */
>
> has been there since 2009. Back then of course it was a mutex, and the
> curious thing is, mutexes have _never_ supported this release from
> another context thing.
direct_io_worker back then was just a helper called by
__blockdev_direct_IO in the same context. But yes, this comment
is horribly out of date.
next prev parent reply other threads:[~2018-10-29 5:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 16:49 [PATCH RFC] kernel/locking, fs/direct-io: Introduce and use down_write_nolockdep() Bart Van Assche
2018-10-26 17:43 ` Matthew Wilcox
2018-10-26 18:11 ` Bart Van Assche
2018-10-26 18:38 ` Matthew Wilcox
2018-10-26 19:12 ` Bart Van Assche
2018-10-27 5:37 ` Dave Chinner
2018-10-28 17:58 ` Peter Zijlstra
2018-10-28 20:34 ` Christoph Hellwig [this message]
2018-10-28 20:45 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028203447.GA9330@infradead.org \
--to=hch@infradead.org \
--cc=bvanassche@acm.org \
--cc=david@fromorbit.com \
--cc=johannes.berg@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.