Re: [Outreachy kernel] [PATCH 2/2] staging: xgifb: vb_setmode: adjust descendant indentation to right

[Kimberly Brown <kimbrownkd@gmail.com>]

On Sun, Oct 28, 2018 at 07:34:50PM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 28 Oct 2018, Kimberly Brown wrote:
> 
> > Adjust descendant indentation so that it is placed substantially to the
> > right. This change improves code readability and complies with the
> > Linux kernel coding style.
> >
> > Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>
> > ---
> >  drivers/staging/xgifb/vb_setmode.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> > index 62b45a30e0f1..3782f8641bf2 100644
> > --- a/drivers/staging/xgifb/vb_setmode.c
> > +++ b/drivers/staging/xgifb/vb_setmode.c
> > @@ -654,7 +654,7 @@ static void XGI_UpdateXG21CRTC(unsigned short ModeNo,
> >  	xgifb_reg_and(pVBInfo->P3d4, 0x11, 0x7F); /* Unlock CR0~7 */
> >  	if (ModeNo == 0x2E &&
> >  	    (XGI330_RefIndex[RefreshRateTableIndex].Ext_CRT1CRTC ==
> > -						      RES640x480x60))
> > +								RES640x480x60))
> 
> The variable RefreshRateTableIndex is really long,and uses camel case,
> which is also not the kernel style.  If there is a shorter version that
> would be acceptable, then perhaps the value to the right of the == could
> be on the same line, thus solving two problems at once.

Julia,

Good point! I propose 'ref_index' to replace 'RefreshRateTableIndex'. I
chose this based on the 'RefreshRateTableIndex' assignment on line 5096:

RefreshRateTableIndex = XGI330_EModeIDTable[ModeIdIndex].REFindex;

Do you have any objections to 'ref_index'? 

Thanks!

> 
> julia
> 
> >  		index = 12;
> >  	else if (ModeNo == 0x2E &&
> >  		 (XGI330_RefIndex[RefreshRateTableIndex].Ext_CRT1CRTC ==
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a85f97b40dabc0f2a978d0928af6bba05b9724e5.1540749179.git.kimbrownkd%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >