From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: Federico Vaga <federico.vaga@cern.ch>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set
Date: Mon, 29 Oct 2018 08:53:01 +0000 [thread overview]
Message-ID: <20181029085259.GA4101@kunai> (raw)
In-Reply-To: <CACXmViZZ3SBPbV4AXK6EsJPfD5TJqEU_-Q36+vz5LxTk_pzq4A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Sun, Oct 21, 2018 at 04:12:10PM +0200, Peter Korsgaard wrote:
> On Mon, Jun 25, 2018 at 6:14 PM Federico Vaga <federico.vaga@cern.ch> wrote:
> >
> > If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
> > - the line can be shared with other devices
> > - it can be a spurious interrupt
> >
> > To avoid reading twice the status register, the ocores_process() function
> > expects it to be read by the caller.
> >
> > Signed-off-by: Federico Vaga <federico.vaga@cern.ch>
>
> Looks good.
>
> Acked-by: Peter Korsgaard <peter@korsgaard.com>
I assume this patch will be resent when the other patches get updated?
Or shall I pick this one independently of the others?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-29 8:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 16:13 i2c:ocores: fixes and polling mechanism Federico Vaga
2018-06-25 16:13 ` Federico Vaga
2018-06-25 16:13 ` [PATCH 1/3] i2c:ocores: stop transfer on timeout Federico Vaga
2018-06-25 16:13 ` Federico Vaga
2018-10-21 14:10 ` Peter Korsgaard
2018-10-24 14:51 ` Federico Vaga
2018-10-24 14:51 ` Federico Vaga
2018-10-26 17:46 ` Peter Korsgaard
2018-10-26 17:46 ` Peter Korsgaard
2018-10-25 7:42 ` Federico Vaga
2018-10-25 7:42 ` Federico Vaga
2018-06-25 16:13 ` [PATCH 2/3] i2c:ocores: do not handle IRQ if IF is not set Federico Vaga
2018-06-25 16:13 ` Federico Vaga
2018-10-21 14:12 ` Peter Korsgaard
2018-10-29 8:53 ` Wolfram Sang [this message]
2018-10-29 14:27 ` Federico Vaga
2018-10-29 14:27 ` Federico Vaga
2018-06-25 16:13 ` [PATCH 3/3] i2c:ocores: add polling interface Federico Vaga
2018-06-25 16:13 ` Federico Vaga
2018-10-21 14:39 ` Peter Korsgaard
2018-10-24 9:51 ` Federico Vaga
2018-10-24 9:51 ` Federico Vaga
2018-10-26 17:45 ` Peter Korsgaard
2018-10-26 17:45 ` Peter Korsgaard
2018-10-29 8:50 ` Federico Vaga
2018-10-29 8:50 ` Federico Vaga
2018-10-29 13:04 ` Peter Korsgaard
2018-10-29 13:04 ` Peter Korsgaard
2018-10-29 13:11 ` Federico Vaga
2018-10-29 13:11 ` Federico Vaga
2018-10-25 7:47 ` Federico Vaga
2018-10-25 7:47 ` Federico Vaga
2018-08-11 17:13 ` i2c:ocores: fixes and polling mechanism Federico Vaga
2018-08-11 17:13 ` Federico Vaga
2018-08-12 15:34 ` Wolfram Sang
2018-08-22 16:16 ` Peter Korsgaard
2018-09-17 16:42 ` Wolfram Sang
2018-09-19 5:15 ` Peter Korsgaard
2018-09-19 6:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029085259.GA4101@kunai \
--to=wsa@the-dreams.de \
--cc=federico.vaga@cern.ch \
--cc=jacmet@sunsite.dk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.