All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ioannis Valasakis <code@wizofe.uk>
Cc: outreachy-kernel@googlegroups.com, rspringer@google.com
Subject: Re: [PATCH] staging: gasket Create a memory allocation path
Date: Mon, 29 Oct 2018 15:31:16 +0100	[thread overview]
Message-ID: <20181029143116.GA558@kroah.com> (raw)
In-Reply-To: <20181029140731.GA18826@kvasir.local>

On Mon, Oct 29, 2018 at 02:07:31PM +0000, Ioannis Valasakis wrote:
> +err_alloc:
> +	kfree(interrupt_data);
> +	kfree(interrupt_data->msix_entries);
> +	kfree(interrupt_data->eventfd_ctxs);

Think about the three lines here, and try to find the bug :)

This is not going to work at all, sorry, please look up what kfree()
does.

thanks,

greg k-h


  parent reply	other threads:[~2018-10-29 14:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 14:07 [PATCH] staging: gasket Create a memory allocation path Ioannis Valasakis
2018-10-29 14:09 ` [Outreachy kernel] " Vaishali Thakkar
2018-10-29 14:14 ` Julia Lawall
2018-10-29 21:31   ` Sasha Levin
2018-10-29 14:31 ` Greg KH [this message]
2018-10-30 13:41   ` Ioannis Valasakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181029143116.GA558@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=code@wizofe.uk \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=rspringer@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.