From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Kan Liang <kan.liang@intel.com>, Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCHES/RFC] Re: A concern about overflow ring buffer mode
Date: Mon, 29 Oct 2018 11:35:06 -0300 [thread overview]
Message-ID: <20181029143506.GF21857@kernel.org> (raw)
In-Reply-To: <0247fca0-5a94-9a83-cefa-282804316729@linux.intel.com>
Em Mon, Oct 29, 2018 at 10:33:06AM -0400, Liang, Kan escreveu:
> On 10/29/2018 9:03 AM, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Oct 26, 2018 at 04:11:51PM -0400, Liang, Kan escreveu:
> > > On 10/26/2018 3:24 PM, Arnaldo Carvalho de Melo wrote:
> > > > Em Fri, Oct 26, 2018 at 03:16:29PM -0400, Liang, Kan escreveu:
> > > It is mainly for performance reason to switch to overwrite mode. The impact
> > > was very small when I did my test. But now the effect is easily noticeable
> > > in other tests. Yes, I agree. We may change it back to non-overwrite mode
> > > until the issue is addressed.
> > So, I have these two patches in my perf/core branch, with Fixes tags
> > that will make them get to the stable kernels, ok?
> I just realized that the problem in KNL will be back if we switch back to
> non-overwrite mode.
> The problem is that users have to wait tens of minutes to see perf top
> results on the screen in KNL. Before that, there is nothing but a black
> screen.
> Sorry I didn't notice it last Friday. Because I thought the ui_warning in
> perf_top__mmap_read() can give user a hint. So the user can switch to
> overwrite mode manually.
> But unfortunately, the ui_warning doesn't work. Because it is called after
> perf_top__mmap_read(). The processing time of perf_top__mmap_read() could be
> tens of minutes.
So we need a way to notice that we're in a machine like that and warn
the user before the wait takes place, ideas on how to do that?
- Arnaldo
next prev parent reply other threads:[~2018-10-29 14:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 17:45 A concern about overflow ring buffer mode David Miller
2018-10-26 18:38 ` Arnaldo Carvalho de Melo
2018-10-26 18:42 ` Arnaldo Carvalho de Melo
2018-10-26 19:02 ` Arnaldo Carvalho de Melo
2018-10-26 19:07 ` Liang, Kan
2018-10-26 19:12 ` Arnaldo Carvalho de Melo
2018-10-26 19:16 ` Liang, Kan
2018-10-26 19:24 ` Arnaldo Carvalho de Melo
2018-10-26 20:11 ` Liang, Kan
2018-10-26 20:43 ` Arnaldo Carvalho de Melo
2018-10-29 13:03 ` [PATCHES/RFC] " Arnaldo Carvalho de Melo
2018-10-29 14:33 ` Liang, Kan
2018-10-29 14:35 ` Arnaldo Carvalho de Melo [this message]
2018-10-29 15:11 ` Liang, Kan
2018-10-29 17:43 ` David Miller
2018-10-29 17:56 ` Arnaldo Carvalho de Melo
2018-10-29 17:40 ` David Miller
2018-10-29 17:42 ` Liang, Kan
2018-10-29 17:48 ` David Miller
2018-10-29 18:20 ` Liang, Kan
2018-10-29 18:32 ` Arnaldo Carvalho de Melo
2018-10-29 22:32 ` Liang, Kan
2018-10-29 22:42 ` David Miller
2018-10-30 1:54 ` Liang, Kan
2018-10-29 21:16 ` David Miller
2018-10-29 17:55 ` Arnaldo Carvalho de Melo
2018-10-30 19:05 ` David Miller
2018-10-31 22:03 ` [tip:perf/urgent] perf top: Do not use overwrite mode by default tip-bot for Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029143506.GF21857@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.