From: Sasha Levin <sashal@kernel.org>
To: Kimberly Brown <kimbrownkd@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [Outreachy kernel] [PATCH 2/2] staging: rtl8723bs: core: cleanup incorrect indentations
Date: Mon, 29 Oct 2018 18:53:49 -0400 [thread overview]
Message-ID: <20181029225349.GA194472@sasha-vm> (raw)
In-Reply-To: <aa90ccf2bfd8a8bcb2741c3eaae82ac881fcdb2e.1540850889.git.kimbrownkd@gmail.com>
On Mon, Oct 29, 2018 at 06:37:28PM -0400, Kimberly Brown wrote:
>diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
>index 33f2649ba2ec..1092bcd34c50 100644
>--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
>+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
>@@ -670,17 +670,17 @@ int rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie,
> authmode = in_ie[cnt];
>
> if ((authmode == _WPA_IE_ID_) && (!memcmp(&in_ie[cnt+2], &wpa_oui[0], 4))) {
>- RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("\n rtw_get_wpa_ie: sec_idx =%d in_ie[cnt+1]+2 =%d\n", sec_idx, in_ie[cnt+1]+2));
>+ RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("\n rtw_get_wpa_ie: sec_idx =%d in_ie[cnt+1]+2 =%d\n", sec_idx, in_ie[cnt+1]+2));
>
>- if (wpa_ie) {
>+ if (wpa_ie) {
> memcpy(wpa_ie, &in_ie[cnt], in_ie[cnt+1]+2);
>
> for (i = 0; i < (in_ie[cnt+1]+2); i = i+8) {
>- RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("\n %2x,%2x,%2x,%2x,%2x,%2x,%2x,%2x\n",
>+ RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_, ("\n %2x,%2x,%2x,%2x,%2x,%2x,%2x,%2x\n",
> wpa_ie[i], wpa_ie[i+1], wpa_ie[i+2], wpa_ie[i+3], wpa_ie[i+4],
> wpa_ie[i+5], wpa_ie[i+6], wpa_ie[i+7]));
>- }
> }
>+ }
>
> *wpa_len = in_ie[cnt+1]+2;
> cnt += in_ie[cnt+1]+2; /* get next */
The indentation of these two lines is now wrong.
Also...
sed -i 's/else{/else {/g' drivers/staging/rtl8723bs/core/rtw_ieee80211.c
#OCD
--
Thanks,
Sasha
prev parent reply other threads:[~2018-10-29 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 22:33 [PATCH 0/2] staging: rtl8723bs: core: cleanup blank lines and indentations Kimberly Brown
2018-10-29 22:36 ` [PATCH 1/2] staging: rtl8723bs: core: remove unnecessary blank lines Kimberly Brown
2018-10-30 11:23 ` Hans de Goede
2018-10-29 22:37 ` [PATCH 2/2] staging: rtl8723bs: core: cleanup incorrect indentations Kimberly Brown
2018-10-29 22:53 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029225349.GA194472@sasha-vm \
--to=sashal@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=kimbrownkd@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.