diff for duplicates of <20181030052646.GB11072@blackberry> diff --git a/a/1.txt b/N1/1.txt index b174c11..a7061d2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -57,7 +57,7 @@ Comments below... > + hmm_hash = kvm->arch.hmm_hash; > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > + hlist_for_each_entry(p, list, hlist) { -> + if (p->addr = gpa) { +> + if (p->addr == gpa) { > + hmm_page = pfn_to_page(p->hmm_pfn); > + get_page(hmm_page); /* TODO: Necessary ? */ > + pvt = (struct kvmppc_hmm_page_pvt *) @@ -71,7 +71,7 @@ Comments below... > + > + ret = get_user_pages_fast(addr, 1, 0, &page); -Why are we calling this with write=0? Surely in general the secure +Why are we calling this with write==0? Surely in general the secure guest will expect to be able to write to the shared page? Also, in general get_user_pages_fast isn't sufficient to translate a @@ -98,7 +98,7 @@ ultravisor a page to use? > + ret = uv_page_in(lpid, pfn << page_shift, gpa, 0, page_shift); > + put_page(page); > + -> + return (ret = U_SUCCESS) ? H_SUCCESS : H_PARAMETER; +> + return (ret == U_SUCCESS) ? H_SUCCESS : H_PARAMETER; > +} > + > /* @@ -127,7 +127,7 @@ Would be best to fail if any unknown flags are set, I would think. > + if (!pvt->skip_page_out) > + ret = uv_page_out(pvt->lpid, pfn << PAGE_SHIFT, > + pvt->gpa, 0, PAGE_SHIFT); -> if (ret = U_SUCCESS) +> if (ret == U_SUCCESS) > *dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED; > } > -- diff --git a/a/content_digest b/N1/content_digest index ebb156f..1727acf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,16 +2,16 @@ "ref\020181022051837.1165-3-bharata@linux.ibm.com\0" "From\0Paul Mackerras <paulus@ozlabs.org>\0" "Subject\0Re: [RFC PATCH v1 2/4] kvmppc: Add support for shared pages in HMM driver\0" - "Date\0Tue, 30 Oct 2018 05:26:46 +0000\0" + "Date\0Tue, 30 Oct 2018 16:26:46 +1100\0" "To\0Bharata B Rao <bharata@linux.ibm.com>\0" - "Cc\0linuxppc-dev@lists.ozlabs.org" + "Cc\0linuxram@us.ibm.com" kvm-ppc@vger.kernel.org - linux-mm@kvack.org - paulus@au1.ibm.com benh@linux.ibm.com - aneesh.kumar@linux.vnet.ibm.com + linux-mm@kvack.org jglisse@redhat.com - " linuxram@us.ibm.com\0" + aneesh.kumar@linux.vnet.ibm.com + paulus@au1.ibm.com + " linuxppc-dev@lists.ozlabs.org\0" "\00:1\0" "b\0" "On Mon, Oct 22, 2018 at 10:48:35AM +0530, Bharata B Rao wrote:\n" @@ -73,7 +73,7 @@ "> +\thmm_hash = kvm->arch.hmm_hash;\n" "> +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> +\thlist_for_each_entry(p, list, hlist) {\n" - "> +\t\tif (p->addr = gpa) {\n" + "> +\t\tif (p->addr == gpa) {\n" "> +\t\t\thmm_page = pfn_to_page(p->hmm_pfn);\n" "> +\t\t\tget_page(hmm_page); /* TODO: Necessary ? */\n" "> +\t\t\tpvt = (struct kvmppc_hmm_page_pvt *)\n" @@ -87,7 +87,7 @@ "> +\n" "> +\tret = get_user_pages_fast(addr, 1, 0, &page);\n" "\n" - "Why are we calling this with write=0? Surely in general the secure\n" + "Why are we calling this with write==0? Surely in general the secure\n" "guest will expect to be able to write to the shared page?\n" "\n" "Also, in general get_user_pages_fast isn't sufficient to translate a\n" @@ -114,7 +114,7 @@ "> +\tret = uv_page_in(lpid, pfn << page_shift, gpa, 0, page_shift);\n" "> +\tput_page(page);\n" "> +\n" - "> +\treturn (ret = U_SUCCESS) ? H_SUCCESS : H_PARAMETER;\n" + "> +\treturn (ret == U_SUCCESS) ? H_SUCCESS : H_PARAMETER;\n" "> +}\n" "> +\n" "> /*\n" @@ -143,7 +143,7 @@ "> +\tif (!pvt->skip_page_out)\n" "> +\t\tret = uv_page_out(pvt->lpid, pfn << PAGE_SHIFT,\n" "> +\t\t\t\t pvt->gpa, 0, PAGE_SHIFT);\n" - "> \tif (ret = U_SUCCESS)\n" + "> \tif (ret == U_SUCCESS)\n" "> \t\t*dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED;\n" "> }\n" "> -- \n" @@ -151,4 +151,4 @@ "\n" Paul. -52ac0d8da2801232b020aa1b12a2ec7e6a817e5653d0bcd3bfb36d2962e0cf65 +4a2470fb4498bd1407cbf795ca144745ba35e4943a88307609f50d6779e8a4a0
diff --git a/a/1.txt b/N2/1.txt index b174c11..a7061d2 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -57,7 +57,7 @@ Comments below... > + hmm_hash = kvm->arch.hmm_hash; > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > + hlist_for_each_entry(p, list, hlist) { -> + if (p->addr = gpa) { +> + if (p->addr == gpa) { > + hmm_page = pfn_to_page(p->hmm_pfn); > + get_page(hmm_page); /* TODO: Necessary ? */ > + pvt = (struct kvmppc_hmm_page_pvt *) @@ -71,7 +71,7 @@ Comments below... > + > + ret = get_user_pages_fast(addr, 1, 0, &page); -Why are we calling this with write=0? Surely in general the secure +Why are we calling this with write==0? Surely in general the secure guest will expect to be able to write to the shared page? Also, in general get_user_pages_fast isn't sufficient to translate a @@ -98,7 +98,7 @@ ultravisor a page to use? > + ret = uv_page_in(lpid, pfn << page_shift, gpa, 0, page_shift); > + put_page(page); > + -> + return (ret = U_SUCCESS) ? H_SUCCESS : H_PARAMETER; +> + return (ret == U_SUCCESS) ? H_SUCCESS : H_PARAMETER; > +} > + > /* @@ -127,7 +127,7 @@ Would be best to fail if any unknown flags are set, I would think. > + if (!pvt->skip_page_out) > + ret = uv_page_out(pvt->lpid, pfn << PAGE_SHIFT, > + pvt->gpa, 0, PAGE_SHIFT); -> if (ret = U_SUCCESS) +> if (ret == U_SUCCESS) > *dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED; > } > -- diff --git a/a/content_digest b/N2/content_digest index ebb156f..942add6 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\020181022051837.1165-3-bharata@linux.ibm.com\0" "From\0Paul Mackerras <paulus@ozlabs.org>\0" "Subject\0Re: [RFC PATCH v1 2/4] kvmppc: Add support for shared pages in HMM driver\0" - "Date\0Tue, 30 Oct 2018 05:26:46 +0000\0" + "Date\0Tue, 30 Oct 2018 16:26:46 +1100\0" "To\0Bharata B Rao <bharata@linux.ibm.com>\0" "Cc\0linuxppc-dev@lists.ozlabs.org" kvm-ppc@vger.kernel.org @@ -73,7 +73,7 @@ "> +\thmm_hash = kvm->arch.hmm_hash;\n" "> +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> +\thlist_for_each_entry(p, list, hlist) {\n" - "> +\t\tif (p->addr = gpa) {\n" + "> +\t\tif (p->addr == gpa) {\n" "> +\t\t\thmm_page = pfn_to_page(p->hmm_pfn);\n" "> +\t\t\tget_page(hmm_page); /* TODO: Necessary ? */\n" "> +\t\t\tpvt = (struct kvmppc_hmm_page_pvt *)\n" @@ -87,7 +87,7 @@ "> +\n" "> +\tret = get_user_pages_fast(addr, 1, 0, &page);\n" "\n" - "Why are we calling this with write=0? Surely in general the secure\n" + "Why are we calling this with write==0? Surely in general the secure\n" "guest will expect to be able to write to the shared page?\n" "\n" "Also, in general get_user_pages_fast isn't sufficient to translate a\n" @@ -114,7 +114,7 @@ "> +\tret = uv_page_in(lpid, pfn << page_shift, gpa, 0, page_shift);\n" "> +\tput_page(page);\n" "> +\n" - "> +\treturn (ret = U_SUCCESS) ? H_SUCCESS : H_PARAMETER;\n" + "> +\treturn (ret == U_SUCCESS) ? H_SUCCESS : H_PARAMETER;\n" "> +}\n" "> +\n" "> /*\n" @@ -143,7 +143,7 @@ "> +\tif (!pvt->skip_page_out)\n" "> +\t\tret = uv_page_out(pvt->lpid, pfn << PAGE_SHIFT,\n" "> +\t\t\t\t pvt->gpa, 0, PAGE_SHIFT);\n" - "> \tif (ret = U_SUCCESS)\n" + "> \tif (ret == U_SUCCESS)\n" "> \t\t*dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED;\n" "> }\n" "> -- \n" @@ -151,4 +151,4 @@ "\n" Paul. -52ac0d8da2801232b020aa1b12a2ec7e6a817e5653d0bcd3bfb36d2962e0cf65 +4be43411b5c903a44ba29e67e57110758baa798572febe932f7a2ce0483f1efa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.