[PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style

[PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style

[Zach Turner]

Add SPDX-License-Identifier tag to the start of the file. This is
a coding style change which should not impact runtime code execution.

Signed-off-by: Zach Turner <turnerzdp@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
index bc45cf098b04..8cfc2a1a5c48 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
@@ -1,5 +1,5 @@
-/*
- * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
+// SPDX-License-Identifier: GPL-2.0-or-later
+/* Host AP crypt: host-based CCMP encryption implementation for Host AP driver
  *
  * Copyright (c) 2003-2004, Jouni Malinen <jkmaline@cc.hut.fi>
  *
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style

[Himanshu Jha]

On Mon, Oct 22, 2018 at 11:25:59PM -0600, Zach Turner wrote:
> Add SPDX-License-Identifier tag to the start of the file. This is
> a coding style change which should not impact runtime code execution.
> 
> Signed-off-by: Zach Turner <turnerzdp@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> index bc45cf098b04..8cfc2a1a5c48 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> @@ -1,5 +1,5 @@
> -/*
> - * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
> +// SPDX-License-Identifier: GPL-2.0-or-later

I believe it should be:

// SPDX-License-Identifier: GPL-2.0+

considering MODULE_LICENSE("GPL")

check Documentation/process/license-rules.rst

Also, the purpose of SPDX tag was to remove bolierplate text:

```
    * This program is free software; you can redistribute it and/or modify
    * it under the terms of the GNU General Public License version 2 as
    * published by the Free Software Foundation. See README and COPYING for
    * more details.
    */
```

But this above text suggest GPLv2 which is inconsistent with MODULE_LICENSE("GPL");
present at the bottom of the file.

Lastly, for these copyrights changes Cc the author of the file too.


-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

Re: [PATCH] staging: rtl8192e: Add SPDX-License-Identifier - Style

[Greg KH]

On Mon, Oct 22, 2018 at 11:25:59PM -0600, Zach Turner wrote:
> Add SPDX-License-Identifier tag to the start of the file. This is
> a coding style change which should not impact runtime code execution.
> 
> Signed-off-by: Zach Turner <turnerzdp@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> index bc45cf098b04..8cfc2a1a5c48 100644
> --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
> @@ -1,5 +1,5 @@
> -/*
> - * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
> +// SPDX-License-Identifier: GPL-2.0-or-later

Please read Documentation/process/license-rules.rst for the proper
string to put here (hint do not use "or-later" in it...)

thanks,

greg k-h