From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v6 4/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0 Date: Tue, 30 Oct 2018 10:30:51 +0100 Message-ID: <20181030093051.GN21967@phenom.ffwll.local> References: <20181029171419.4512-1-alexandru-cosmin.gheorghe@arm.com> <20181029171419.4512-5-alexandru-cosmin.gheorghe@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2CD86E1B6 for ; Tue, 30 Oct 2018 09:30:55 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id v18-v6so9816213edq.13 for ; Tue, 30 Oct 2018 02:30:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181029171419.4512-5-alexandru-cosmin.gheorghe@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru-Cosmin Gheorghe Cc: Charles Xu , nd , Matt Szczesiak , "airlied@linux.ie" , Liviu Dudau , "dri-devel@lists.freedesktop.org" , "maxime.ripard@bootlin.com" , David Garbett , "seanpaul@chromium.org" , Lisa Wu , "daniel.vetter@ffwll.ch" , "malidp@foss.arm.com" , Ayan Halder , "james qian wang (Arm Technology China)" List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMjksIDIwMTggYXQgMDU6MTQ6MzlQTSArMDAwMCwgQWxleGFuZHJ1LUNvc21p biBHaGVvcmdoZSB3cm90ZToKPiBGb3IgZm9ybWF0cyB0aGF0IGFyZSBzdXBwb3J0ZWQgb25seSB3 aXRoIG5vbi1saW5lYXIgbW9kaWZpZXJzIGl0Cj4gZG9lc24ndCBtYWtlIHRvIG11Y2ggc2Vuc2Ug dG8gZGVmaW5lIGNwcCBvciBjaGFyX3Blcl9ibG9jaywgc28gdGhhdAo+IHdpbGwgYmUgc2V0IHRv IDAuCj4gCj4gVGhpcyBwYXRjaCBhZGRzIGEgcmVzdHJpY3Rpb24gdG8gZm9yY2UgaGF2aW5nIGEg bW9kaWZpZXIgYXR0YWNoZWQgd2hlbgo+IGNwcC9jaGFyX3Blcl9ibG9jayBpcyAwLCBhbmQgdG8g YnlwYXNzIGNoZWNraW5nIHRoZSBwaXRjaCByZXN0cmljdGlvbi4KPiAKPiBUaGlzIGhhZCBiZWVu IGRpc2N1c3NlZCBoZXJlLgo+IFsxXSBodHRwczovL3Blb3BsZS5mcmVlZGVza3RvcC5vcmcvfmNi cmlsbC9kcmktbG9nLz9jaGFubmVsPWRyaS1kZXZlbCZoaWdobGlnaHRfbmFtZXM9JmRhdGU9MjAx OC0wOS0xMyZzaG93X2h0bWw9dHJ1ZQo+IAo+IFJldmlld2VkLWJ5OiBCcmlhbiBTdGFya2V5IDxi cmlhbi5zdGFya2V5QGFybS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZHJ1IEdoZW9yZ2hl IDxhbGV4YW5kcnUtY29zbWluLmdoZW9yZ2hlQGFybS5jb20+Cgooa2VybmVsZG9jIGlzIGFscmVh ZHkgcGFydCBvZiBhbiBlYXJsaWVyIHBhdGNoKQoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIg PGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZnJh bWVidWZmZXIuYyB8IDggKysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zy YW1lYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVyLmMKPiBpbmRleCA2 YWNhOGExY2NkYjYuLjE2N2MxYzQ1NDRhZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2ZyYW1lYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZyYW1lYnVmZmVy LmMKPiBAQCAtMTk1LDggKzE5NSwxNCBAQCBzdGF0aWMgaW50IGZyYW1lYnVmZmVyX2NoZWNrKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAlmb3IgKGkgPSAwOyBpIDwgaW5mby0+bnVtX3BsYW5l czsgaSsrKSB7Cj4gIAkJdW5zaWduZWQgaW50IHdpZHRoID0gZmJfcGxhbmVfd2lkdGgoci0+d2lk dGgsIGluZm8sIGkpOwo+ICAJCXVuc2lnbmVkIGludCBoZWlnaHQgPSBmYl9wbGFuZV9oZWlnaHQo ci0+aGVpZ2h0LCBpbmZvLCBpKTsKPiArCQl1bnNpZ25lZCBpbnQgYmxvY2tfc2l6ZSA9IGluZm8t PmNoYXJfcGVyX2Jsb2NrW2ldOwo+ICAJCXU2NCBtaW5fcGl0Y2ggPSBkcm1fZm9ybWF0X2luZm9f bWluX3BpdGNoKGluZm8sIGksIHdpZHRoKTsKPiAgCj4gKwkJaWYgKCFibG9ja19zaXplICYmIChy LT5tb2RpZmllcltpXSA9PSBEUk1fRk9STUFUX01PRF9MSU5FQVIpKSB7Cj4gKwkJCURSTV9ERUJV R19LTVMoIkZvcm1hdCByZXF1aXJlcyBub24tbGluZWFyIG1vZGlmaWVyIGZvciBwbGFuZSAlZFxu IiwgaSk7Cj4gKwkJCXJldHVybiAtRUlOVkFMOwo+ICsJCX0KPiArCj4gIAkJaWYgKCFyLT5oYW5k bGVzW2ldKSB7Cj4gIAkJCURSTV9ERUJVR19LTVMoIm5vIGJ1ZmZlciBvYmplY3QgaGFuZGxlIGZv ciBwbGFuZSAlZFxuIiwgaSk7Cj4gIAkJCXJldHVybiAtRUlOVkFMOwo+IEBAIC0yMDgsNyArMjE0 LDcgQEAgc3RhdGljIGludCBmcmFtZWJ1ZmZlcl9jaGVjayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+ICAJCWlmICgodWludDY0X3QpIGhlaWdodCAqIHItPnBpdGNoZXNbaV0gKyByLT5vZmZzZXRz W2ldID4gVUlOVF9NQVgpCj4gIAkJCXJldHVybiAtRVJBTkdFOwo+ICAKPiAtCQlpZiAoci0+cGl0 Y2hlc1tpXSA8IG1pbl9waXRjaCkgewo+ICsJCWlmIChibG9ja19zaXplICYmIHItPnBpdGNoZXNb aV0gPCBtaW5fcGl0Y2gpIHsKPiAgCQkJRFJNX0RFQlVHX0tNUygiYmFkIHBpdGNoICV1IGZvciBw bGFuZSAlZFxuIiwgci0+cGl0Y2hlc1tpXSwgaSk7Cj4gIAkJCXJldHVybiAtRUlOVkFMOwo+ICAJ CX0KPiAtLSAKPiAyLjE5LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK