From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Eric Blake" <eblake@redhat.com>,
qemu-ppc@nongnu.org, "Richard Henderson" <rth@twiddle.net>,
"Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>
Subject: [Qemu-devel] [PATCH 3/4] tag cirrus as obsolete
Date: Tue, 30 Oct 2018 12:13:47 +0100 [thread overview]
Message-ID: <20181030111348.14713-4-kraxel@redhat.com> (raw)
In-Reply-To: <20181030111348.14713-1-kraxel@redhat.com>
Standard VGA should be used instead.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/cirrus_vga.c | 3 +++
hw/display/cirrus_vga_isa.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
index d9b854d74d..ec2cefb46f 100644
--- a/hw/display/cirrus_vga.c
+++ b/hw/display/cirrus_vga.c
@@ -3024,6 +3024,9 @@ static void cirrus_vga_class_init(ObjectClass *klass, void *data)
dc->vmsd = &vmstate_pci_cirrus_vga;
dc->props = pci_vga_cirrus_properties;
dc->hotpluggable = false;
+ dc->supported.state = SUPPORT_STATE_OBSOLETE;
+ dc->supported.reason = "use \"-vga std\" instead, see "
+ "https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/";
}
static const TypeInfo cirrus_vga_info = {
diff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c
index fa10b74230..cfe2cad9e0 100644
--- a/hw/display/cirrus_vga_isa.c
+++ b/hw/display/cirrus_vga_isa.c
@@ -81,6 +81,9 @@ static void isa_cirrus_vga_class_init(ObjectClass *klass, void *data)
dc->realize = isa_cirrus_vga_realizefn;
dc->props = isa_cirrus_vga_properties;
set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
+ dc->supported.state = SUPPORT_STATE_OBSOLETE;
+ dc->supported.reason = "use \"-vga std\" instead, see "
+ "https://www.kraxel.org/blog/2014/10/qemu-using-cirrus-considered-harmful/";
}
static const TypeInfo isa_cirrus_vga_info = {
--
2.9.3
next prev parent reply other threads:[~2018-10-30 11:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 11:13 [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState Gerd Hoffmann
2018-10-30 11:13 ` [Qemu-devel] [PATCH 1/4] add QemuSupportState Gerd Hoffmann
2018-10-30 13:32 ` Philippe Mathieu-Daudé
2018-10-30 14:00 ` Gerd Hoffmann
2018-10-30 14:13 ` Philippe Mathieu-Daudé
2018-10-30 15:46 ` Cornelia Huck
2018-10-30 17:37 ` Philippe Mathieu-Daudé
2018-10-30 23:15 ` Eduardo Habkost
2018-10-31 9:22 ` Cornelia Huck
2018-11-05 7:30 ` Gerd Hoffmann
2018-11-05 13:49 ` Eduardo Habkost
2018-11-06 6:56 ` Gerd Hoffmann
2018-10-31 16:04 ` John Snow
2018-10-31 18:06 ` Eduardo Habkost
2018-10-31 18:37 ` John Snow
2018-10-31 18:58 ` Eduardo Habkost
2018-10-31 20:05 ` John Snow
2018-11-05 7:46 ` Gerd Hoffmann
2018-10-30 14:54 ` Eduardo Habkost
2018-10-30 15:02 ` Eduardo Habkost
2018-10-30 17:30 ` [Qemu-devel] [Qemu-ppc] " Murilo Opsfelder Araujo
2018-10-30 11:13 ` [Qemu-devel] [PATCH 2/4] add QemuSupportState to DeviceClass Gerd Hoffmann
2018-10-30 11:13 ` Gerd Hoffmann [this message]
2018-10-30 11:22 ` [Qemu-devel] [PATCH 3/4] tag cirrus as obsolete Paolo Bonzini
2018-10-30 11:13 ` [Qemu-devel] [PATCH 4/4] switch machine types to QemuSupportState Gerd Hoffmann
2018-10-30 11:22 ` [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState Paolo Bonzini
2018-10-30 14:34 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030111348.14713-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.