From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB921C2BC61 for ; Tue, 30 Oct 2018 13:26:02 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5C9420827 for ; Tue, 30 Oct 2018 13:26:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5C9420827 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42ksfw4JkkzF1Ph for ; Wed, 31 Oct 2018 00:26:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=newverein.lst.de; envelope-from=hch@lst.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42kscj2VmRzDqYd for ; Wed, 31 Oct 2018 00:24:05 +1100 (AEDT) Received: by newverein.lst.de (Postfix, from userid 2407) id 3A3CF68B02; Tue, 30 Oct 2018 14:24:02 +0100 (CET) Date: Tue, 30 Oct 2018 14:24:02 +0100 From: Christoph Hellwig To: Benjamin Herrenschmidt Subject: Re: [PATCH] powerpc/npu-dma: Remove NPU DMA ops Message-ID: <20181030132401.GC30783@lst.de> References: <20181030110203.27257-1-alistair@popple.id.au> <20181030125841.GB30158@lst.de> <30359cc433e97739d93e13717b2897e462895097.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30359cc433e97739d93e13717b2897e462895097.camel@kernel.crashing.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Popple , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Oct 31, 2018 at 12:09:29AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2018-10-30 at 13:58 +0100, Christoph Hellwig wrote: > > Please take my patch instead. We have a kernel polcity to not keep > > dead code around, and everyone including Linus and the attending IBMers > > confirmed this. > > Let's call a cat a cat ... ;-) > > It's not *dead* code. It's code that is used by an out of tree driver > (which also happen not to be open source). Which clearly makes it a derived work of the kernel if it uses an interface just create for it, and thus even more important to remove it to not get anyone into legal trouble. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7214C2BC61 for ; Tue, 30 Oct 2018 13:24:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A005220838 for ; Tue, 30 Oct 2018 13:24:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A005220838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727843AbeJ3WRa (ORCPT ); Tue, 30 Oct 2018 18:17:30 -0400 Received: from verein.lst.de ([213.95.11.211]:60245 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726985AbeJ3WR3 (ORCPT ); Tue, 30 Oct 2018 18:17:29 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 3A3CF68B02; Tue, 30 Oct 2018 14:24:02 +0100 (CET) Date: Tue, 30 Oct 2018 14:24:02 +0100 From: Christoph Hellwig To: Benjamin Herrenschmidt Cc: Christoph Hellwig , Alistair Popple , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, mpe@ellerman.id.au Subject: Re: [PATCH] powerpc/npu-dma: Remove NPU DMA ops Message-ID: <20181030132401.GC30783@lst.de> References: <20181030110203.27257-1-alistair@popple.id.au> <20181030125841.GB30158@lst.de> <30359cc433e97739d93e13717b2897e462895097.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30359cc433e97739d93e13717b2897e462895097.camel@kernel.crashing.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2018 at 12:09:29AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2018-10-30 at 13:58 +0100, Christoph Hellwig wrote: > > Please take my patch instead. We have a kernel polcity to not keep > > dead code around, and everyone including Linus and the attending IBMers > > confirmed this. > > Let's call a cat a cat ... ;-) > > It's not *dead* code. It's code that is used by an out of tree driver > (which also happen not to be open source). Which clearly makes it a derived work of the kernel if it uses an interface just create for it, and thus even more important to remove it to not get anyone into legal trouble.