From: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH v2] arm64: dts: rockchip: sapphire: add chosen node
Date: Tue, 30 Oct 2018 15:59:41 +0100 [thread overview]
Message-ID: <20181030145941.15975-1-vicencb@gmail.com> (raw)
In-Reply-To: <5408972.CYYHPefPr5@phil>
In order to use earlycon, the stdout-path property needs to be set in the chosen node.
---
Hi Heiko,
> shouldn't that maybe live in the shared .dtsi instead?
this v2 applies the change in the .dtsi as suggested.
> I do guess the excavator will have the same default serial?
Well, in fact it seems to me that serial2 is set as the default serial port
at the chip level, although there are some exceptions. But on the other hand
the baud rate is more free form.
So, as suggested, it could be a good compromise to put it at the
daugther-card level.
The point for working around the kexec bug is still valid, but with
the update from the maintainer it is not enough to fix everything:
http://lists.infradead.org/pipermail/kexec/2018-October/021762.html
Regards,
Vicenç.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
index 5421e2376..2eb6489d4 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
@@ -11,6 +11,10 @@
/ {
compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399";
+ chosen {
+ stdout-path = "serial2:1500000n8";
+ };
+
backlight: backlight {
compatible = "pwm-backlight";
brightness-levels = <
--
2.19.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2018-10-30 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 13:36 [PATCH] arm64: dts: rockchip: sapphire: add chosen node Vicente Bergas
[not found] ` <20181026133655.1605-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-10-30 14:09 ` Heiko Stuebner
2018-10-30 14:59 ` Vicente Bergas [this message]
[not found] ` <20181030145941.15975-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-10-30 20:34 ` [PATCH v2] " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030145941.15975-1-vicencb@gmail.com \
--to=vicencb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.