From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 6/6] drm/i915/icl: Fix crash when getting DPLL of a MST encoder in TC ports Date: Tue, 30 Oct 2018 19:56:24 +0200 Message-ID: <20181030175624.GC9144@intel.com> References: <20181010213508.3046-1-jose.souza@intel.com> <20181010213508.3046-6-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D29E26E0A1 for ; Tue, 30 Oct 2018 17:56:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181010213508.3046-6-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTAsIDIwMTggYXQgMDI6MzU6MDhQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBlbmNfdG9fZGlnX3BvcnQoKSByZXR1cm5zIE5VTEwgZm9yIGVuY29k ZXJzIG9mIHR5cGUKPiBJTlRFTF9PVVRQVVRfRFBfTVNUIGNhdXNpbmcgdGhlIGNyYXNoIGJlbGxv dzoKPiAKPiBbIDI4MzIuODM2MTAxXSBCVUc6IHVuYWJsZSB0byBoYW5kbGUga2VybmVsIHBhZ2lu ZyByZXF1ZXN0IGF0IDAwMDAwMDAwMDAwMDEyYjgKPiBbIDI4MzIuODQzMDYyXSBQR0QgMCBQNEQg MAo+IFsgMjgzMi44NDU2MTBdIE9vcHM6IDAwMDAgWyMxXSBTTVAKPiBbIDI4MzIuODQ4NzY0XSBD UFU6IDIgUElEOiAzNTc3IENvbW06IGt3b3JrZXIvMjowIFRhaW50ZWQ6IEcgICAgICAgIFcgICAg ICAgICA0LjE5LjAtcmM3KyAjNDkxCj4gWyAyODMyLjg1NzEwNl0gSGFyZHdhcmUgbmFtZTogSW50 ZWwgQ29ycG9yYXRpb24gSWNlIExha2UgQ2xpZW50IFBsYXRmb3JtL0ljZUxha2UgVSBERFI0IFNP RElNTSBQRCBSVlAgVExDLCBCSU9TIElDTFNGV1IxLlIwMC4yMzUyLkEwMS4xODA4MjgxODUyIDA4 LzI4LzIwMTgKPiBbIDI4MzIuODcwNzM0XSBXb3JrcXVldWU6IGV2ZW50cyBvdXRwdXRfcG9sbF9l eGVjdXRlCj4gWyAyODMyLjg3NTQ4MF0gUklQOiAwMDEwOmljbF9nZXRfZHBsbCsweGE0LzB4NWQw IFtpOTE1XQo+IFsgMjgzMi44ODA0NDldIENvZGU6IGU5IDAzIGYzIDQ4IGFiIDhiIDZlIDc0IDQx IDhiIDhjIDI0IDVjIDAzIDAwIDAwIDg1IGVkIDBmIDg4IDNmIDAyIDAwIDAwIDgzIGZkIDAxIDBm IDhlIGFkIDAxIDAwIDAwIDgzIGZkIDA1IDBmIDhmIDJkIDAyIDAwIDAwIDw4Mz4gYmEgYjggMTIg MDAgMDAgMDIgNDggOGIgMzYgMGYgODQgMzkgMDIgMDAgMDAgNDQgOGIgYmUgZWMgODkgMDAKPiBb IDI4MzIuODk5MTc2XSBSU1A6IDAwMTg6ZmZmZmM5MDAwMWI1N2E3OCBFRkxBR1M6IDAwMDEwMjkz Cj4gWyAyODMyLjkwNDQwNF0gUkFYOiAwMDAwMDAwMDAwMDAwMDAwIFJCWDogZmZmZmM5MDAwMWI1 N2E5NCBSQ1g6IDAwMDAwMDAwMDAwODNkNjAKPiBbIDI4MzIuOTExNTM2XSBSRFg6IDAwMDAwMDAw MDAwMDAwMDAgUlNJOiBmZmZmODgwNGE4YzBkYzAwIFJESTogZmZmZmM5MDAwMWI1N2IxOAo+IFsg MjgzMi45MTg2NjhdIFJCUDogMDAwMDAwMDAwMDAwMDAwMyBSMDg6IGZmZmY4ODA0YThjMWY5OTAg UjA5OiBmZmZmODgwNGE4YzFmOTkwCj4gWyAyODMyLjkyNTc5N10gUjEwOiAwMDAwMDAwMDAwMDAw MDAwIFIxMTogZmZmZjg4MDRhOGU5OTYwMCBSMTI6IGZmZmY4ODA0YTc3NjAwMDAKPiBbIDI4MzIu OTMyOTMwXSBSMTM6IGZmZmY4ODA0OWU5NGQwMDAgUjE0OiBmZmZmODgwNDllOTRkMDAwIFIxNTog MDAwMDAwMDAwMDAwMDAwZQo+IFsgMjgzMi45NDAwNjNdIEZTOiAgMDAwMDAwMDAwMDAwMDAwMCgw MDAwKSBHUzpmZmZmODgwNGIwMzAwMDAwKDAwMDApIGtubEdTOjAwMDAwMDAwMDAwMDAwMDAKPiBb IDI4MzIuOTQ4MTQ3XSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgw MDUwMDMzCj4gWyAyODMyLjk1Mzg5M10gQ1IyOiAwMDAwMDAwMDAwMDAxMmI4IENSMzogMDAwMDAw MDAwNGExZDAwNCBDUjQ6IDAwMDAwMDAwMDA3NjBlZTAKPiBbIDI4MzIuOTYxMDI3XSBEUjA6IDAw MDAwMDAwMDAwMDAwMDAgRFIxOiAwMDAwMDAwMDAwMDAwMDAwIERSMjogMDAwMDAwMDAwMDAwMDAw MAo+IFsgMjgzMi45NjgxNTVdIERSMzogMDAwMDAwMDAwMDAwMDAwMCBEUjY6IDAwMDAwMDAwZmZm ZTBmZjAgRFI3OiAwMDAwMDAwMDAwMDAwNDAwCj4gWyAyODMyLjk3NTI4Nl0gUEtSVTogNTU1NTU1 NTQKPiBbIDI4MzIuOTc4MDAzXSBDYWxsIFRyYWNlOgo+IFsgMjgzMi45ODA0OTZdICBoYXN3ZWxs X2NydGNfY29tcHV0ZV9jbG9jaysweDNkLzB4NjggW2k5MTVdCj4gWyAyODMyLjk4NTg0MV0gIGlu dGVsX2NydGNfYXRvbWljX2NoZWNrKzB4NjEvMHgzNDAgW2k5MTVdCj4gWyAyODMyLjk5MDk4N10g IGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lcysweDEzMC8weDFjMAo+IFsgMjgzMi45OTYy NDVdICBpbnRlbF9hdG9taWNfY2hlY2srMHg0ZDUvMHgxMGYwIFtpOTE1XQo+IFsgMjgzMy4wMDEx NDddICBkcm1fYXRvbWljX2NoZWNrX29ubHkrMHg0ODQvMHg2OTAKPiBbIDI4MzMuMDA1NjI5XSAg ZHJtX2F0b21pY19jb21taXQrMHgxMy8weDUwCj4gWyAyODMzLjAwOTU2NF0gIHJlc3RvcmVfZmJk ZXZfbW9kZV9hdG9taWMrMHgxYzkvMHgxZTAKPiBbIDI4MzMuMDE0MzYzXSAgZHJtX2ZiX2hlbHBl cl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQrMHg0Ny8weDkwCj4gWyAyODMzLjAyMDM2OF0g IGRybV9mYl9oZWxwZXJfc2V0X3BhcisweDI5LzB4NTAKPiBbIDI4MzMuMDI0NjQxXSAgZHJtX2Zi X2hlbHBlcl9ob3RwbHVnX2V2ZW50LnBhcnQuMzMrMHg5Mi8weGIwCj4gWyAyODMzLjAzMDEzMF0g IGRybV9rbXNfaGVscGVyX2hvdHBsdWdfZXZlbnQrMHgyNi8weDMwCj4gWyAyODMzLjAzNTAxM10g IG91dHB1dF9wb2xsX2V4ZWN1dGUrMHgxOTIvMHgxYjAKPiBbIDI4MzMuMDM5MjkzXSAgcHJvY2Vz c19vbmVfd29yaysweDJhNS8weDVmMAo+IFsgMjgzMy4wNDMzMTVdICB3b3JrZXJfdGhyZWFkKzB4 MmQvMHgzZDAKPiBbIDI4MzMuMDQ2OTg4XSAgPyByZXNjdWVyX3RocmVhZCsweDM0MC8weDM0MAo+ IFsgMjgzMy4wNTEwMDldICBrdGhyZWFkKzB4MTEyLzB4MTMwCj4gWyAyODMzLjA1NDI0N10gID8g a3RocmVhZF9jcmVhdGVfd29ya2VyX29uX2NwdSsweDcwLzB4NzAKPiBbIDI4MzMuMDU5MzA3XSAg cmV0X2Zyb21fZm9yaysweDNhLzB4NTAKPiBbIDI4MzMuMDYyODkzXSBNb2R1bGVzIGxpbmtlZCBp bjogaTkxNSBwcmltZV9udW1iZXJzIHNuZF9oZGFfY29kZWNfcmVhbHRlayBzbmRfaGRhX2NvZGVj X2dlbmVyaWMgYXNpeCBzbmRfdXNiX2F1ZGlvIHNuZF91c2JtaWRpX2xpYiBzbmRfc2VxX21pZGkg c25kX3NlcV9taWRpX2V2ZW50IHNuZF9yYXdtaWRpIGNkY19ldGhlciB1c2JuZXQgeDg2X3BrZ190 ZW1wX3RoZXJtYWwgeGhjaV9wY2kgeGhjaV9oY2QgdWNzaV9hY3BpIHR5cGVjX3Vjc2kgdHlwZWMg ZWZpdmFyZnMgW2xhc3QgdW5sb2FkZWQ6IHByaW1lX251bWJlcnNdCj4gWyAyODMzLjA4ODkxN10g Q1IyOiAwMDAwMDAwMDAwMDAxMmI4Cj4gWyAyODMzLjA5MjI0MV0gLS0tWyBlbmQgdHJhY2UgMjVm OWZlM2Q0N2FmMmU3NSBdLS0tCj4gWyAyODMzLjA5Njg5NV0gUklQOiAwMDEwOmljbF9nZXRfZHBs bCsweGE0LzB4NWQwIFtpOTE1XQo+IFsgMjgzMy4xMDE4NjZdIENvZGU6IGU5IDAzIGYzIDQ4IGFi IDhiIDZlIDc0IDQxIDhiIDhjIDI0IDVjIDAzIDAwIDAwIDg1IGVkIDBmIDg4IDNmIDAyIDAwIDAw IDgzIGZkIDAxIDBmIDhlIGFkIDAxIDAwIDAwIDgzIGZkIDA1IDBmIDhmIDJkIDAyIDAwIDAwIDw4 Mz4gYmEgYjggMTIgMDAgMDAgMDIgNDggOGIgMzYgMGYgODQgMzkgMDIgMDAgMDAgNDQgOGIgYmUg ZWMgODkgMDAKPiBbIDI4MzMuMTIwNTg5XSBSU1A6IDAwMTg6ZmZmZmM5MDAwMWI1N2E3OCBFRkxB R1M6IDAwMDEwMjkzCj4gWyAyODMzLjEyNTgxNV0gUkFYOiAwMDAwMDAwMDAwMDAwMDAwIFJCWDog ZmZmZmM5MDAwMWI1N2E5NCBSQ1g6IDAwMDAwMDAwMDAwODNkNjAKPiBbIDI4MzMuMTMyOTQ2XSBS RFg6IDAwMDAwMDAwMDAwMDAwMDAgUlNJOiBmZmZmODgwNGE4YzBkYzAwIFJESTogZmZmZmM5MDAw MWI1N2IxOAo+IFsgMjgzMy4xNDAwODBdIFJCUDogMDAwMDAwMDAwMDAwMDAwMyBSMDg6IGZmZmY4 ODA0YThjMWY5OTAgUjA5OiBmZmZmODgwNGE4YzFmOTkwCj4gWyAyODMzLjE0NzIxM10gUjEwOiAw MDAwMDAwMDAwMDAwMDAwIFIxMTogZmZmZjg4MDRhOGU5OTYwMCBSMTI6IGZmZmY4ODA0YTc3NjAw MDAKPiBbIDI4MzMuMTU0MzUwXSBSMTM6IGZmZmY4ODA0OWU5NGQwMDAgUjE0OiBmZmZmODgwNDll OTRkMDAwIFIxNTogMDAwMDAwMDAwMDAwMDAwZQo+IFsgMjgzMy4xNjE0ODNdIEZTOiAgMDAwMDAw MDAwMDAwMDAwMCgwMDAwKSBHUzpmZmZmODgwNGIwMzAwMDAwKDAwMDApIGtubEdTOjAwMDAwMDAw MDAwMDAwMDAKPiBbIDI4MzMuMTY5NTY1XSBDUzogIDAwMTAgRFM6IDAwMDAgRVM6IDAwMDAgQ1Iw OiAwMDAwMDAwMDgwMDUwMDMzCj4gWyAyODMzLjE3NTMxM10gQ1IyOiAwMDAwMDAwMDAwMDAxMmI4 IENSMzogMDAwMDAwMDAwNGExZDAwNCBDUjQ6IDAwMDAwMDAwMDA3NjBlZTAKPiBbIDI4MzMuMTgy NDQ5XSBEUjA6IDAwMDAwMDAwMDAwMDAwMDAgRFIxOiAwMDAwMDAwMDAwMDAwMDAwIERSMjogMDAw MDAwMDAwMDAwMDAwMAo+IFsgMjgzMy4xODk1NzhdIERSMzogMDAwMDAwMDAwMDAwMDAwMCBEUjY6 IDAwMDAwMDAwZmZmZTBmZjAgRFI3OiAwMDAwMDAwMDAwMDAwNDAwCj4gWyAyODMzLjE5NjcxMl0g UEtSVTogNTU1NTU1NTQKPiAKPiBNU1QgcG9ydHMgYXJlIGFsbG9jYXRlZCBmcm9tIHN0cnVjdCBp bnRlbF9kcF9tc3RfZW5jb2RlciBub3QgZnJvbQo+IHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQg YXMgcmVndWxhciBwb3J0cywgc28gdG8gZ2V0IHRoZSBUQyB0eXBlIGl0Cj4gaXMgbmVjZXNzYXJ5 IGNoZWNrIHRoZSBwcmltYXJ5IGRpZ2l0YWwgcG9ydCBvZiB0aGUgbXN0IGVuY29kZXIuCj4gCj4g Q2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIHwgMTIgKysrKysrKysrKy0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+IGluZGV4IDg3NDY0NjM1N2FkMS4u MjNhMWJjMTdhM2Y5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw bGxfbWdyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4g QEAgLTI4NjcsOCArMjg2Nyw3IEBAIHN0YXRpYyBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKgo+ ICBpY2xfZ2V0X2RwbGwoc3RydWN0IGludGVsX2NydGMgKmNydGMsIHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJICAgICBzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl cikKPiAgewo+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPQo+ IC0JCQllbmNfdG9fZGlnX3BvcnQoJmVuY29kZXItPmJhc2UpOwo+ICsJc3RydWN0IGludGVsX2Rp Z2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQ7Cj4gIAlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwg KnBsbDsKPiAgCXN0cnVjdCBpbnRlbF9kcGxsX2h3X3N0YXRlIHBsbF9zdGF0ZSA9IHt9Owo+ICAJ ZW51bSBwb3J0IHBvcnQgPSBlbmNvZGVyLT5wb3J0Owo+IEBAIC0yODg4LDYgKzI4ODcsMTUgQEAg aWNsX2dldF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCWNhc2UgUE9SVF9EOgo+ICAJY2FzZSBQT1JUX0U6Cj4gIAlj YXNlIFBPUlRfRjoKPiArCQlpZiAoZW5jb2Rlci0+dHlwZSA9PSBJTlRFTF9PVVRQVVRfRFBfTVNU KSB7Cj4gKwkJCXN0cnVjdCBpbnRlbF9kcF9tc3RfZW5jb2RlciAqbXN0X2VuY29kZXI7Cj4gKwo+ ICsJCQltc3RfZW5jb2RlciA9IGVuY190b19tc3QoJmVuY29kZXItPmJhc2UpOwo+ICsJCQlpbnRl bF9kaWdfcG9ydCA9IG1zdF9lbmNvZGVyLT5wcmltYXJ5Owo+ICsJCX0gZWxzZSB7Cj4gKwkJCWlu dGVsX2RpZ19wb3J0ID0gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVyLT5iYXNlKTsKPiArCQl9CgpB cmdoLiBJIHRob3VnaHQgd2UgaGFkIGZpbmFsbHkgZ290IHJpZCBvZiBhbGwgdGhpcy4gSSBndWVz cyB0aGlzIHNob3VsZApnZXQgZml4ZWQgaW4gYSBuaWNlciB3YXkgaWYgd2Ugc3RhcnQgdG8gdHJh Y2sgdGhlIHRjX3R5cGUgKG9yIHNvbWV0aGluZwpsaWtlIGl0KSBpbiB0aGUgY3J0Y19zdGF0ZS4K CkluIHRoZSBtZWFudGltZQpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KCj4gKwo+ICAJCWlmIChpbnRlbF9kaWdfcG9ydC0+dGNfdHlw ZSA9PSBUQ19QT1JUX1RCVCkgewo+ICAJCQltaW4gPSBEUExMX0lEX0lDTF9UQlRQTEw7Cj4gIAkJ CW1heCA9IG1pbjsKPiAtLSAKPiAyLjE5LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==