Re: [PATCH 4/5] drm/i915: Kill WA 0528

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Oct 29, 2018 at 04:00:43PM -0700, Rodrigo Vivi wrote:
> First of all I believe this WA as written here was wrong.
> 
> Because it is listed on BSpec only for SKL and BXT, exactly
> the only 2 platforms skipped here.
> 
> But also it is written there that we don't need this WA
> anymore:
> "This workaround is no longer needed since NV12 support is
> dropped for the affected projects in #0870."

Ahd here is the missing skl_wa_528() :)

The w/a still seems to say it would be need with ccs. But
the w/a is only listed for pre-production steppins so I guess
it can go (I didn't find any counter argument in the spec).

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> SO, let's kill it.
> 
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Vidya Srinivas <vidya.srinivas@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 14f6f66b00d2..aacc340d4eec 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -455,18 +455,6 @@ static const struct intel_limit intel_limits_bxt = {
>  	.p2 = { .p2_slow = 1, .p2_fast = 20 },
>  };
>  
> -static void
> -skl_wa_528(struct drm_i915_private *dev_priv, int pipe, bool enable)
> -{
> -	if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
> -		return;
> -
> -	if (enable)
> -		I915_WRITE(CHICKEN_PIPESL_1(pipe), HSW_FBCQ_DIS);
> -	else
> -		I915_WRITE(CHICKEN_PIPESL_1(pipe), 0);
> -}
> -
>  static void
>  skl_wa_clkgate(struct drm_i915_private *dev_priv, int pipe, bool enable)
>  {
> @@ -5286,7 +5274,6 @@ static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state)
>  	if (needs_nv12_wa(dev_priv, old_crtc_state) &&
>  	    !needs_nv12_wa(dev_priv, pipe_config)) {
>  		skl_wa_clkgate(dev_priv, crtc->pipe, false);
> -		skl_wa_528(dev_priv, crtc->pipe, false);
>  	}
>  }
>  
> @@ -5326,7 +5313,6 @@ static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state,
>  	if (!needs_nv12_wa(dev_priv, old_crtc_state) &&
>  	    needs_nv12_wa(dev_priv, pipe_config)) {
>  		skl_wa_clkgate(dev_priv, crtc->pipe, true);
> -		skl_wa_528(dev_priv, crtc->pipe, true);
>  	}
>  
>  	/*
> -- 
> 2.19.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx