From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [v3 4/7] i915/dp/fec: Add can_fec to the crtc state. Date: Tue, 30 Oct 2018 21:38:54 +0200 Message-ID: <20181030193854.GI9144@intel.com> References: <20181026044943.29334-1-anusha.srivatsa@intel.com> <20181026044943.29334-5-anusha.srivatsa@intel.com> <20181030185712.GH9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3465A89F3C for ; Tue, 30 Oct 2018 19:38:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181030185712.GH9144@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anusha Srivatsa Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMzAsIDIwMTggYXQgMDg6NTc6MTJQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgT2N0IDI1LCAyMDE4IGF0IDA5OjQ5OjQwUE0gLTA3MDAsIEFudXNo YSBTcml2YXRzYSB3cm90ZToKPiA+IEFkZCBhIGNydGMgc3RhdGUgZm9yIEZFQy4gQ3VycmVudGx5 LCB0aGUgc3RhdGUKPiA+IGlzIGRldGVybWluZWQgYnkgcGxhdGZvcm0sIERQIGFuZCBEU0MgYmVp bmcKPiA+IGVuYWJsZWQuIE1vdmluZyBmb3J3YXJkIHdlIGNhbiB1c2UgdGhlIHN0YXRlCj4gPiB0 byBoYXZlIGVycm9yIGNvcnJlY3Rpb24gb24gb3RoZXIgc2NlbmFyaW9zIHRvbwo+ID4gaWYgbmVl ZGVkLgo+ID4gCj4gPiBTdWdnZXN0ZWQtYnk6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+ID4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51eC5pbnRl bC5jb20+Cj4gPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4K PiA+IFNpZ25lZC1vZmYtYnk6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNyaXZhdHNhQGludGVs LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgIHwgMjIg KysrKysrKysrKysrKysrKysrKysrKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oIHwgIDMgKysrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspCj4gPiAK PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gaW5kZXggY2ZjZWY5ZTRiNWQ5Li40Nzc2Y2U2 ZjIxNzQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBAQCAtMjA0NSw2ICsy MDQ1LDIzIEBAIGludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWdfZmFzdChzdHJ1Y3QgaW50ZWxf ZHAgKmludGVsX2RwLAo+ID4gIAlyZXR1cm4gZmFsc2U7Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRp YyBib29sIGludGVsX2RwX2Nhbl9mZWMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiA+ICsJ CQkgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiA+ICt7Cj4gPiAr CXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50 ZWxfZHApOwo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1 KGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiA+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg PCAxMSB8fCBpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKQo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ IAo+IFdlIGRvbid0IG5lZWQgRkVDIGZvciBlRFAgRFNDPwoKVGhpcyBzdHVmZiBtYXliZSBuZWVk cyBhbm90aGVyIHNpbmsgdnMuIHNvdXJjZSBzcGxpdCBhbmQgd2hhdG5vdC4KCk1heWJlIGFsb25n IHRoZXNlIGxpbmVzOgoKc291cmNlX3N1cHBvcnRlc19mZWMoKQp7CglyZXR1cm4gR0VOID49IDEx ICYmIHBvcnQgIT0gUE9SVF9BOwp9CgpzaW5rX3N1cHBvcnRzX2ZlYygpCnsKCXJldHVybiB3aGF0 ZXZlcjsKfQoKc3VwcG9ydHNfZmVjKCkKewoJcmV0dXJuIHNvdXJjZV9zdXBwb3J0c19mZWMoKSAm JgoJCXNpbmtfc3VwcG9ydHNfZmVjKCk7Cn0KCmNvbXB1dGVfZHNjKCkKewoJLyogZURQIERTQyBk b2VzIG5vdCBuZWVkIEZFQyAqLwoJZmVjX2VuYWJsZSA9ICFpc19lZHAoKTsKCglpZiAoZmVjX2Vu YWJsZSAmJiAhc3VwcG9ydHNfZmVjKCkpCgkJcmV0dXJuIGZhbHNlOwoKCWlmICghc3VwcG9ydHNf ZHNjKCkpCgkJcmV0dXJuIGZhbHNlOwoKCS4uLgp9CgoKPiAKPiA+ICsKPiA+ICsJLyogT24gR2Vu IDExLCBGRUMgaXMgU3VwcG9ydGVkIE9ubHkgZm9yIERQIFNTVCBtb2Rlcy4KPiA+ICsJICogTGV0 IHVzIHN0YXJ0IGJ5IGVuYWJsaW5nIEZFQyBmb3IgQ29tcHJlc3NlZCBzdHJlYW1zLgo+ID4gKwkg Ki8KPiA+ICsJaWYgKHBpcGVfY29uZmlnLT5kc2NfcGFyYW1zLmNvbXByZXNzaW9uX2VuYWJsZSkK PiA+ICsJCXJldHVybiB0cnVlOwo+ID4gKwllbHNlCj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiAr Cj4gPiArfQo+ID4gIHN0YXRpYyBib29sIGludGVsX2RwX2RzY19jb21wdXRlX2NvbmZpZyhzdHJ1 Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ID4gIAkJCQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUg KnBpcGVfY29uZmlnLAo+ID4gIAkJCQkJc3RydWN0IGxpbmtfY29uZmlnX2xpbWl0cyAqbGltaXRz KQo+ID4gQEAgLTIxMjksNiArMjE0NiwxMSBAQCBzdGF0aWMgYm9vbCBpbnRlbF9kcF9kc2NfY29t cHV0ZV9jb25maWcoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiA+ICAJCSAgICAgIHBpcGVf Y29uZmlnLT5kc2NfcGFyYW1zLmNvbXByZXNzZWRfYnBwLAo+ID4gIAkJICAgICAgcGlwZV9jb25m aWctPmRzY19wYXJhbXMuc2xpY2VfY291bnQpOwo+ID4gIAo+ID4gKwkvKiBGb3IgRFAgMS40LCBF bmFibGUgRFNDIGlmIEZFQyBjYW4gYmUgY29uZmlndXJlZCAqLwo+ID4gKwlwaXBlX2NvbmZpZy0+ Y2FuX2ZlYyA9IGludGVsX2RwX2Nhbl9mZWMoaW50ZWxfZHAsIHBpcGVfY29uZmlnKTsKPiA+ICsJ aWYgKCFwaXBlX2NvbmZpZy0+Y2FuX2ZlYykKPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ICsKPiA+ ICAJcmV0dXJuIHRydWU7Cj4gPiAgfQo+ID4gIAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgK PiA+IGluZGV4IDlhOTRjNjU0NGJmNS4uOWRhYzI0MmVhZDEyIDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oCj4gPiBAQCAtOTQwLDYgKzk0MCw5IEBAIHN0cnVjdCBpbnRlbF9jcnRj X3N0YXRlIHsKPiA+ICAJCXU4IHNsaWNlX2NvdW50Owo+ID4gIAl9IGRzY19wYXJhbXM7Cj4gPiAg CXN0cnVjdCBkcm1fZHNjX2NvbmZpZyBkcF9kc2NfY2ZnOwo+ID4gKwo+ID4gKwkvKiBGb3J3YXJk IEVycm9yIGNvcnJlY3Rpb24gU3RhdGUgKi8KPiA+ICsJYm9vbCBjYW5fZmVjOwo+IAo+ICdmZWNf ZW5hYmxlJyBpcyB3aGF0IEknZCBjYWxsIHRoaXMuCj4gCj4gV2UncmUgcmF0aGVyIGluY29uc2lz dGVudCB3aXRoICBmb29fZW5hYmxlIHZzLiBmb29fZW5hYmxlZCB2cy4KPiBlbmFibGVfZm9vLCBi dXQgb25lIGhhcyB0byBwaWNrIHNvbWV0aGluZy4KPiAKPiA+ICB9Owo+ID4gIAo+ID4gIHN0cnVj dCBpbnRlbF9jcnRjIHsKPiA+IC0tIAo+ID4gMi4xNy4xCj4gCj4gLS0gCj4gVmlsbGUgU3lyasOk bMOkCj4gSW50ZWwKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==