From: paulmck@linux.ibm.com (Paul E. McKenney)
To: cocci@systeme.lip6.fr
Subject: [Cocci] sending out trewide patches
Date: Tue, 30 Oct 2018 13:35:33 -0700 [thread overview]
Message-ID: <20181030203533.GT4170@linux.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1810302108310.2949@hadrien>
On Tue, Oct 30, 2018 at 09:09:27PM +0100, Julia Lawall wrote:
>
>
> On Tue, 30 Oct 2018, Paul E. McKenney wrote:
>
> > On Tue, Oct 30, 2018 at 08:56:01PM +0100, Julia Lawall wrote:
> > >
> > >
> > > On Tue, 30 Oct 2018, Paul E. McKenney wrote:
> > >
> > > > On Sat, Oct 27, 2018 at 08:08:33PM +0200, Julia Lawall wrote:
> > > > >
> > > > >
> > > > > On Sat, 27 Oct 2018, Paul E. McKenney wrote:
> > > > >
> > > > > > On Sat, Oct 27, 2018 at 08:38:02AM +0200, Julia Lawall wrote:
> > > > > > > Hello,
> > > > > > >
> > > > > > > At OSS Europe, I got some questions about how to send out large
> > > > > > > Coccinelle-generated patches. Coccinelle provides a tool tools/splitpatch
> > > > > > > (go to the tools subdirectory of the Coccinelle distribution and run make)
> > > > > > > that splits patches by set of maintainers (the default), by directory
> > > > > > > (--dirmerge option), or by file (--nomerge option). There is a file
> > > > > > > tools/splitpatch.README that explains the various ways that it can be
> > > > > > > used, but the simplest is to create a patch normally using
> > > > > > > git format-patch -s, obtaining eg 0001-changes.patch, and then run
> > > > > > >
> > > > > > > splitpatch 0001-changes.patch
> > > > > > >
> > > > > > > The output will include a 0001-changes.cover file, a set of
> > > > > > > 0001-changesN.patch files with the various split patches, and a
> > > > > > > 0001-changes.cmd file for sending it off with git send-email.
> > > > > > >
> > > > > > > This is available in the latest github version of Coccinelle. Comments
> > > > > > > are welcome.
> > > > > >
> > > > > > Thank you, Julia! I will give it a try.
> > > >
> > > > Does the following error message mean that I need a more up-to-date
> > > > version of ocaml or some such?
> > > >
> > > > Thanx, Paul
> > > >
> > > > File "globals/config.ml", line 1:
> > > > Error: The implementation globals/config.ml
> > > > does not match the interface globals/config.cmi:
> > > > The field `python_interpreter' is required but not provided
> > > > The field `ocaml_version' is required but not provided
> > > > The field `configure_flags' is required but not provided
> > > > The field `get_temp_dir_name' is required but not provided
> > > > make: *** [globals/config.cmo] Error 2
> > >
> > > I'm not familiar with that. I assume you started with the github version
> > > of Coccinelle. Then ./autogen and ./configure. Then make. A recent
> > > version of OCaml would indeed be good. Maybe running make distclean
> > > before ./autogen would be good. The inconsistencies suggest that you have
> > > some old compiled code hanging around. The build infrastructure has
> > > changed a lot recently, so it might not be managing code that predates the
> > > changes in a way that you would expect.
> >
> > Good point, that does work much better. Now -this- error message
> > seems to be me having an old ocaml:
> >
> > ocamlfind ocamlopt -c -no-alias-deps stdcompat__weak.mli -o stdcompat__weak.cmi
> > ocamlopt: unknown option `-no-alias-deps'.
> >
> > Will get a new one and see how it goes... ;-)
>
> What version do you have? I thought that the makefile would detect
> unsupported versions, so perhaps that check needs to be improved.
I am running 4.0.3 and now installing 4.0.5.
Thanx, Paul
next prev parent reply other threads:[~2018-10-30 20:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 6:38 [Cocci] sending out trewide patches Julia Lawall
2018-10-27 17:14 ` Paul E. McKenney
2018-10-27 18:08 ` Julia Lawall
2018-10-30 19:45 ` Paul E. McKenney
2018-10-30 19:56 ` Julia Lawall
2018-10-30 20:04 ` Paul E. McKenney
2018-10-30 20:09 ` Julia Lawall
2018-10-30 20:35 ` Paul E. McKenney [this message]
2018-10-30 20:54 ` Paul E. McKenney
2018-10-30 21:11 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030203533.GT4170@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.