From: Stephen Hemminger <stephen@networkplumber.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: "Yoann P." <yoann.p.public@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute] ss: Actually print left delimiter for columns
Date: Wed, 31 Oct 2018 08:31:22 -0700 [thread overview]
Message-ID: <20181031083122.24221435@xeon-e3> (raw)
In-Reply-To: <c116373229190175845bc3c45b944a741b09129d.1540850171.git.sbrivio@redhat.com>
On Mon, 29 Oct 2018 23:04:25 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:
> While rendering columns, we use a local variable to keep track of the
> field currently being printed, without touching current_field, which is
> used for buffering.
>
> Use the right pointer to access the left delimiter for the current column,
> instead of always printing the left delimiter for the last buffered field,
> which is usually an empty string.
>
> This fixes an issue especially visible on narrow terminals, where some
> columns might be displayed without separation.
>
> Reported-by: YoyPa <yoann.p.public@gmail.com>
> Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> Tested-by: YoyPa <yoann.p.public@gmail.com>
Looks good, applied.
next prev parent reply other threads:[~2018-11-01 0:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 22:04 [PATCH iproute] ss: Actually print left delimiter for columns Stefano Brivio
2018-10-31 15:31 ` Stephen Hemminger [this message]
2018-11-09 17:05 ` Stephen Hemminger
2018-11-09 19:47 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031083122.24221435@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=yoann.p.public@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.