From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Jeff Cody <jcody@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 4/4] gitmodules: use 'https://' instead of 'git://'
Date: Wed, 31 Oct 2018 10:01:18 +0000 [thread overview]
Message-ID: <20181031100034.GE9625@redhat.com> (raw)
In-Reply-To: <20181031084309.9227-5-stefanha@redhat.com>
On Wed, Oct 31, 2018 at 08:43:09AM +0000, Stefan Hajnoczi wrote:
> When you clone the repository without previous commit history, 'git://'
> doesn't protect from man-in-the-middle attacks. HTTPS is more secure
> since the client verifies the server certificate.
>
> Also change git.qemu-project.org to git.qemu.org (we control both domain
> names but qemu.org is used more widely).
>
> Reported-by: Jann Horn <jannh@google.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> .gitmodules | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2018-10-31 10:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 8:43 [Qemu-devel] [PATCH 0/4] Use 'https://' instead of 'git://' Stefan Hajnoczi
2018-10-31 8:43 ` [Qemu-devel] [PATCH 1/4] README: use " Stefan Hajnoczi
2018-10-31 9:51 ` Daniel P. Berrangé
2018-10-31 8:43 ` [Qemu-devel] [PATCH 2/4] get_maintainer: " Stefan Hajnoczi
2018-10-31 9:52 ` Daniel P. Berrangé
2018-10-31 8:43 ` [Qemu-devel] [PATCH 3/4] MAINTAINERS: use 'https://' instead of 'git://' for GitHub Stefan Hajnoczi
2018-10-31 9:57 ` Daniel P. Berrangé
2018-10-31 10:05 ` Cornelia Huck
2018-10-31 13:31 ` Eric Blake
2018-11-02 12:36 ` Stefan Hajnoczi
2018-10-31 8:43 ` [Qemu-devel] [PATCH 4/4] gitmodules: use 'https://' instead of 'git://' Stefan Hajnoczi
2018-10-31 10:01 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031100034.GE9625@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.