All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static
Date: Wed, 31 Oct 2018 13:52:54 +0100	[thread overview]
Message-ID: <20181031135254.742f0947@bbrezillon> (raw)
In-Reply-To: <20181031113720.18181-1-sr@denx.de>

On Wed, 31 Oct 2018 12:37:20 +0100
Stefan Roese <sr@denx.de> wrote:

> Its only called from this file, so make it static. While at it, remove
> some occurances of multiple blank lines as well.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>

Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>

> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---
>  cmd/ubi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/cmd/ubi.c b/cmd/ubi.c
> index 2b74a98144..a12ac703eb 100644
> --- a/cmd/ubi.c
> +++ b/cmd/ubi.c
> @@ -101,7 +101,6 @@ static int ubi_check(char *name)
>  	return 1;
>  }
>  
> -
>  static int verify_mkvol_req(const struct ubi_device *ubi,
>  			    const struct ubi_mkvol_req *req)
>  {
> @@ -415,7 +414,7 @@ static int ubi_dev_scan(struct mtd_info *info, const char *vid_header_offset)
>  	return 0;
>  }
>  
> -int ubi_detach(void)
> +static int ubi_detach(void)
>  {
>  #ifdef CONFIG_CMD_UBIFS
>  	/*
> @@ -473,7 +472,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  	if (argc < 2)
>  		return CMD_RET_USAGE;
>  
> -
>  	if (strcmp(argv[1], "detach") == 0) {
>  		if (argc < 2)
>  			return CMD_RET_USAGE;
> @@ -481,7 +479,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  		return ubi_detach();
>  	}
>  
> -
>  	if (strcmp(argv[1], "part") == 0) {
>  		const char *vid_header_offset = NULL;
>  

  parent reply	other threads:[~2018-10-31 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 11:37 [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static Stefan Roese
2018-10-31 12:32 ` Miquel Raynal
2018-10-31 12:52 ` Boris Brezillon [this message]
2018-11-22  6:11 ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031135254.742f0947@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.