Re: [Outreachy kernel] [PATCH 2/2] staging: rtlwifi: Keep expressions on one line

[Maya Nakamura <m.maya.nakamura@gmail.com>]

On Wed, Oct 31, 2018 at 03:39:40PM +0100, Julia Lawall wrote:
> 
> 
> On Wed, 31 Oct 2018, Maya Nakamura wrote:
> 
> > Edit two statements to keep expressions on one line--one from Julia's
> > feedback.
> >
> > Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> > ---
> >  drivers/staging/rtlwifi/phydm/phydm_debug.c    | 4 +---
> >  drivers/staging/rtlwifi/phydm/phydm_hwconfig.c | 4 ++--
> >  2 files changed, 3 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/rtlwifi/phydm/phydm_debug.c b/drivers/staging/rtlwifi/phydm/phydm_debug.c
> > index 1c7faa5840f2..91f2c054d83b 100644
> > --- a/drivers/staging/rtlwifi/phydm/phydm_debug.c
> > +++ b/drivers/staging/rtlwifi/phydm/phydm_debug.c
> > @@ -159,9 +159,7 @@ void phydm_init_debug_setting(struct phy_dm_struct *dm)
> >  	dm->debug_level = ODM_DBG_TRACE;
> >
> >  	dm->fw_debug_components = 0;
> > -	dm->debug_components =
> > -
> > -		0;
> > +	dm->debug_components = 0;
> >
> >  	dm->fw_buff_is_enpty = true;
> >  	dm->pre_c2h_seq = 0;
> > diff --git a/drivers/staging/rtlwifi/phydm/phydm_hwconfig.c b/drivers/staging/rtlwifi/phydm/phydm_hwconfig.c
> > index e7dcb5b02ad4..2f4f273a0239 100644
> > --- a/drivers/staging/rtlwifi/phydm/phydm_hwconfig.c
> > +++ b/drivers/staging/rtlwifi/phydm/phydm_hwconfig.c
> > @@ -45,8 +45,8 @@ static u32 phydm_process_rssi_pwdb(struct phy_dm_struct *dm,
> >  	u32 weighting = 0, undecorated_smoothed_pwdb;
> >  	/* 2011.07.28 LukeLee: modified to prevent unstable CCK RSSI */
> >
> > -	if (entry->rssi_stat.ofdm_pkt ==
> > -	    64) { /* speed up when all packets are OFDM*/
> > +	if (entry->rssi_stat.ofdm_pkt == 64) {
> > +		/* speed up when all packets are OFDM*/
> 
> There is another small cleanup you could do here, to put a space in front
> of the */
> 
> julia

Thank you for pointing that out! I will add a space and resubmit this
patchset.

Maya

> >  		undecorated_smoothed_pwdb = undecorated_smoothed_ofdm;
> >  		ODM_RT_TRACE(dm, ODM_COMP_RSSI_MONITOR,
> >  			     "PWDB_0[%d] = (( %d ))\n", pktinfo->station_id,
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/368f5b749807cd02336274f978f3c6451655583d.1540968891.git.m.maya.nakamura%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >