From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [v4 6/7] i915/dp/fec: Configure the Forward Error Correction bits. Date: Wed, 31 Oct 2018 23:08:23 +0200 Message-ID: <20181031210823.GV9144@intel.com> References: <20181031004517.17250-1-anusha.srivatsa@intel.com> <20181031004517.17250-7-anusha.srivatsa@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4DFF689243 for ; Wed, 31 Oct 2018 21:08:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181031004517.17250-7-anusha.srivatsa@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anusha Srivatsa Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMzAsIDIwMTggYXQgMDU6NDU6MTZQTSAtMDcwMCwgQW51c2hhIFNyaXZhdHNh IHdyb3RlOgo+IElmIEZFQyBpcyBzdXBwb3J0ZWQsIHRoZSBjb3JyZXNwb25kaW5nCj4gRFBfVFBf Q1RMIHJlZ2lzdGVyIGJpdHMgaGF2ZSB0byBiZSBjb25maWd1cmVkLgo+IAo+IFRoZSBkcml2ZXIg aGFzIHRvIHByb2dyYW0gdGhlIEZFQ19FTkFCTEUgaW4gRFBfVFBfQ1RMWzMwXSByZWdpc3Rlcgo+ IGFuZCB3YWl0IHRpbGwgRkVDX1NUQVRVUyBpbiBEUF9UUF9DVExbMjhdIGlzIDEuCj4gQWxzbyBh ZGQgdGhlIHdhcm4gbWVzc2FnZSB0byBtYWtlIHN1cmUgdGhhdCB0aGUgY29udHJvbAo+IHJlZ2lz dGVyIGlzIGFscmVhZHkgYWN0aXZlIHdoaWxlIGVuYWJsaW5nIEZFQy4KPiAKPiB2MjoKPiAtIENo YW5nZSBjb21taXQgbWVzc2FnZS4gQ29uZmlndXJlIGZlYyBzdGF0ZSBhZnRlcgo+ICAgbGluayB0 cmFpbmluZyAoTWFuYXNpLCBHYXVyYXYpCj4gLSBSZW1vdmUgcmVkdW5kZW50IGNoZWNrcyAoTWFu YXNpKQo+IC0gUmVtb3ZlIHRoZSByZWdpc3RlcnMgdGhhdCBnZXQgYWRkZWQgYXV0b21hZ2ljYWxs eSAoQW51c2hhKQo+IAo+IHYzOiBzL2ludGVsX2RwX3NldF9mZWNfc3RhdGUoKS9pbnRlbF9kcF9l bmFibGVfZmVjX3N0YXRlKCkgKEdhdXJhdikKPiAKPiB2NDogcmViYXNlZC4KPiAKPiB2NToKPiAt IE1vdmUgdGhlIGNvZGUgdG8gdGhlIHByb3BlciBzcG90LCBhY2NvcmRpbmcgdG8gc3BlYy4oVmls bGUpCj4gLSBVc2UgZmVjIHN0YXRlIGFzIGEgY2hlY2sgdG9vLgo+IAo+IENjOiBHYXVyYXYgSyBT aW5naCA8Z2F1cmF2Lmsuc2luZ2hAaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5u aWt1bGFAbGludXguaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGlu dGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbnVzaGEgU3JpdmF0c2EgPGFudXNoYS5zcml2YXRz YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggIHwg IDIgKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCAzMCArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2Lmgg fCAgMiArKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVnLmgKPiBpbmRleCBlODVmNTNjYjljZGQuLjhiMTc1MzkzOTI5OSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC05MTM0LDYgKzkxMzQsNyBAQCBlbnVtIHNrbF9w b3dlcl9nYXRlIHsKPiAgI2RlZmluZSBfRFBfVFBfQ1RMX0IJCQkweDY0MTQwCj4gICNkZWZpbmUg RFBfVFBfQ1RMKHBvcnQpIF9NTUlPX1BPUlQocG9ydCwgX0RQX1RQX0NUTF9BLCBfRFBfVFBfQ1RM X0IpCj4gICNkZWZpbmUgIERQX1RQX0NUTF9FTkFCTEUJCQkoMSA8PCAzMSkKPiArI2RlZmluZSAg RFBfVFBfQ1RMX0ZFQ19FTkFCTEUJCQkoMSA8PCAzMCkKPiAgI2RlZmluZSAgRFBfVFBfQ1RMX01P REVfU1NUCQkJKDAgPDwgMjcpCj4gICNkZWZpbmUgIERQX1RQX0NUTF9NT0RFX01TVAkJCSgxIDw8 IDI3KQo+ICAjZGVmaW5lICBEUF9UUF9DVExfRk9SQ0VfQUNUCQkJKDEgPDwgMjUpCj4gQEAgLTkx NTIsNiArOTE1Myw3IEBAIGVudW0gc2tsX3Bvd2VyX2dhdGUgewo+ICAjZGVmaW5lIF9EUF9UUF9T VEFUVVNfQQkJCTB4NjQwNDQKPiAgI2RlZmluZSBfRFBfVFBfU1RBVFVTX0IJCQkweDY0MTQ0Cj4g ICNkZWZpbmUgRFBfVFBfU1RBVFVTKHBvcnQpIF9NTUlPX1BPUlQocG9ydCwgX0RQX1RQX1NUQVRV U19BLCBfRFBfVFBfU1RBVFVTX0IpCj4gKyNkZWZpbmUgIERQX1RQX1NUQVRVU19GRUNfRU5BQkxF X0xJVkUJCSgxIDw8IDI4KQo+ICAjZGVmaW5lICBEUF9UUF9TVEFUVVNfSURMRV9ET05FCQkJKDEg PDwgMjUpCj4gICNkZWZpbmUgIERQX1RQX1NUQVRVU19BQ1RfU0VOVAkJCSgxIDw8IDI0KQo+ICAj ZGVmaW5lICBEUF9UUF9TVEFUVVNfTU9ERV9TVEFUVVNfTVNUCQkoMSA8PCAyMykKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IGVmYmFkYTk1ZGM0ZS4uZjAzZjQ0ZjMzMmM3IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMjg4OSw2ICsyODg5LDMyIEBAIHN0YXRp YyB2b2lkIGludGVsX2RkaV9jbGtfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl cikKPiAgCX0KPiAgfQo+ICAKPiArdm9pZCBpbnRlbF9kcF9lbmFibGVfZmVjX3N0YXRlKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gKwkJCSAgICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKCkNhbiBiZSBzdGF0aWMuIGludGVsX2RkaV9lbmFibGVfZmVj KCkgc2VlbXMgbGlrZSBhIGJldHRlciBuYW1lLAphbmQgd2UgY2FuIGp1c3QgcGFzcyB0aGUgaW50 ZWxfZW5jb2RlciB0byB0aGlzIEkgdGhpbmsuIE5vIG5lZWQgdG8gCmRvIGFsbCB0aGUgImludGVs X2RwIHRvIGVuY29kZXIiIGd5bm1hc3RpY3MgdGhlbi4KCj4gK3sKPiArCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IGRwX3RvX2k5MTUoaW50ZWxfZHApOwo+ICsJc3RydWN0IGlu dGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9k cCk7Cj4gKwllbnVtIHBvcnQgcG9ydCA9IGludGVsX2RpZ19wb3J0LT5iYXNlLnBvcnQ7Cj4gKwl1 MzIgdmFsOwo+ICsKPiArCS8qIEZFQyBzdXBwb3J0IGV4aXN0cyBmb3IgRFAgMS40IG9ubHkgKi8K ClRoaXMgY29tbWVudCBpcyBtaXNsZWFkaW5nLiBUaGVyZSBhcmUgb3RoZXIgcmVhc29ucyBiZXNp ZGVzIDwgRFAgMS40IGZvcgpub3QgdXNpbmcgRkVDLiBJTU8ganVzdCBkcm9wIHRoZSBjb21tZW50 LgoKPiArCWlmICghY3J0Y19zdGF0ZS0+ZmVjX2VuYWJsZSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJ aWYgKCFjcnRjX3N0YXRlLT5kc2NfcGFyYW1zLmNvbXByZXNzaW9uX2VuYWJsZSkKPiArCQlyZXR1 cm47CgpUaGF0IGNoZWNrIGNhbiBiZSByZW1vdmVkIG5vdy4KCj4gKwo+ICsJdmFsID0gSTkxNV9S RUFEKERQX1RQX0NUTChwb3J0KSk7Cj4gKwl2YWwgfD0gRFBfVFBfQ1RMX0ZFQ19FTkFCTEU7Cj4g KwlJOTE1X1dSSVRFKERQX1RQX0NUTChwb3J0KSwgdmFsKTsKPiArCj4gKwlpZiAoaW50ZWxfd2Fp dF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIERQX1RQX1NUQVRVUyhwb3J0KSwKPiArCQkJCSAgICBE UF9UUF9TVEFUVVNfRkVDX0VOQUJMRV9MSVZFLAo+ICsJCQkJICAgIERQX1RQX1NUQVRVU19GRUNf RU5BQkxFX0xJVkUsCj4gKwkJCQkgICAgMSkpCj4gKwkJRFJNX0VSUk9SKCJUaW1lZCBvdXQgd2Fp dGluZyBmb3IgRkVDIEVuYWJsZSBTdGF0dXNcbiIpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBp bnRlbF9kZGlfcHJlX2VuYWJsZV9kcChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAg CQkJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiAgCQkJ CSAgICBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZSkKPiBAQCAt MjkzNCw5ICsyOTYwLDEzIEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9wcmVfZW5hYmxlX2RwKHN0 cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCQkJCSAgICAgIERQX0RFQ09NUFJFU1NJ T05fRU4pOwo+ICAJaW50ZWxfZHBfc2lua19zZXRfZmVjX3JlYWR5KGludGVsX2RwLCBjcnRjX3N0 YXRlLCBEUF9GRUNfUkVBRFkpOwo+ICAJaW50ZWxfZHBfc3RhcnRfbGlua190cmFpbihpbnRlbF9k cCk7Cj4gKwoKVW5yZWxhdGVkIHdoaXRlc3BhY2UgY2hhbmdlLgoKPiAgCWlmIChwb3J0ICE9IFBP UlRfQSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpCj4gIAkJaW50ZWxfZHBfc3RvcF9saW5r X3RyYWluKGludGVsX2RwKTsKPiAgCj4gKwkvKiBTZXQgRkVDIHN0YXRlIGFmdGVyIGxpbmsgdHJh aW5pbmcgKi8KClJlZHVuZGFudCBjb21tZW50LgoKPiArCWludGVsX2RwX2VuYWJsZV9mZWNfc3Rh dGUoaW50ZWxfZHAsIGNydGNfc3RhdGUpOwo+ICsKPiAgCWljbF9lbmFibGVfcGh5X2Nsb2NrX2dh dGluZyhkaWdfcG9ydCk7Cj4gIAo+ICAJaWYgKCFpc19tc3QpCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgKPiBpbmRleCAyYTA4MDIwNTk2OGQuLjFjZGZhOWM1ZGE0MyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oCj4gQEAgLTE3OTksNiArMTc5OSw4IEBAIHZvaWQgaW50ZWxfZHBfc2lu a19zZXRfZGVjb21wcmVzc2lvbl9zdGF0ZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICB2 b2lkIGludGVsX2RwX3Npbmtfc2V0X2ZlY19yZWFkeShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw LAo+ICAJCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICAJ CQkJIGludCBzdGF0ZSk7Cj4gK3ZvaWQgaW50ZWxfZHBfZW5hYmxlX2ZlY19zdGF0ZShzdHJ1Y3Qg aW50ZWxfZHAgKmludGVsX2RwLAo+ICsJCQkgICAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpOwo+ICB2b2lkIGludGVsX2RwX2VuY29kZXJfcmVzZXQoc3RydWN0 IGRybV9lbmNvZGVyICplbmNvZGVyKTsKPiAgdm9pZCBpbnRlbF9kcF9lbmNvZGVyX3N1c3BlbmQo c3RydWN0IGludGVsX2VuY29kZXIgKmludGVsX2VuY29kZXIpOwo+ICB2b2lkIGludGVsX2RwX2Vu Y29kZXJfZGVzdHJveShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpOwo+IC0tIAo+IDIuMTcu MQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK