From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: [PATCH v3 1/3] mmc: tmio: enable module clock before resetting when resuming
Date: Thu, 1 Nov 2018 00:05:52 +0100 [thread overview]
Message-ID: <20181031230554.1660-2-niklas.soderlund@ragnatech.se> (raw)
In-Reply-To: <20181031230554.1660-1-niklas.soderlund@ragnatech.se>
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
On runtime power management resume, the host clock needs to be
enabled before calling tmio_mmc_reset. If the mmc device has a power
domain entry, the host clock is enabled via genpd_runtime_resume,
running before tmio_mmc_host_runtime_resume. If the mmc device has no
power domain entry, however, genpd_runtime_resume is not called. This
patch changes tmio_mmc_host_runtime_resume to enable the host clock
before calling tmio_mmc_reset.
Based on work from Masaharu Hayakawa.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
drivers/mmc/host/tmio_mmc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 8d64f6196f33e882..953562a12a0d6ebc 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -1328,8 +1328,8 @@ int tmio_mmc_host_runtime_resume(struct device *dev)
{
struct tmio_mmc_host *host = dev_get_drvdata(dev);
- host->reset(host);
tmio_mmc_clk_enable(host);
+ host->reset(host);
if (host->clk_cache)
host->set_clock(host, host->clk_cache);
--
2.19.1
next prev parent reply other threads:[~2018-11-01 8:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 23:05 [PATCH v3 0/3] mmc: tmio: fix reset operation Niklas Söderlund
2018-10-31 23:05 ` Niklas Söderlund [this message]
2018-11-01 19:01 ` [PATCH v3 1/3] mmc: tmio: enable module clock before resetting when resuming Wolfram Sang
2018-11-02 6:51 ` Masahiro Yamada
2018-11-02 11:58 ` Simon Horman
2018-10-31 23:05 ` [PATCH v3 2/3] mmc: tmio: fix reset operation Niklas Söderlund
2018-11-01 19:02 ` Wolfram Sang
2018-11-02 6:54 ` Masahiro Yamada
2018-11-26 16:53 ` Niklas Söderlund
2018-10-31 23:05 ` [PATCH v3 3/3] mmc: renesas_sdhi: add initial setting of interrupt mask register Niklas Söderlund
2018-11-01 19:02 ` Wolfram Sang
2018-11-02 12:02 ` Simon Horman
2018-11-01 19:04 ` [PATCH v3 0/3] mmc: tmio: fix reset operation Wolfram Sang
2018-11-01 19:35 ` Wolfram Sang
2018-11-19 12:08 ` Ulf Hansson
2018-11-19 12:14 ` Wolfram Sang
2018-11-19 13:08 ` Ulf Hansson
2018-11-19 13:33 ` Wolfram Sang
2018-11-19 17:28 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031230554.1660-2-niklas.soderlund@ragnatech.se \
--to=niklas.soderlund@ragnatech.se \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.