diff for duplicates of <20181101064339.GD16399@350D> diff --git a/a/1.txt b/N1/1.txt index a658851..82268a0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -164,7 +164,7 @@ On Mon, Oct 22, 2018 at 10:48:34AM +0530, Bharata B Rao wrote: > #include "book3s.h" > > @@ -935,6 +936,20 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu) -> if (ret = H_TOO_HARD) +> if (ret == H_TOO_HARD) > return RESUME_HOST; > break; > + case H_SVM_PAGE_IN: @@ -372,7 +372,7 @@ additional code you've got. > + > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > + hlist_for_each_entry(p, list, hlist) { -> + if (p->addr = gpa) { +> + if (p->addr == gpa) { > + hlist_del(&p->hlist); > + kfree(p); > + return; @@ -402,7 +402,7 @@ additional code you've got. > + spin_lock_irqsave(&kvmppc_hmm_lock, flags); > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > + hlist_for_each_entry(p, list, hlist) { -> + if (p->addr = gpa) { +> + if (p->addr == gpa) { > + found = true; > + break; > + } @@ -592,7 +592,7 @@ So no large page support? > + if (!addr) > + return H_PARAMETER; -So addr = 0 is invalid? +So addr == 0 is invalid? > + end = addr + (1UL << page_shift); > + @@ -653,7 +653,7 @@ We've probably already OOM'd here :) Do we need pfn << PAGE_SHIFT? > + pvt->gpa, 0, PAGE_SHIFT); -> + if (ret = U_SUCCESS) +> + if (ret == U_SUCCESS) > + *dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED; > +} > + @@ -690,7 +690,7 @@ Do we need pfn << PAGE_SHIFT? > + if (migrate_vma(&kvmppc_hmm_fault_migrate_ops, vma, addr, end, > + &src_pfn, &dst_pfn, NULL)) > + return VM_FAULT_SIGBUS; -> + if (dst_pfn = MIGRATE_PFN_ERROR) +> + if (dst_pfn == MIGRATE_PFN_ERROR) > + return VM_FAULT_SIGBUS; > + return 0; > +} diff --git a/a/content_digest b/N1/content_digest index 602eea5..bd188da 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,16 +2,16 @@ "ref\020181022051837.1165-2-bharata@linux.ibm.com\0" "From\0Balbir Singh <bsingharora@gmail.com>\0" "Subject\0Re: [RFC PATCH v1 1/4] kvmppc: HMM backend driver to manage pages of secure guest\0" - "Date\0Thu, 01 Nov 2018 06:43:39 +0000\0" + "Date\0Thu, 1 Nov 2018 17:43:39 +1100\0" "To\0Bharata B Rao <bharata@linux.ibm.com>\0" - "Cc\0linuxppc-dev@lists.ozlabs.org" + "Cc\0linuxram@us.ibm.com" kvm-ppc@vger.kernel.org - linux-mm@kvack.org - paulus@au1.ibm.com benh@linux.ibm.com - aneesh.kumar@linux.vnet.ibm.com + linux-mm@kvack.org jglisse@redhat.com - " linuxram@us.ibm.com\0" + aneesh.kumar@linux.vnet.ibm.com + paulus@au1.ibm.com + " linuxppc-dev@lists.ozlabs.org\0" "\00:1\0" "b\0" "On Mon, Oct 22, 2018 at 10:48:34AM +0530, Bharata B Rao wrote:\n" @@ -180,7 +180,7 @@ "> #include \"book3s.h\"\n" "> \n" "> @@ -935,6 +936,20 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu)\n" - "> \t\tif (ret = H_TOO_HARD)\n" + "> \t\tif (ret == H_TOO_HARD)\n" "> \t\t\treturn RESUME_HOST;\n" "> \t\tbreak;\n" "> +\tcase H_SVM_PAGE_IN:\n" @@ -388,7 +388,7 @@ "> +\n" "> +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> +\thlist_for_each_entry(p, list, hlist) {\n" - "> +\t\tif (p->addr = gpa) {\n" + "> +\t\tif (p->addr == gpa) {\n" "> +\t\t\thlist_del(&p->hlist);\n" "> +\t\t\tkfree(p);\n" "> +\t\t\treturn;\n" @@ -418,7 +418,7 @@ "> +\tspin_lock_irqsave(&kvmppc_hmm_lock, flags);\n" "> +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> +\thlist_for_each_entry(p, list, hlist) {\n" - "> +\t\tif (p->addr = gpa) {\n" + "> +\t\tif (p->addr == gpa) {\n" "> +\t\t\tfound = true;\n" "> +\t\t\tbreak;\n" "> +\t\t}\n" @@ -608,7 +608,7 @@ "> +\tif (!addr)\n" "> +\t\treturn H_PARAMETER;\n" "\n" - "So addr = 0 is invalid?\n" + "So addr == 0 is invalid?\n" "\n" "> +\tend = addr + (1UL << page_shift);\n" "> +\n" @@ -669,7 +669,7 @@ "Do we need pfn << PAGE_SHIFT?\n" "\n" "> +\t\t\t pvt->gpa, 0, PAGE_SHIFT);\n" - "> +\tif (ret = U_SUCCESS)\n" + "> +\tif (ret == U_SUCCESS)\n" "> +\t\t*dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED;\n" "> +}\n" "> +\n" @@ -706,7 +706,7 @@ "> +\tif (migrate_vma(&kvmppc_hmm_fault_migrate_ops, vma, addr, end,\n" "> +\t\t\t&src_pfn, &dst_pfn, NULL))\n" "> +\t\treturn VM_FAULT_SIGBUS;\n" - "> +\tif (dst_pfn = MIGRATE_PFN_ERROR)\n" + "> +\tif (dst_pfn == MIGRATE_PFN_ERROR)\n" "> +\t\treturn VM_FAULT_SIGBUS;\n" "> +\treturn 0;\n" "> +}\n" @@ -840,4 +840,4 @@ "\n" Balbir Singh. -521e7dcca534f70caff3bc9a938990f527bca6c3d219ca77de1462398b749203 +008f9714f15ae0848e221437bfa363d19e1a5ce2acaefcd31750a2e5f37e6ae1
diff --git a/a/1.txt b/N2/1.txt index a658851..39f85ad 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -164,7 +164,7 @@ On Mon, Oct 22, 2018 at 10:48:34AM +0530, Bharata B Rao wrote: > #include "book3s.h" > > @@ -935,6 +936,20 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu) -> if (ret = H_TOO_HARD) +> if (ret == H_TOO_HARD) > return RESUME_HOST; > break; > + case H_SVM_PAGE_IN: @@ -264,7 +264,7 @@ additional code you've got. > + * HMM driver to manage page migration between normal and secure > + * memory. > + * -> + * Based on Jérôme Glisse's HMM dummy driver. +> + * Based on Jerome Glisse's HMM dummy driver. > + * > + * Copyright 2018 Bharata B Rao, IBM Corp. <bharata@linux.ibm.com> > + */ @@ -372,7 +372,7 @@ additional code you've got. > + > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > + hlist_for_each_entry(p, list, hlist) { -> + if (p->addr = gpa) { +> + if (p->addr == gpa) { > + hlist_del(&p->hlist); > + kfree(p); > + return; @@ -402,7 +402,7 @@ additional code you've got. > + spin_lock_irqsave(&kvmppc_hmm_lock, flags); > + list = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)]; > + hlist_for_each_entry(p, list, hlist) { -> + if (p->addr = gpa) { +> + if (p->addr == gpa) { > + found = true; > + break; > + } @@ -592,7 +592,7 @@ So no large page support? > + if (!addr) > + return H_PARAMETER; -So addr = 0 is invalid? +So addr == 0 is invalid? > + end = addr + (1UL << page_shift); > + @@ -653,7 +653,7 @@ We've probably already OOM'd here :) Do we need pfn << PAGE_SHIFT? > + pvt->gpa, 0, PAGE_SHIFT); -> + if (ret = U_SUCCESS) +> + if (ret == U_SUCCESS) > + *dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED; > +} > + @@ -690,7 +690,7 @@ Do we need pfn << PAGE_SHIFT? > + if (migrate_vma(&kvmppc_hmm_fault_migrate_ops, vma, addr, end, > + &src_pfn, &dst_pfn, NULL)) > + return VM_FAULT_SIGBUS; -> + if (dst_pfn = MIGRATE_PFN_ERROR) +> + if (dst_pfn == MIGRATE_PFN_ERROR) > + return VM_FAULT_SIGBUS; > + return 0; > +} diff --git a/a/content_digest b/N2/content_digest index 602eea5..a73bf41 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\020181022051837.1165-2-bharata@linux.ibm.com\0" "From\0Balbir Singh <bsingharora@gmail.com>\0" "Subject\0Re: [RFC PATCH v1 1/4] kvmppc: HMM backend driver to manage pages of secure guest\0" - "Date\0Thu, 01 Nov 2018 06:43:39 +0000\0" + "Date\0Thu, 1 Nov 2018 17:43:39 +1100\0" "To\0Bharata B Rao <bharata@linux.ibm.com>\0" "Cc\0linuxppc-dev@lists.ozlabs.org" kvm-ppc@vger.kernel.org @@ -180,7 +180,7 @@ "> #include \"book3s.h\"\n" "> \n" "> @@ -935,6 +936,20 @@ int kvmppc_pseries_do_hcall(struct kvm_vcpu *vcpu)\n" - "> \t\tif (ret = H_TOO_HARD)\n" + "> \t\tif (ret == H_TOO_HARD)\n" "> \t\t\treturn RESUME_HOST;\n" "> \t\tbreak;\n" "> +\tcase H_SVM_PAGE_IN:\n" @@ -280,7 +280,7 @@ "> + * HMM driver to manage page migration between normal and secure\n" "> + * memory.\n" "> + *\n" - "> + * Based on J\303\251r\303\264me Glisse's HMM dummy driver.\n" + "> + * Based on Jerome Glisse's HMM dummy driver.\n" "> + *\n" "> + * Copyright 2018 Bharata B Rao, IBM Corp. <bharata@linux.ibm.com>\n" "> + */\n" @@ -388,7 +388,7 @@ "> +\n" "> +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> +\thlist_for_each_entry(p, list, hlist) {\n" - "> +\t\tif (p->addr = gpa) {\n" + "> +\t\tif (p->addr == gpa) {\n" "> +\t\t\thlist_del(&p->hlist);\n" "> +\t\t\tkfree(p);\n" "> +\t\t\treturn;\n" @@ -418,7 +418,7 @@ "> +\tspin_lock_irqsave(&kvmppc_hmm_lock, flags);\n" "> +\tlist = &hmm_hash[kvmppc_hmm_pfn_hash_fn(gpa)];\n" "> +\thlist_for_each_entry(p, list, hlist) {\n" - "> +\t\tif (p->addr = gpa) {\n" + "> +\t\tif (p->addr == gpa) {\n" "> +\t\t\tfound = true;\n" "> +\t\t\tbreak;\n" "> +\t\t}\n" @@ -608,7 +608,7 @@ "> +\tif (!addr)\n" "> +\t\treturn H_PARAMETER;\n" "\n" - "So addr = 0 is invalid?\n" + "So addr == 0 is invalid?\n" "\n" "> +\tend = addr + (1UL << page_shift);\n" "> +\n" @@ -669,7 +669,7 @@ "Do we need pfn << PAGE_SHIFT?\n" "\n" "> +\t\t\t pvt->gpa, 0, PAGE_SHIFT);\n" - "> +\tif (ret = U_SUCCESS)\n" + "> +\tif (ret == U_SUCCESS)\n" "> +\t\t*dst_pfn = migrate_pfn(pfn) | MIGRATE_PFN_LOCKED;\n" "> +}\n" "> +\n" @@ -706,7 +706,7 @@ "> +\tif (migrate_vma(&kvmppc_hmm_fault_migrate_ops, vma, addr, end,\n" "> +\t\t\t&src_pfn, &dst_pfn, NULL))\n" "> +\t\treturn VM_FAULT_SIGBUS;\n" - "> +\tif (dst_pfn = MIGRATE_PFN_ERROR)\n" + "> +\tif (dst_pfn == MIGRATE_PFN_ERROR)\n" "> +\t\treturn VM_FAULT_SIGBUS;\n" "> +\treturn 0;\n" "> +}\n" @@ -840,4 +840,4 @@ "\n" Balbir Singh. -521e7dcca534f70caff3bc9a938990f527bca6c3d219ca77de1462398b749203 +6cb39a6750d0e36a3c2401b963aaa94629a5e0e123a41ef23e0a9f13b54832d9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.