From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: PROPOSAL: Extend inline asm syntax with size spec Date: Thu, 1 Nov 2018 10:01:14 +0100 Message-ID: <20181101090114.GE3159@hirez.programming.kicks-ass.net> References: <20181009145330.GT29268@gate.crashing.org> <20181010072240.GB103159@gmail.com> <20181010080324.GV29268@gate.crashing.org> <20181010081906.GA5533@zn.tnic> <20181010185432.GB29268@gate.crashing.org> <20181010191427.GF5533@zn.tnic> <20181013193335.GD31650@zn.tnic> <20181031125526.GA13219@hirez.programming.kicks-ass.net> <5f987ecbb4962b4796615928d9d71f2cf9b21a3b.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5f987ecbb4962b4796615928d9d71f2cf9b21a3b.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Joe Perches Cc: Kate Stewart , Christopher Li , virtualization@lists.linux-foundation.org, Masahiro Yamada , Nadav Amit , Jan Beulich , "H. Peter Anvin" , Sam Ravnborg , Ingo Molnar , x86@kernel.org, linux-sparse@vger.kernel.org, Ingo Molnar , linux-xtensa@linux-xtensa.org, Kees Cook , Segher Boessenkool , Chris Zankel , Michael Matz , Borislav Petkov , Josh Poimboeuf , Alok Kataria , Juergen Gross , gcc@gcc.gnu.org, Richard Biener , Max Filippov , Greg Kroah-Hartman , linux-kerne List-Id: linux-sparse@vger.kernel.org On Wed, Oct 31, 2018 at 10:20:00PM -0700, Joe Perches wrote: > On Wed, 2018-10-31 at 13:55 +0100, Peter Zijlstra wrote: > > > > Anyway, with the below patch, I get: > > > > text data bss dec hex filename > > 17385183 5064780 1953892 24403855 1745f8f defconfig-build/vmlinux > > 17385678 5064780 1953892 24404350 174617e defconfig-build/vmlinux > > > > Which shows we inline more (look for asm_volatile for the actual > > changes). > [] > > scripts/checkpatch.pl | 8 ++--- > > scripts/genksyms/keywords.c | 4 +-- > > scripts/kernel-doc | 4 +-- > > I believe these should be excluded from the conversions. Probably, yes. It compiled, which was all I cared about :-) BTW, if we do that conversion, we should upgrade the checkpatch warn to an error I suppose.