From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 02/14] drm/i915: Clean up skl_program_scaler() Date: Thu, 1 Nov 2018 11:13:50 -0700 Message-ID: <20181101181350.GC2092@intel.com> References: <20181101150605.18235-3-ville.syrjala@linux.intel.com> <20181101151736.20522-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27F9A6E465 for ; Thu, 1 Nov 2018 18:13:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181101151736.20522-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDEsIDIwMTggYXQgMDU6MTc6MzZQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFJlbW92ZSB0aGUgInNpemVzIGFyZSAwIGJhc2VkIiBzdHVmZiB0aGF0IGlzIG5v dCBldmVuIHRydWUgZm9yIHRoZQo+IHNjYWxlci4KPiAKPiB2MjogUmViYXNlCj4gCj4gU2lnbmVk LW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K ClJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDE4ICsrKysrLS0tLS0t LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+IGluZGV4IDMwYjc0ODVmMTk5 Mi4uYTc3YTE3ZmRhNjkyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Nwcml0ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiBA QCAtMzEwLDEyICszMTAsMTEgQEAgc2tsX3BsYW5lX21heF9zdHJpZGUoc3RydWN0IGludGVsX3Bs YW5lICpwbGFuZSwKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQKPiAtc2tsX3Byb2dyYW1fc2NhbGVy KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkgICBzdHJ1Y3QgaW50ZWxf cGxhbmUgKnBsYW5lLAo+ICtza2xfcHJvZ3JhbV9zY2FsZXIoc3RydWN0IGludGVsX3BsYW5lICpw bGFuZSwKPiAgCQkgICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwK PiAgCQkgICBjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICB7 Cj4gLQllbnVtIHBsYW5lX2lkIHBsYW5lX2lkID0gcGxhbmUtPmlkOwo+ICsJc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFzZS5kZXYpOwo+ICAJZW51 bSBwaXBlIHBpcGUgPSBwbGFuZS0+cGlwZTsKPiAgCWludCBzY2FsZXJfaWQgPSBwbGFuZV9zdGF0 ZS0+c2NhbGVyX2lkOwo+ICAJY29uc3Qgc3RydWN0IGludGVsX3NjYWxlciAqc2NhbGVyID0KPiBA QCAtMzI3LDEwICszMjYsNiBAQCBza2xfcHJvZ3JhbV9zY2FsZXIoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ICAJdTE2IHlfaHBoYXNlLCB1dl9yZ2JfaHBoYXNlOwo+ICAJdTE2 IHlfdnBoYXNlLCB1dl9yZ2JfdnBoYXNlOwo+ICAKPiAtCS8qIFNpemVzIGFyZSAwIGJhc2VkICov Cj4gLQljcnRjX3ctLTsKPiAtCWNydGNfaC0tOwo+IC0KPiAgCS8qIFRPRE86IGhhbmRsZSBzdWIt cGl4ZWwgY29vcmRpbmF0ZXMgKi8KPiAgCWlmIChwbGFuZV9zdGF0ZS0+YmFzZS5mYi0+Zm9ybWF0 LT5mb3JtYXQgPT0gRFJNX0ZPUk1BVF9OVjEyICYmCj4gIAkgICAgIWljbF9pc19oZHJfcGxhbmUo cGxhbmUpKSB7Cj4gQEAgLTM1MCwxNSArMzQ1LDE0IEBAIHNrbF9wcm9ncmFtX3NjYWxlcihzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAl9Cj4gIAo+ICAJSTkxNV9XUklURV9G VyhTS0xfUFNfQ1RSTChwaXBlLCBzY2FsZXJfaWQpLAo+IC0JCSAgICAgIFBTX1NDQUxFUl9FTiB8 IFBTX1BMQU5FX1NFTChwbGFuZV9pZCkgfCBzY2FsZXItPm1vZGUpOwo+ICsJCSAgICAgIFBTX1ND QUxFUl9FTiB8IFBTX1BMQU5FX1NFTChwbGFuZS0+aWQpIHwgc2NhbGVyLT5tb2RlKTsKPiAgCUk5 MTVfV1JJVEVfRlcoU0tMX1BTX1BXUl9HQVRFKHBpcGUsIHNjYWxlcl9pZCksIDApOwo+ICAJSTkx NV9XUklURV9GVyhTS0xfUFNfVlBIQVNFKHBpcGUsIHNjYWxlcl9pZCksCj4gIAkJICAgICAgUFNf WV9QSEFTRSh5X3ZwaGFzZSkgfCBQU19VVl9SR0JfUEhBU0UodXZfcmdiX3ZwaGFzZSkpOwo+ICAJ STkxNV9XUklURV9GVyhTS0xfUFNfSFBIQVNFKHBpcGUsIHNjYWxlcl9pZCksCj4gIAkJICAgICAg UFNfWV9QSEFTRSh5X2hwaGFzZSkgfCBQU19VVl9SR0JfUEhBU0UodXZfcmdiX2hwaGFzZSkpOwo+ ICAJSTkxNV9XUklURV9GVyhTS0xfUFNfV0lOX1BPUyhwaXBlLCBzY2FsZXJfaWQpLCAoY3J0Y194 IDw8IDE2KSB8IGNydGNfeSk7Cj4gLQlJOTE1X1dSSVRFX0ZXKFNLTF9QU19XSU5fU1oocGlwZSwg c2NhbGVyX2lkKSwKPiAtCQkgICAgICAoKGNydGNfdyArIDEpIDw8IDE2KXwoY3J0Y19oICsgMSkp Owo+ICsJSTkxNV9XUklURV9GVyhTS0xfUFNfV0lOX1NaKHBpcGUsIHNjYWxlcl9pZCksIChjcnRj X3cgPDwgMTYpIHwgY3J0Y19oKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQKPiBAQCAtNDQxLDEx ICs0MzUsOSBAQCBza2xfcHJvZ3JhbV9wbGFuZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ ICAJCUk5MTVfV1JJVEVfRlcoUExBTkVfQ1VTX0NUTChwaXBlLCBwbGFuZV9pZCksIGN1c19jdGwp Owo+ICAJfQo+ICAKPiAtCS8qIHByb2dyYW0gcGxhbmUgc2NhbGVyICovCj4gIAlpZiAocGxhbmVf c3RhdGUtPnNjYWxlcl9pZCA+PSAwKSB7Cj4gIAkJaWYgKCFzbGF2ZSkKPiAtCQkJc2tsX3Byb2dy YW1fc2NhbGVyKGRldl9wcml2LCBwbGFuZSwKPiAtCQkJCQkgICBjcnRjX3N0YXRlLCBwbGFuZV9z dGF0ZSk7Cj4gKwkJCXNrbF9wcm9ncmFtX3NjYWxlcihwbGFuZSwgY3J0Y19zdGF0ZSwgcGxhbmVf c3RhdGUpOwo+ICAKPiAgCQlJOTE1X1dSSVRFX0ZXKFBMQU5FX1BPUyhwaXBlLCBwbGFuZV9pZCks IDApOwo+ICAJfSBlbHNlIHsKPiAtLSAKPiAyLjE4LjEKPiAKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==