From: Masami Hiramatsu <mhiramat@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Brendan Gregg <bgregg@netflix.com>,
Christian Brauner <christian@brauner.io>,
Aleksa Sarai <asarai@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kretprobe: produce sane stack traces
Date: Thu, 1 Nov 2018 19:13:47 +0900 [thread overview]
Message-ID: <20181101191347.74eadff4a5d1fab2d79d7efe@kernel.org> (raw)
In-Reply-To: <20181031133912.3j5tryq2vyhkdn4d@yavin>
On Thu, 1 Nov 2018 00:39:12 +1100
Aleksa Sarai <cyphar@cyphar.com> wrote:
> On 2018-10-31, Steven Rostedt <rostedt@goodmis.org> wrote:
> > > Anyway, until that merge happens, this patch looks good to avoid
> > > this issue for generic solution (e.g. for the arch which doesn't
> > > supports retstack).
> >
> > I think its time to come up with an algorithm that makes function graph
> > work with multiple users, and have kretprobes be able to hook into it
> > just like kprobes hooks into function tracer.
> >
> > I have some ideas on how to get this done, and will try to have an RFC
> > patch set ready by plumbers.
>
> Should I continue working on this patchset?
Yes, until we finally introduce Steven's algorithm on all arch (yeah, we still
have some archs which don't support graph-tracer but supports kprobes),
I think your patch is the best fix for this issue.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2018-11-01 10:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 13:22 [PATCH] kretprobe: produce sane stack traces Aleksa Sarai
2018-10-30 1:12 ` Masami Hiramatsu
2018-10-30 3:19 ` Aleksa Sarai
2018-11-01 8:06 ` Masami Hiramatsu
2018-10-31 13:03 ` Steven Rostedt
2018-10-31 13:39 ` Aleksa Sarai
2018-11-01 10:13 ` Masami Hiramatsu [this message]
2018-11-01 10:49 ` Aleksa Sarai
2018-11-01 13:22 ` Steven Rostedt
2018-11-01 15:01 ` Masami Hiramatsu
2018-11-01 20:25 ` Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101191347.74eadff4a5d1fab2d79d7efe@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=asarai@suse.de \
--cc=bgregg@netflix.com \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=davem@davemloft.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.